From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C818FC433E2 for ; Tue, 8 Sep 2020 03:38:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 945D82075A for ; Tue, 8 Sep 2020 03:38:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599536310; bh=BanmiEvbGMWVIhkeYXUdmPe/vH8P2n26h9sXyKtB4E0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=fF4TiayAZOpNYOVvXiWKQgcjHguhPEFHEDIgHudsE1dDe5jHL/9nZRz4dpNtNEvpF nVoyt6ebL8Sf8iBadvJus89KiM0BpiVkvv10cGkYWRtooI2b9PRPzX12DHUa84jolS 78EA6W/Fwo9cFe9bOInhVqMemtOZPS2Ck1uVKMaM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728513AbgIHDiY (ORCPT ); Mon, 7 Sep 2020 23:38:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:42152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728327AbgIHDiV (ORCPT ); Mon, 7 Sep 2020 23:38:21 -0400 Received: from sol.localdomain (172-10-235-113.lightspeed.sntcca.sbcglobal.net [172.10.235.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1158B2075A; Tue, 8 Sep 2020 03:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1599536301; bh=BanmiEvbGMWVIhkeYXUdmPe/vH8P2n26h9sXyKtB4E0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2Y3vXWeVFofFzu+GH1t0rVmNIMeav5M/KvIEqsAOXfrQ4y6Qmvi+uwQpNRjKER/lj +tG4kb+LIZgfYCWoDI4majUE1eoNE/Y6ahIKRFDNR9AzH7+GUUCGA3m0MMGFklomVn bOBl4FWNCKdfiOWw3r5HbyCbPIuAaFzuiCrXGeBw= Date: Mon, 7 Sep 2020 20:38:19 -0700 From: Eric Biggers To: Jeff Layton Cc: ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org Subject: Re: [RFC PATCH v2 01/18] vfs: export new_inode_pseudo Message-ID: <20200908033819.GD68127@sol.localdomain> References: <20200904160537.76663-1-jlayton@kernel.org> <20200904160537.76663-2-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200904160537.76663-2-jlayton@kernel.org> Sender: ceph-devel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On Fri, Sep 04, 2020 at 12:05:20PM -0400, Jeff Layton wrote: > Ceph needs to be able to allocate inodes ahead of a create that might > involve a fscrypt-encrypted inode. new_inode() almost fits the bill, > but it puts the inode on the sb->s_inodes list, and we don't want to > do that until we're ready to insert it into the hash. > > Signed-off-by: Jeff Layton > --- > fs/inode.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/fs/inode.c b/fs/inode.c > index 72c4c347afb7..61554c2477ab 100644 > --- a/fs/inode.c > +++ b/fs/inode.c > @@ -935,6 +935,7 @@ struct inode *new_inode_pseudo(struct super_block *sb) > } > return inode; > } > +EXPORT_SYMBOL(new_inode_pseudo); > What's the problem with putting the new inode on sb->s_inodes already? That's what all the other filesystems do. - Eric