CEPH-Devel archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ceph: don't SetPageError on readpage errors
@ 2020-10-06 14:13 Jeff Layton
  2020-10-06 14:52 ` Matthew Wilcox
  0 siblings, 1 reply; 2+ messages in thread
From: Jeff Layton @ 2020-10-06 14:13 UTC (permalink / raw)
  To: ceph-devel; +Cc: willy, idryomov, ukernel

PageError really only has meaning within a particular subsystem. Nothing
looks at this bit in the core kernel code, and ceph itself doesn't care
about it. Don't bother setting the PageError bit on error.

Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
 fs/ceph/addr.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index 97827f68a3e7..137c0a5a2a0d 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -241,7 +241,6 @@ static int ceph_do_readpage(struct file *filp, struct page *page)
 	if (err == -ENOENT)
 		err = 0;
 	if (err < 0) {
-		SetPageError(page);
 		ceph_fscache_readpage_cancel(inode, page);
 		if (err == -EBLOCKLISTED)
 			fsc->blocklisted = true;
-- 
2.26.2


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ceph: don't SetPageError on readpage errors
  2020-10-06 14:13 [PATCH] ceph: don't SetPageError on readpage errors Jeff Layton
@ 2020-10-06 14:52 ` Matthew Wilcox
  0 siblings, 0 replies; 2+ messages in thread
From: Matthew Wilcox @ 2020-10-06 14:52 UTC (permalink / raw)
  To: Jeff Layton; +Cc: ceph-devel, idryomov, ukernel, David Howells

On Tue, Oct 06, 2020 at 10:13:07AM -0400, Jeff Layton wrote:
> PageError really only has meaning within a particular subsystem. Nothing
> looks at this bit in the core kernel code, and ceph itself doesn't care
> about it. Don't bother setting the PageError bit on error.

I wondered if fscache might be interested, but it seems like it doesn't
particularly care.  It's still interested in PageError for backing
store pages, but not for the filesystem being cached.

Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>

> Cc: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>  fs/ceph/addr.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 97827f68a3e7..137c0a5a2a0d 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -241,7 +241,6 @@ static int ceph_do_readpage(struct file *filp, struct page *page)
>  	if (err == -ENOENT)
>  		err = 0;
>  	if (err < 0) {
> -		SetPageError(page);
>  		ceph_fscache_readpage_cancel(inode, page);
>  		if (err == -EBLOCKLISTED)
>  			fsc->blocklisted = true;
> -- 
> 2.26.2
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-06 14:13 [PATCH] ceph: don't SetPageError on readpage errors Jeff Layton
2020-10-06 14:52 ` Matthew Wilcox

CEPH-Devel archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/ceph-devel/0 ceph-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ceph-devel ceph-devel/ https://lore.kernel.org/ceph-devel \
		ceph-devel@vger.kernel.org
	public-inbox-index ceph-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.ceph-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git