From: Christoph Hellwig <hch@lst.de> To: Jens Axboe <axboe@kernel.dk> Cc: "Justin Sanders" <justin@coraid.com>, "Josef Bacik" <josef@toxicpanda.com>, "Ilya Dryomov" <idryomov@gmail.com>, "Jack Wang" <jinpu.wang@cloud.ionos.com>, "Michael S. Tsirkin" <mst@redhat.com>, "Jason Wang" <jasowang@redhat.com>, "Paolo Bonzini" <pbonzini@redhat.com>, "Stefan Hajnoczi" <stefanha@redhat.com>, "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>, "Roger Pau Monné" <roger.pau@citrix.com>, "Minchan Kim" <minchan@kernel.org>, "Mike Snitzer" <snitzer@redhat.com>, "Song Liu" <song@kernel.org>, "Martin K. Petersen" <martin.petersen@oracle.com>, dm-devel@redhat.com, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH 26/78] block: add a new set_read_only method Date: Mon, 16 Nov 2020 15:57:17 +0100 Message-ID: <20201116145809.410558-27-hch@lst.de> (raw) In-Reply-To: <20201116145809.410558-1-hch@lst.de> Add a new method to allow for driver-specific processing when setting or clearing the block device read-only state. This allows to replace the cumbersome and error-prone override of the whole ioctl implementation. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/ioctl.c | 5 +++++ include/linux/blkdev.h | 1 + 2 files changed, 6 insertions(+) diff --git a/block/ioctl.c b/block/ioctl.c index c6d8863f040945..a6fa16b9770593 100644 --- a/block/ioctl.c +++ b/block/ioctl.c @@ -389,6 +389,11 @@ static int blkdev_roset(struct block_device *bdev, fmode_t mode, return ret; if (get_user(n, (int __user *)arg)) return -EFAULT; + if (bdev->bd_disk->fops->set_read_only) { + ret = bdev->bd_disk->fops->set_read_only(bdev, n); + if (ret) + return ret; + } set_device_ro(bdev, n); return 0; } diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 639cae2c158b59..5c1ba8a8d2bc7e 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -1850,6 +1850,7 @@ struct block_device_operations { void (*unlock_native_capacity) (struct gendisk *); int (*revalidate_disk) (struct gendisk *); int (*getgeo)(struct block_device *, struct hd_geometry *); + int (*set_read_only)(struct block_device *bdev, bool ro); /* this callback is with swap_lock and sometimes page table lock held */ void (*swap_slot_free_notify) (struct block_device *, unsigned long); int (*report_zones)(struct gendisk *, sector_t sector, -- 2.29.2
next prev parent reply index Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-16 14:56 cleanup updating the size of block devices v3 Christoph Hellwig 2020-11-16 14:56 ` [PATCH 01/78] block: remove the call to __invalidate_device in check_disk_size_change Christoph Hellwig 2020-11-16 14:56 ` [PATCH 02/78] loop: let set_capacity_revalidate_and_notify update the bdev size Christoph Hellwig 2020-11-16 14:56 ` [PATCH 03/78] nvme: " Christoph Hellwig 2020-11-16 14:56 ` [PATCH 04/78] sd: update the bdev size in sd_revalidate_disk Christoph Hellwig 2020-11-16 14:56 ` [PATCH 05/78] block: remove the update_bdev parameter to set_capacity_revalidate_and_notify Christoph Hellwig 2020-11-16 14:56 ` [PATCH 06/78] nbd: remove the call to set_blocksize Christoph Hellwig 2020-11-16 14:56 ` [PATCH 07/78] nbd: move the task_recv check into nbd_size_update Christoph Hellwig 2020-11-16 14:56 ` [PATCH 08/78] nbd: refactor size updates Christoph Hellwig 2020-11-16 14:57 ` [PATCH 09/78] nbd: validate the block size in nbd_set_size Christoph Hellwig 2020-11-16 14:57 ` [PATCH 10/78] nbd: use set_capacity_and_notify Christoph Hellwig 2020-11-16 14:57 ` [PATCH 11/78] aoe: don't call set_capacity from irq context Christoph Hellwig 2020-11-16 14:57 ` [PATCH 12/78] dm: use set_capacity_and_notify Christoph Hellwig 2021-02-12 15:45 ` Mike Snitzer 2021-02-16 11:46 ` Christoph Hellwig 2020-11-16 14:57 ` [PATCH 13/78] pktcdvd: " Christoph Hellwig 2020-11-16 14:57 ` [PATCH 14/78] nvme: use set_capacity_and_notify in nvme_set_queue_dying Christoph Hellwig 2020-11-16 14:57 ` [PATCH 15/78] drbd: use set_capacity_and_notify Christoph Hellwig 2020-11-16 14:57 ` [PATCH 16/78] rbd: " Christoph Hellwig 2020-11-16 14:57 ` [PATCH 17/78] rnbd: " Christoph Hellwig 2020-11-16 14:57 ` [PATCH 18/78] zram: " Christoph Hellwig 2020-11-16 14:57 ` [PATCH 19/78] dm-raid: " Christoph Hellwig 2020-11-16 14:57 ` [PATCH 20/78] md: " Christoph Hellwig 2020-11-16 14:57 ` [PATCH 21/78] md: remove a spurious call to revalidate_disk_size in update_size Christoph Hellwig 2020-11-16 14:57 ` [PATCH 22/78] virtio-blk: remove a spurious call to revalidate_disk_size Christoph Hellwig 2020-11-16 14:57 ` [PATCH 23/78] block: unexport revalidate_disk_size Christoph Hellwig 2020-11-16 14:57 ` [PATCH 24/78] mtd_blkdevs: don't override BLKFLSBUF Christoph Hellwig 2020-11-16 14:57 ` [PATCH 25/78] block: don't call into the driver for BLKFLSBUF Christoph Hellwig 2020-11-16 14:57 ` Christoph Hellwig [this message] 2020-11-16 14:57 ` [PATCH 27/78] rbd: implement ->set_read_only to hook into BLKROSET processing Christoph Hellwig 2020-11-16 14:57 ` [PATCH 28/78] md: " Christoph Hellwig 2020-11-16 17:37 ` Song Liu 2020-11-16 14:57 ` [PATCH 29/78] dasd: " Christoph Hellwig 2020-11-16 14:57 ` [PATCH 30/78] block: don't call into the driver for BLKROSET Christoph Hellwig 2020-11-20 7:19 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 31/78] loop: use set_disk_ro Christoph Hellwig 2020-11-20 7:20 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 32/78] block: remove set_device_ro Christoph Hellwig 2020-11-20 7:20 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 33/78] block: remove __blkdev_driver_ioctl Christoph Hellwig 2020-11-20 7:22 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 34/78] block: propagate BLKROSET to all partitions Christoph Hellwig 2020-11-20 7:23 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 35/78] block: cleanup del_gendisk a bit Christoph Hellwig 2020-11-16 14:57 ` [PATCH 36/78] block: open code kobj_map into in block/genhd.c Christoph Hellwig 2020-11-16 14:57 ` [PATCH 37/78] block: split block_class_lock Christoph Hellwig 2020-11-16 14:57 ` [PATCH 38/78] block: rework requesting modules for unclaimed devices Christoph Hellwig 2020-11-16 14:57 ` [PATCH 39/78] block: add an optional probe callback to major_names Christoph Hellwig 2020-11-16 14:57 ` [PATCH 40/78] ide: remove ide_{,un}register_region Christoph Hellwig 2020-11-16 14:57 ` [PATCH 41/78] swim: don't call blk_register_region Christoph Hellwig 2020-11-16 14:57 ` [PATCH 42/78] sd: use __register_blkdev to avoid a modprobe for an unregistered dev_t Christoph Hellwig 2020-11-16 14:57 ` [PATCH 43/78] brd: use __register_blkdev to allocate devices on demand Christoph Hellwig 2020-11-16 14:57 ` [PATCH 44/78] loop: " Christoph Hellwig 2020-11-16 14:57 ` [PATCH 45/78] md: " Christoph Hellwig 2020-11-16 14:57 ` [PATCH 46/78] ide: switch to __register_blkdev for command set probing Christoph Hellwig 2020-11-16 14:57 ` [PATCH 47/78] floppy: use a separate gendisk for each media format Christoph Hellwig 2020-11-16 14:57 ` [PATCH 48/78] amiflop: use separate gendisks for Amiga vs MS-DOS mode Christoph Hellwig 2020-11-16 14:57 ` [PATCH 49/78] ataflop: use a separate gendisk for each media format Christoph Hellwig 2020-11-16 14:57 ` [PATCH 50/78] z2ram: reindent Christoph Hellwig 2020-11-16 14:57 ` [PATCH 51/78] z2ram: use separate gendisk for the different modes Christoph Hellwig 2020-11-16 14:57 ` [PATCH 52/78] block: switch gendisk lookup to a simple xarray Christoph Hellwig 2020-11-16 14:57 ` [PATCH 53/78] blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats Christoph Hellwig 2020-11-20 7:25 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 54/78] block: remove a duplicate __disk_get_part prototype Christoph Hellwig 2020-11-20 7:25 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 55/78] block: change the hash used for looking up block devices Christoph Hellwig 2020-11-20 7:26 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 56/78] init: refactor name_to_dev_t Christoph Hellwig 2020-11-20 7:31 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 57/78] init: refactor devt_from_partuuid Christoph Hellwig 2020-11-20 7:33 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 58/78] init: cleanup match_dev_by_uuid and match_dev_by_label Christoph Hellwig 2020-11-20 7:34 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 59/78] mtip32xx: remove the call to fsync_bdev on removal Christoph Hellwig 2020-11-20 7:35 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 60/78] zram: remove the claim mechanism Christoph Hellwig 2020-11-20 7:37 ` Hannes Reinecke 2020-11-26 1:11 ` Minchan Kim 2020-11-26 9:59 ` Christoph Hellwig 2020-11-16 14:57 ` [PATCH 61/78] zram: do not call set_blocksize Christoph Hellwig 2020-11-20 7:38 ` Hannes Reinecke 2020-11-26 1:16 ` Minchan Kim 2020-11-16 14:57 ` [PATCH 62/78] loop: " Christoph Hellwig 2020-11-20 7:38 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 63/78] bcache: remove a superflous lookup_bdev all Christoph Hellwig 2020-11-16 14:57 ` [PATCH 64/78] dm: simplify flush_bio initialization in __send_empty_flush Christoph Hellwig 2020-11-20 7:41 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 65/78] dm: remove the block_device reference in struct mapped_device Christoph Hellwig 2020-11-20 7:43 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 66/78] block: keep a block_device reference for each hd_struct Christoph Hellwig 2020-11-20 7:50 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 67/78] block: simplify the block device claiming interface Christoph Hellwig 2020-11-20 7:51 ` Hannes Reinecke 2020-11-16 14:57 ` [PATCH 68/78] block: remove ->bd_contains Christoph Hellwig 2020-11-20 7:52 ` Hannes Reinecke 2020-11-16 14:58 ` [PATCH 69/78] block: remove the nr_sects field in struct hd_struct Christoph Hellwig 2020-11-20 7:55 ` Hannes Reinecke 2020-11-16 14:58 ` [PATCH 70/78] block: replace bd_mutex with a per-gendisk mutex Christoph Hellwig 2020-11-20 7:58 ` Hannes Reinecke 2020-11-16 14:58 ` [PATCH 71/78] block: add a bdev_kobj helper Christoph Hellwig 2020-11-20 7:59 ` Hannes Reinecke 2020-11-16 14:58 ` [PATCH 72/78] block: use disk_part_iter_exit in disk_part_iter_next Christoph Hellwig 2020-11-20 7:59 ` Hannes Reinecke 2020-11-16 14:58 ` [PATCH 73/78] block: use put_device in put_disk Christoph Hellwig 2020-11-20 8:02 ` Hannes Reinecke 2020-11-16 14:58 ` [PATCH 74/78] block: merge struct block_device and struct hd_struct Christoph Hellwig 2020-11-20 8:58 ` Hannes Reinecke 2020-11-16 14:58 ` [PATCH 75/78] block: stop using bdget_disk for partition 0 Christoph Hellwig 2020-11-16 14:58 ` [PATCH 76/78] filemap: use ->f_mapping over ->i_mapping consistently Christoph Hellwig 2020-11-16 14:58 ` [PATCH 77/78] fs: simplify the get_super_thawed interface Christoph Hellwig 2020-11-16 14:58 ` [PATCH 78/78] block: remove i_bdev Christoph Hellwig 2020-11-16 15:05 ` cleanup updating the size of block devices v3 Christoph Hellwig 2020-11-16 15:40 ` Jens Axboe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201116145809.410558-27-hch@lst.de \ --to=hch@lst.de \ --cc=axboe@kernel.dk \ --cc=ceph-devel@vger.kernel.org \ --cc=dm-devel@redhat.com \ --cc=drbd-dev@lists.linbit.com \ --cc=idryomov@gmail.com \ --cc=jasowang@redhat.com \ --cc=jinpu.wang@cloud.ionos.com \ --cc=josef@toxicpanda.com \ --cc=justin@coraid.com \ --cc=konrad.wilk@oracle.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-raid@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=minchan@kernel.org \ --cc=mst@redhat.com \ --cc=nbd@other.debian.org \ --cc=pbonzini@redhat.com \ --cc=roger.pau@citrix.com \ --cc=snitzer@redhat.com \ --cc=song@kernel.org \ --cc=stefanha@redhat.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
CEPH-Devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/ceph-devel/0 ceph-devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ceph-devel ceph-devel/ https://lore.kernel.org/ceph-devel \ ceph-devel@vger.kernel.org public-inbox-index ceph-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.ceph-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git