ceph-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [ceph-client:wip-netfs-lib 5/7] fs/ceph/addr.c:257 ceph_netfs_issue_op() warn: unsigned 'len' is never less than zero.
@ 2021-01-25 23:50 kernel test robot
  0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2021-01-25 23:50 UTC (permalink / raw)
  To: Jeff Layton; +Cc: kbuild-all, ceph-devel

[-- Attachment #1: Type: text/plain, Size: 3045 bytes --]

tree:   https://github.com/ceph/ceph-client.git wip-netfs-lib
head:   a72056dc6ccfb6c11070373aaa72e4e3b09decc5
commit: 15f4b2f986a135d8038928d3a2ca63d112987843 [5/7] ceph: convert readpage to fscache read helper
config: x86_64-randconfig-m001-20210125 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-20) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

New smatch warnings:
fs/ceph/addr.c:257 ceph_netfs_issue_op() warn: unsigned 'len' is never less than zero.

Old smatch warnings:
fs/ceph/addr.c:501 start_read() warn: should 'nr_pages << 12' be a 64 bit type?
fs/ceph/addr.c:536 start_read() warn: should 'nr_pages << 12' be a 64 bit type?
fs/ceph/addr.c:2140 __ceph_pool_perm_get() error: we previously assumed 'pool_ns' could be null (see line 2129)
include/linux/ceph/string_table.h:46 ceph_compare_string() error: we previously assumed 'cs' could be null (see line 41)

vim +/len +257 fs/ceph/addr.c

   230	
   231	static void ceph_netfs_issue_op(struct netfs_read_subrequest *subreq)
   232	{
   233		struct netfs_read_request *rreq = subreq->rreq;
   234		struct inode *inode = rreq->mapping->host;
   235		struct ceph_inode_info *ci = ceph_inode(inode);
   236		struct ceph_fs_client *fsc = ceph_inode_to_client(inode);
   237		struct ceph_osd_request *req = NULL;
   238		struct ceph_vino vino = ceph_vino(inode);
   239		struct iov_iter iter;
   240		struct page **pages;
   241		size_t page_off;
   242		int err = 0;
   243		u64 len = subreq->len;
   244	
   245		req = ceph_osdc_new_request(&fsc->client->osdc, &ci->i_layout, vino, subreq->start, &len,
   246				0, 1, CEPH_OSD_OP_READ,
   247				CEPH_OSD_FLAG_READ | fsc->client->osdc.client->options->read_from_replica,
   248				NULL, ci->i_truncate_seq, ci->i_truncate_size, false);
   249		if (IS_ERR(req)) {
   250			err = PTR_ERR(req);
   251			goto out;
   252		}
   253	
   254		dout("%s: pos=%llu orig_len=%zu len=%llu\n", __func__, subreq->start, subreq->len, len);
   255		iov_iter_xarray(&iter, READ, &rreq->mapping->i_pages, subreq->start, len);
   256		len = iov_iter_get_pages_alloc(&iter, &pages, len, &page_off);
 > 257		if (len < 0) {
   258			err = len;
   259			dout("%s: iov_ter_get_pages_alloc returned %d\n", __func__, err);
   260			goto out;
   261		}
   262	
   263		/* should always give us a page-aligned read */
   264		WARN_ON_ONCE(page_off);
   265	
   266		osd_req_op_extent_osd_data_pages(req, 0, pages, len, 0, false, false);
   267		req->r_callback = finish_netfs_read;
   268		req->r_priv = subreq;
   269		req->r_inode = inode;
   270		ihold(inode);
   271	
   272		err = ceph_osdc_start_request(req->r_osdc, req, false);
   273		if (err)
   274			iput(inode);
   275	out:
   276		if (req)
   277			ceph_osdc_put_request(req);
   278		if (err)
   279			netfs_subreq_terminated(subreq, err);
   280		dout("%s: result %d\n", __func__, err);
   281	}
   282	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 41524 bytes --]

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-01-25 23:53 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-25 23:50 [ceph-client:wip-netfs-lib 5/7] fs/ceph/addr.c:257 ceph_netfs_issue_op() warn: unsigned 'len' is never less than zero kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).