From: Matthew Wilcox <willy@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: David Howells <dhowells@redhat.com>,
Amir Goldstein <amir73il@gmail.com>,
linux-cachefs@redhat.com, Jeff Layton <jlayton@redhat.com>,
David Wysochanski <dwysocha@redhat.com>,
"J. Bruce Fields" <bfields@fieldses.org>,
Christoph Hellwig <hch@infradead.org>,
Dave Chinner <dchinner@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-afs@lists.infradead.org,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
CIFS <linux-cifs@vger.kernel.org>,
ceph-devel <ceph-devel@vger.kernel.org>,
v9fs-developer@lists.sourceforge.net,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: Metadata writtenback notification? -- was Re: fscache: Redesigning the on-disk cache
Date: Mon, 8 Mar 2021 23:20:18 +0000 [thread overview]
Message-ID: <20210308232018.GG3479805@casper.infradead.org> (raw)
In-Reply-To: <20210308223247.GB63242@dread.disaster.area>
On Tue, Mar 09, 2021 at 09:32:47AM +1100, Dave Chinner wrote:
> On Mon, Mar 08, 2021 at 11:28:41AM +0000, David Howells wrote:
> > Possibly it's sufficient to just clear the excess page space before
> > writing, but that doesn't necessarily stop a writable mmap from
> > scribbling on it.
>
> We can't stop mmap from scribbling in it. All filesystems have this
> problem, so to prevent data leaks we have to zero the post-eof tail
> region on every write of the EOF block, anyway.
That's certainly one approach. Another would be to zero it during the I/O
completion handler. It depends whether you can trust the last writer or
not (eg what do we do with an isofs file that happens to contain garbage
after the last byte in the file?)
next prev parent reply other threads:[~2021-03-08 23:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 23:20 fscache: Redesigning the on-disk cache David Howells
2021-03-04 13:47 ` fscache: Redesigning the on-disk cache - LRU handling David Howells
2021-03-05 9:46 ` fscache: Redesigning the on-disk cache Amir Goldstein
2021-03-08 9:13 ` David Howells
2021-03-08 10:35 ` Amir Goldstein
2021-03-08 11:28 ` Metadata writtenback notification? -- was " David Howells
2021-03-08 22:32 ` Dave Chinner
2021-03-08 23:20 ` Matthew Wilcox [this message]
2021-03-09 11:27 ` David Howells
2021-03-08 18:54 ` J. Bruce Fields
2021-03-08 19:08 ` David Howells
2021-03-08 21:55 ` Dave Chinner
2021-03-09 9:21 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210308232018.GG3479805@casper.infradead.org \
--to=willy@infradead.org \
--cc=amir73il@gmail.com \
--cc=bfields@fieldses.org \
--cc=ceph-devel@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=dchinner@redhat.com \
--cc=dhowells@redhat.com \
--cc=dwysocha@redhat.com \
--cc=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).