From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33751C43216 for ; Wed, 4 Aug 2021 14:33:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 204AD60FC3 for ; Wed, 4 Aug 2021 14:33:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238838AbhHDOdw (ORCPT ); Wed, 4 Aug 2021 10:33:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:38844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238703AbhHDOd3 (ORCPT ); Wed, 4 Aug 2021 10:33:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id AA66960F58; Wed, 4 Aug 2021 14:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628087596; bh=C00JtgOcAHMho4HSW46amt4u1PEDLgE0FCLDRj9vJyE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=r5GGuOVFvQsum4XAR7C7YBvKDsK/mFn7OHK1uuaLXRstSUvJF6WN5SAcMH42cka84 XNI6JmV4ddzVk3D3J2YlbCsl6RVftxgl1k5Vs3nz5huKGNFgnQBY2iei65nSAundBj gr1MQgM6nEcpjWrclG+PO2XuVtuhgDLnuVCxLN/ur1yVfnHV1jME0OH5CUcgso0JH9 OkCnqulR6QQPlr+/+sWhnm9w3GZI3LrX0Du7/iC3FQiuwUJ/6hK/4Zm/l13ruiwaM0 PswWW1T0VxSiyJLTXtgN/AKJ1p4nBl2lAi+w/iFwSNC7dXt6aRCMFqvyz/tryXYCNL 6UR6ytS23PJoQ== Date: Wed, 4 Aug 2021 07:33:12 -0700 From: Keith Busch To: Christoph Hellwig Cc: Jens Axboe , Richard Weinberger , Anton Ivanov , Geoff Levand , Ilya Dryomov , Paolo Bonzini , Stefan Hajnoczi , Song Liu , Mike Snitzer , Coly Li , Stefan Haberland , Jan Hoeppner , "Martin K. Petersen" , Phillip Lougher , linux-block@vger.kernel.org, dm-devel@redhat.com, linux-um@lists.infradead.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, linux-nvme@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 15/15] nvme: use bvec_virt Message-ID: <20210804143312.GA2296276@dhcp-10-100-145-180.wdc.com> References: <20210804095634.460779-1-hch@lst.de> <20210804095634.460779-16-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210804095634.460779-16-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On Wed, Aug 04, 2021 at 11:56:34AM +0200, Christoph Hellwig wrote: > Use bvec_virt instead of open coding it. > > Signed-off-by: Christoph Hellwig > --- > drivers/nvme/host/core.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c > index dfd9dec0c1f6..02ce94b2906b 100644 > --- a/drivers/nvme/host/core.c > +++ b/drivers/nvme/host/core.c > @@ -968,12 +968,11 @@ void nvme_cleanup_cmd(struct request *req) > { > if (req->rq_flags & RQF_SPECIAL_PAYLOAD) { > struct nvme_ctrl *ctrl = nvme_req(req)->ctrl; > - struct page *page = req->special_vec.bv_page; > > - if (page == ctrl->discard_page) > + if (req->special_vec.bv_page == ctrl->discard_page) > clear_bit_unlock(0, &ctrl->discard_page_busy); > else > - kfree(page_address(page) + req->special_vec.bv_offset); > + kfree(bvec_virt(&req->special_vec)); > } > } > EXPORT_SYMBOL_GPL(nvme_cleanup_cmd); Looks good. Reviewed-by: Keith Busch