From: Venky Shankar <vshankar@redhat.com>
To: jlayton@redhat.com, pdonnell@redhat.com, xiubli@redhat.com
Cc: ceph-devel@vger.kernel.org, Venky Shankar <vshankar@redhat.com>
Subject: [PATCH v2 4/4] ceph: use tracked average r/w/m latencies to display metrics in debugfs
Date: Tue, 14 Sep 2021 14:19:02 +0530 [thread overview]
Message-ID: <20210914084902.1618064-5-vshankar@redhat.com> (raw)
In-Reply-To: <20210914084902.1618064-1-vshankar@redhat.com>
Signed-off-by: Venky Shankar <vshankar@redhat.com>
---
fs/ceph/debugfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
index 3abfa7ae8220..970aa04fb04d 100644
--- a/fs/ceph/debugfs.c
+++ b/fs/ceph/debugfs.c
@@ -172,7 +172,7 @@ static int metric_show(struct seq_file *s, void *p)
spin_lock(&m->read_metric_lock);
total = m->total_reads;
sum = m->read_latency_sum;
- avg = total > 0 ? DIV64_U64_ROUND_CLOSEST(sum, total) : 0;
+ avg = m->avg_read_latency;
min = m->read_latency_min;
max = m->read_latency_max;
stdev = m->read_latency_stdev;
@@ -182,7 +182,7 @@ static int metric_show(struct seq_file *s, void *p)
spin_lock(&m->write_metric_lock);
total = m->total_writes;
sum = m->write_latency_sum;
- avg = total > 0 ? DIV64_U64_ROUND_CLOSEST(sum, total) : 0;
+ avg = m->avg_write_latency;
min = m->write_latency_min;
max = m->write_latency_max;
stdev = m->write_latency_stdev;
@@ -192,7 +192,7 @@ static int metric_show(struct seq_file *s, void *p)
spin_lock(&m->metadata_metric_lock);
total = m->total_metadatas;
sum = m->metadata_latency_sum;
- avg = total > 0 ? DIV64_U64_ROUND_CLOSEST(sum, total) : 0;
+ avg = m->avg_metadata_latency;
min = m->metadata_latency_min;
max = m->metadata_latency_max;
stdev = m->metadata_latency_stdev;
--
2.31.1
next prev parent reply other threads:[~2021-09-14 8:49 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 8:48 [PATCH v2 0/4] ceph: forward average read/write/metadata latency Venky Shankar
2021-09-14 8:48 ` [PATCH v2 1/4] ceph: use "struct ceph_timespec" for r/w/m latencies Venky Shankar
2021-09-14 8:49 ` [PATCH v2 2/4] ceph: track average/stdev r/w/m latency Venky Shankar
2021-09-14 12:52 ` Xiubo Li
2021-09-14 13:03 ` Venky Shankar
2021-09-14 13:09 ` Xiubo Li
2021-09-14 13:30 ` Venky Shankar
2021-09-14 13:45 ` Xiubo Li
2021-09-14 13:52 ` Xiubo Li
2021-09-14 14:00 ` Venky Shankar
2021-09-14 14:10 ` Xiubo Li
2021-09-14 13:53 ` Venky Shankar
2021-09-14 13:58 ` Xiubo Li
2021-09-14 13:13 ` Xiubo Li
2021-09-14 13:32 ` Jeff Layton
2021-09-14 13:32 ` Venky Shankar
2021-09-14 8:49 ` [PATCH v2 3/4] ceph: include average/stddev r/w/m latency in mds metrics Venky Shankar
2021-09-14 13:57 ` Xiubo Li
2021-09-14 8:49 ` Venky Shankar [this message]
2022-03-08 12:42 [PATCH v2 0/4] ceph: forward average read/write/metadata latency Venky Shankar
2022-03-08 12:42 ` [PATCH v2 4/4] ceph: use tracked average r/w/m latencies to display metrics in debugfs Venky Shankar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210914084902.1618064-5-vshankar@redhat.com \
--to=vshankar@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=jlayton@redhat.com \
--cc=pdonnell@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).