From: Jeff Layton <jlayton@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: dhowells@redhat.com, idryomov@gmail.com, xiubli@redhat.com,
ceph-devel@vger.kernel.org, linux-cachefs@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 2/6] ceph: rework PageFsCache handling
Date: Wed, 17 Feb 2021 09:59:39 -0500 [thread overview]
Message-ID: <67964c5a81822bf8d6562fbaaef0d43ef2f9f9bd.camel@kernel.org> (raw)
In-Reply-To: <20210217143857.GK2858050@casper.infradead.org>
On Wed, 2021-02-17 at 14:38 +0000, Matthew Wilcox wrote:
> On Wed, Feb 17, 2021 at 07:58:41AM -0500, Jeff Layton wrote:
> > -static int ceph_releasepage(struct page *page, gfp_t g)
> > +static int ceph_releasepage(struct page *page, gfp_t gfp_flags)
> > {
> > dout("%p releasepage %p idx %lu (%sdirty)\n", page->mapping->host,
> > page, page->index, PageDirty(page) ? "" : "not ");
> >
> >
> > + if (PageFsCache(page)) {
> > + if (!(gfp_flags & __GFP_DIRECT_RECLAIM) || !(gfp_flags & __GFP_FS))
>
> If you called it 'gfp' instead of 'gfp_flags', you wouldn't go over 80
> columns ;-)
>
> if (!(gfp & __GFP_DIRECT_RECLAIM) || !(gfp & __GFP_FS))
>
Fair enough -- I'll fix it up since you mentioned it. ;)
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2021-02-17 15:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210217125845.10319-1-jlayton@kernel.org>
2021-02-17 12:58 ` [PATCH v2 1/6] ceph: disable old fscache readpage handling Jeff Layton
2021-02-19 5:09 ` Xiubo Li
2021-02-22 14:47 ` Jeff Layton
2021-02-17 12:58 ` [PATCH v2 2/6] ceph: rework PageFsCache handling Jeff Layton
2021-02-17 14:38 ` Matthew Wilcox
2021-02-17 14:59 ` Jeff Layton [this message]
2021-02-17 12:58 ` [PATCH v2 3/6] ceph: fix fscache invalidation Jeff Layton
2021-02-17 12:58 ` [PATCH v2 4/6] ceph: convert readpage to fscache read helper Jeff Layton
2021-02-17 12:58 ` [PATCH v2 5/6] ceph: plug write_begin into " Jeff Layton
2021-02-17 12:58 ` [PATCH v2 6/6] ceph: convert ceph_readpages to ceph_readahead Jeff Layton
2021-02-17 15:15 ` Matthew Wilcox
2021-02-17 15:46 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67964c5a81822bf8d6562fbaaef0d43ef2f9f9bd.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=idryomov@gmail.com \
--cc=linux-cachefs@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).