From: Jeff Layton <jlayton@kernel.org>
To: xiubli@redhat.com
Cc: idryomov@gmail.com, pdonnell@redhat.com, ceph-devel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] ceph: add IO size metric support
Date: Wed, 28 Apr 2021 10:14:21 -0400 [thread overview]
Message-ID: <6de87237eca5e9ebd7714755ddd11adb4bc5c5ed.camel@kernel.org> (raw)
In-Reply-To: <20210428060840.4447-1-xiubli@redhat.com>
On Wed, 2021-04-28 at 14:08 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
>
> V3:
> - update and rename __update_latency to __update_stdev.
>
> V2:
> - remove the unused parameters in metric.c
> - a small clean up for the code.
>
> For the read/write IO speeds, will leave them to be computed in
> userspace,
> where it can get a preciser result with float type.
>
>
> Xiubo Li (2):
> ceph: update and rename __update_latency helper to __update_stdev
> ceph: add IO size metrics support
>
> fs/ceph/addr.c | 14 +++++----
> fs/ceph/debugfs.c | 37 +++++++++++++++++++++---
> fs/ceph/file.c | 23 +++++++--------
> fs/ceph/metric.c | 74 ++++++++++++++++++++++++++++++++---------------
> fs/ceph/metric.h | 10 +++++--
> 5 files changed, 111 insertions(+), 47 deletions(-)
>
Thanks Xiubo,
This looks good. Merged into ceph-client/testing.
My only (minor) complaint is that the output of
/sys/kernel/debug/ceph/*/metrics is a bit ad-hoc and messy, especially
when there are multiple mounts. It might be good to clean that up in a
later patch, but I don't see it as a reason to block merging this.
Cheers,
--
Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2021-04-28 14:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 6:08 [PATCH v3 0/2] ceph: add IO size metric support xiubli
2021-04-28 6:08 ` [PATCH v3 1/2] ceph: update and rename __update_latency helper to __update_stdev xiubli
2021-04-28 6:08 ` [PATCH v3 2/2] ceph: add IO size metrics support xiubli
2021-04-28 14:14 ` Jeff Layton [this message]
2021-04-29 0:57 ` [PATCH v3 0/2] ceph: add IO size metric support Xiubo Li
2021-04-29 2:14 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de87237eca5e9ebd7714755ddd11adb4bc5c5ed.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=pdonnell@redhat.com \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).