ceph-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: ceph-devel@vger.kernel.org
Cc: idryomov@gmail.com, Matthew Wilcox <willy@infradead.org>
Subject: Re: [PATCH] cifs: switch to noop_direct_IO
Date: Thu, 23 Sep 2021 09:01:30 -0400	[thread overview]
Message-ID: <77fa22143b63d19a462c25a47d9ae5ae8ec753b8.camel@kernel.org> (raw)
In-Reply-To: <20210923115900.16587-1-jlayton@kernel.org>

On Thu, 2021-09-23 at 07:59 -0400, Jeff Layton wrote:
> The cifs one is identical to the noop one. Just use it instead.
> 
> Cc: Matthew Wilcox <willy@infradead.org>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>  fs/cifs/file.c | 21 +--------------------
>  1 file changed, 1 insertion(+), 20 deletions(-)
> 
> diff --git a/fs/cifs/file.c b/fs/cifs/file.c
> index d0216472f1c6..2406b9ddd623 100644
> --- a/fs/cifs/file.c
> +++ b/fs/cifs/file.c
> @@ -4890,25 +4890,6 @@ void cifs_oplock_break(struct work_struct *work)
>  	cifs_done_oplock_break(cinode);
>  }
>  
> -/*
> - * The presence of cifs_direct_io() in the address space ops vector
> - * allowes open() O_DIRECT flags which would have failed otherwise.
> - *
> - * In the non-cached mode (mount with cache=none), we shunt off direct read and write requests
> - * so this method should never be called.
> - *
> - * Direct IO is not yet supported in the cached mode. 
> - */
> -static ssize_t
> -cifs_direct_io(struct kiocb *iocb, struct iov_iter *iter)
> -{
> -        /*
> -         * FIXME
> -         * Eventually need to support direct IO for non forcedirectio mounts
> -         */
> -        return -EINVAL;
> -}
> -
>  static int cifs_swap_activate(struct swap_info_struct *sis,
>  			      struct file *swap_file, sector_t *span)
>  {
> @@ -4973,7 +4954,7 @@ const struct address_space_operations cifs_addr_ops = {
>  	.write_end = cifs_write_end,
>  	.set_page_dirty = __set_page_dirty_nobuffers,
>  	.releasepage = cifs_release_page,
> -	.direct_IO = cifs_direct_io,
> +	.direct_IO = noop_direct_io,
>  	.invalidatepage = cifs_invalidate_page,
>  	.launder_page = cifs_launder_page,
>  	/*

Disregard this patch. Sent to the wrong recipients and it has a bug to
boot.
-- 
Jeff Layton <jlayton@kernel.org>


      reply	other threads:[~2021-09-23 13:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 11:59 Jeff Layton
2021-09-23 13:01 ` Jeff Layton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=77fa22143b63d19a462c25a47d9ae5ae8ec753b8.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=willy@infradead.org \
    --subject='Re: [PATCH] cifs: switch to noop_direct_IO' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).