ceph-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ceph: fix a typo in comments
@ 2021-03-29  4:59 xiubli
  2021-04-05 11:30 ` Jeff Layton
  0 siblings, 1 reply; 3+ messages in thread
From: xiubli @ 2021-03-29  4:59 UTC (permalink / raw)
  To: jlayton; +Cc: idryomov, pdonnell, ceph-devel, Xiubo Li

From: Xiubo Li <xiubli@redhat.com>

Signed-off-by: Xiubo Li <xiubli@redhat.com>
---
 fs/ceph/addr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index 57c67180ce5c..5b66f17afe0c 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -1945,7 +1945,7 @@ int ceph_pool_perm_check(struct inode *inode, int need)
 	if (ci->i_vino.snap != CEPH_NOSNAP) {
 		/*
 		 * Pool permission check needs to write to the first object.
-		 * But for snapshot, head of the first object may have alread
+		 * But for snapshot, head of the first object may have already
 		 * been deleted. Skip check to avoid creating orphan object.
 		 */
 		return 0;
-- 
2.27.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ceph: fix a typo in comments
  2021-03-29  4:59 [PATCH] ceph: fix a typo in comments xiubli
@ 2021-04-05 11:30 ` Jeff Layton
  2021-04-06  0:43   ` Xiubo Li
  0 siblings, 1 reply; 3+ messages in thread
From: Jeff Layton @ 2021-04-05 11:30 UTC (permalink / raw)
  To: xiubli; +Cc: idryomov, pdonnell, ceph-devel

On Mon, 2021-03-29 at 12:59 +0800, xiubli@redhat.com wrote:
> From: Xiubo Li <xiubli@redhat.com>
> 
> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> ---
>  fs/ceph/addr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 57c67180ce5c..5b66f17afe0c 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -1945,7 +1945,7 @@ int ceph_pool_perm_check(struct inode *inode, int need)
>  	if (ci->i_vino.snap != CEPH_NOSNAP) {
>  		/*
>  		 * Pool permission check needs to write to the first object.
> -		 * But for snapshot, head of the first object may have alread
> +		 * But for snapshot, head of the first object may have already
>  		 * been deleted. Skip check to avoid creating orphan object.
>  		 */
>  		return 0;

In general, I don't like to merge patches that just change comments
without other substantive changes. I did make an exception in this
patch:

    [PATCH 1/2] ceph: fix kerneldoc copypasta over ceph_start_io_direct

...but that was mainly because that was generating a warning at build-
time for me. I'm going to drop this patch for now.

Cheers,
-- 
Jeff Layton <jlayton@kernel.org>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ceph: fix a typo in comments
  2021-04-05 11:30 ` Jeff Layton
@ 2021-04-06  0:43   ` Xiubo Li
  0 siblings, 0 replies; 3+ messages in thread
From: Xiubo Li @ 2021-04-06  0:43 UTC (permalink / raw)
  To: Jeff Layton; +Cc: idryomov, pdonnell, ceph-devel

On 2021/4/5 19:30, Jeff Layton wrote:
> On Mon, 2021-03-29 at 12:59 +0800, xiubli@redhat.com wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>> ---
>>   fs/ceph/addr.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
>> index 57c67180ce5c..5b66f17afe0c 100644
>> --- a/fs/ceph/addr.c
>> +++ b/fs/ceph/addr.c
>> @@ -1945,7 +1945,7 @@ int ceph_pool_perm_check(struct inode *inode, int need)
>>   	if (ci->i_vino.snap != CEPH_NOSNAP) {
>>   		/*
>>   		 * Pool permission check needs to write to the first object.
>> -		 * But for snapshot, head of the first object may have alread
>> +		 * But for snapshot, head of the first object may have already
>>   		 * been deleted. Skip check to avoid creating orphan object.
>>   		 */
>>   		return 0;
> In general, I don't like to merge patches that just change comments
> without other substantive changes. I did make an exception in this
> patch:
>
>      [PATCH 1/2] ceph: fix kerneldoc copypasta over ceph_start_io_direct
>
> ...but that was mainly because that was generating a warning at build-
> time for me. I'm going to drop this patch for now.

Sure, will fix it in my next patch series.

Thanks

> Cheers,



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-06  0:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-29  4:59 [PATCH] ceph: fix a typo in comments xiubli
2021-04-05 11:30 ` Jeff Layton
2021-04-06  0:43   ` Xiubo Li

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).