From: Xiubo Li <xiubli@redhat.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: idryomov@gmail.com, pdonnell@redhat.com, ceph-devel@vger.kernel.org
Subject: Re: [PATCH 1/5] ceph: export ceph_create_session_msg
Date: Tue, 29 Jun 2021 21:27:10 +0800 [thread overview]
Message-ID: <8cc0a19a-2c67-f807-5085-46455727e8ab@redhat.com> (raw)
In-Reply-To: <88c1bdbf8235b35671a84f0b0d5feca855017940.camel@kernel.org>
On 6/29/21 9:12 PM, Jeff Layton wrote:
> On Tue, 2021-06-29 at 12:42 +0800, xiubli@redhat.com wrote:
>> From: Xiubo Li <xiubli@redhat.com>
>>
> nit: the subject of this patch is not quite right. You aren't exporting
> it here, just making it a global symbol (within ceph.ko).
>
Yeah, will fix it.
>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>> ---
>> fs/ceph/mds_client.c | 15 ++++++++-------
>> fs/ceph/mds_client.h | 1 +
>> 2 files changed, 9 insertions(+), 7 deletions(-)
>>
>> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
>> index 2d7dcd295bb9..e49d3e230712 100644
>> --- a/fs/ceph/mds_client.c
>> +++ b/fs/ceph/mds_client.c
>> @@ -1150,7 +1150,7 @@ static int __choose_mds(struct ceph_mds_client *mdsc,
>> /*
>> * session messages
>> */
>> -static struct ceph_msg *create_session_msg(u32 op, u64 seq)
>> +struct ceph_msg *ceph_create_session_msg(u32 op, u64 seq)
>> {
>> struct ceph_msg *msg;
>> struct ceph_mds_session_head *h;
>> @@ -1158,7 +1158,7 @@ static struct ceph_msg *create_session_msg(u32 op, u64 seq)
>> msg = ceph_msg_new(CEPH_MSG_CLIENT_SESSION, sizeof(*h), GFP_NOFS,
>> false);
>> if (!msg) {
>> - pr_err("create_session_msg ENOMEM creating msg\n");
>> + pr_err("ceph_create_session_msg ENOMEM creating msg\n");
> instead of hardcoding the function names in these error messages, use
> __func__ instead? That makes it easier to keep up with code changes.
>
> pr_err("%s ENOMEM creating msg\n", __func__);
Sure, will fix this too.
Thanks.
>> return NULL;
>> }
>> h = msg->front.iov_base;
>> @@ -1289,7 +1289,7 @@ static struct ceph_msg *create_session_open_msg(struct ceph_mds_client *mdsc, u6
>> msg = ceph_msg_new(CEPH_MSG_CLIENT_SESSION, sizeof(*h) + extra_bytes,
>> GFP_NOFS, false);
>> if (!msg) {
>> - pr_err("create_session_msg ENOMEM creating msg\n");
>> + pr_err("ceph_create_session_msg ENOMEM creating msg\n");
>> return ERR_PTR(-ENOMEM);
>> }
>> p = msg->front.iov_base;
>> @@ -1801,8 +1801,8 @@ static int send_renew_caps(struct ceph_mds_client *mdsc,
>>
>> dout("send_renew_caps to mds%d (%s)\n", session->s_mds,
>> ceph_mds_state_name(state));
>> - msg = create_session_msg(CEPH_SESSION_REQUEST_RENEWCAPS,
>> - ++session->s_renew_seq);
>> + msg = ceph_create_session_msg(CEPH_SESSION_REQUEST_RENEWCAPS,
>> + ++session->s_renew_seq);
>> if (!msg)
>> return -ENOMEM;
>> ceph_con_send(&session->s_con, msg);
>> @@ -1816,7 +1816,7 @@ static int send_flushmsg_ack(struct ceph_mds_client *mdsc,
>>
>> dout("send_flushmsg_ack to mds%d (%s)s seq %lld\n",
>> session->s_mds, ceph_session_state_name(session->s_state), seq);
>> - msg = create_session_msg(CEPH_SESSION_FLUSHMSG_ACK, seq);
>> + msg = ceph_create_session_msg(CEPH_SESSION_FLUSHMSG_ACK, seq);
>> if (!msg)
>> return -ENOMEM;
>> ceph_con_send(&session->s_con, msg);
>> @@ -1868,7 +1868,8 @@ static int request_close_session(struct ceph_mds_session *session)
>> dout("request_close_session mds%d state %s seq %lld\n",
>> session->s_mds, ceph_session_state_name(session->s_state),
>> session->s_seq);
>> - msg = create_session_msg(CEPH_SESSION_REQUEST_CLOSE, session->s_seq);
>> + msg = ceph_create_session_msg(CEPH_SESSION_REQUEST_CLOSE,
>> + session->s_seq);
>> if (!msg)
>> return -ENOMEM;
>> ceph_con_send(&session->s_con, msg);
>> diff --git a/fs/ceph/mds_client.h b/fs/ceph/mds_client.h
>> index bf99c5ba47fc..bf2683f0ba43 100644
>> --- a/fs/ceph/mds_client.h
>> +++ b/fs/ceph/mds_client.h
>> @@ -523,6 +523,7 @@ static inline void ceph_mdsc_put_request(struct ceph_mds_request *req)
>> kref_put(&req->r_kref, ceph_mdsc_release_request);
>> }
>>
>> +extern struct ceph_msg *ceph_create_session_msg(u32 op, u64 seq);
>> extern void __ceph_queue_cap_release(struct ceph_mds_session *session,
>> struct ceph_cap *cap);
>> extern void ceph_flush_cap_releases(struct ceph_mds_client *mdsc,
next prev parent reply other threads:[~2021-06-29 13:27 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 4:42 [PATCH 0/5] flush the mdlog before waiting on unsafe reqs xiubli
2021-06-29 4:42 ` [PATCH 1/5] ceph: export ceph_create_session_msg xiubli
2021-06-29 13:12 ` Jeff Layton
2021-06-29 13:27 ` Xiubo Li [this message]
2021-06-30 12:17 ` Ilya Dryomov
2021-07-01 1:50 ` Xiubo Li
2021-06-29 4:42 ` [PATCH 2/5] ceph: export iterate_sessions xiubli
2021-06-29 15:39 ` Jeff Layton
2021-06-30 0:55 ` Xiubo Li
2021-06-29 4:42 ` [PATCH 3/5] ceph: flush mdlog before umounting xiubli
2021-06-29 15:34 ` Jeff Layton
2021-06-30 0:36 ` Xiubo Li
2021-06-30 12:39 ` Ilya Dryomov
2021-07-01 1:18 ` Xiubo Li
2021-06-29 4:42 ` [PATCH 4/5] ceph: flush the mdlog before waiting on unsafe reqs xiubli
2021-06-29 13:25 ` Jeff Layton
2021-06-30 1:26 ` Xiubo Li
2021-06-30 12:13 ` Jeff Layton
2021-07-01 1:16 ` Xiubo Li
2021-07-01 3:27 ` Patrick Donnelly
[not found] ` <e917a3e1-2902-604b-5154-98086c95357f@redhat.com>
2021-07-01 23:46 ` Patrick Donnelly
2021-07-02 0:01 ` Xiubo Li
2021-07-02 13:17 ` Xiubo Li
2021-07-02 18:14 ` Patrick Donnelly
2021-07-03 1:33 ` Xiubo Li
2021-06-29 4:42 ` [PATCH 5/5] ceph: fix ceph feature bits xiubli
2021-06-29 15:38 ` Jeff Layton
2021-06-30 0:52 ` Xiubo Li
2021-06-30 12:05 ` Jeff Layton
2021-06-30 12:52 ` Ilya Dryomov
2021-07-01 1:07 ` Xiubo Li
2021-07-01 1:08 ` Xiubo Li
2021-07-01 3:35 ` Xiubo Li
2021-06-29 15:27 ` [PATCH 0/5] flush the mdlog before waiting on unsafe reqs Jeff Layton
2021-06-30 0:35 ` Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8cc0a19a-2c67-f807-5085-46455727e8ab@redhat.com \
--to=xiubli@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=pdonnell@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).