ceph-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick Donnelly <pdonnell@redhat.com>
To: Venky Shankar <vshankar@redhat.com>
Cc: Jeff Layton <jlayton@redhat.com>,
	Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] ceph: add debugfs entries for mount syntax support
Date: Tue, 21 Sep 2021 10:01:31 -0400	[thread overview]
Message-ID: <CA+2bHPYMELh_d7UnDUOaeEjHiO-1TdeRMGTWxhYKAozOjrU1SA@mail.gmail.com> (raw)
In-Reply-To: <20210825055035.306043-3-vshankar@redhat.com>

On Wed, Aug 25, 2021 at 1:51 AM Venky Shankar <vshankar@redhat.com> wrote:
>
> Signed-off-by: Venky Shankar <vshankar@redhat.com>
> ---
>  fs/ceph/debugfs.c | 36 ++++++++++++++++++++++++++++++++++++
>  fs/ceph/super.c   |  3 +++
>  fs/ceph/super.h   |  2 ++
>  3 files changed, 41 insertions(+)
>
> diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c
> index 66989c880adb..f9ff70704423 100644
> --- a/fs/ceph/debugfs.c
> +++ b/fs/ceph/debugfs.c
> @@ -22,6 +22,14 @@
>  #include "mds_client.h"
>  #include "metric.h"
>
> +#define CLIENT_FEATURES_DIR_NAME   "client_features"
> +#define MOUNT_DEVICE_V1_SUPPORT_FILE_NAME "v1_mount_syntax"
> +#define MOUNT_DEVICE_V2_SUPPORT_FILE_NAME "v2_mount_syntax"
> +
> +static struct dentry *ceph_client_features_dir;
> +static struct dentry *ceph_mount_device_v1_support;
> +static struct dentry *ceph_mount_device_v2_support;
> +
>  static int mdsmap_show(struct seq_file *s, void *p)
>  {
>         int i;
> @@ -416,6 +424,26 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc)
>                                                   &status_fops);
>  }
>
> +void ceph_fs_debugfs_client_features_init(void)
> +{
> +       ceph_client_features_dir = debugfs_create_dir(CLIENT_FEATURES_DIR_NAME,
> +                                                     ceph_debugfs_dir);
> +       ceph_mount_device_v1_support = debugfs_create_file(MOUNT_DEVICE_V1_SUPPORT_FILE_NAME,
> +                                                          0400,
> +                                                          ceph_client_features_dir,
> +                                                          NULL, NULL);
> +       ceph_mount_device_v2_support = debugfs_create_file(MOUNT_DEVICE_V2_SUPPORT_FILE_NAME,
> +                                                          0400,
> +                                                          ceph_client_features_dir,
> +                                                          NULL, NULL);
> +}

Makes sense to me. I can see having separate files for each syntax
type is expedient. If Jeff is cool with this then so am I.

-- 
Patrick Donnelly, Ph.D.
He / Him / His
Principal Software Engineer
Red Hat Sunnyvale, CA
GPG: 19F28A586F808C2402351B93C3301A3E258DD79D


  reply	other threads:[~2021-09-21 14:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  5:50 [PATCH v2 0/2] ceph: add debugfs entries signifying new " Venky Shankar
2021-08-25  5:50 ` [PATCH v2 1/2] libceph: export ceph_debugfs_dir for use in ceph.ko Venky Shankar
2021-08-25  5:50 ` [PATCH v2 2/2] ceph: add debugfs entries for mount syntax support Venky Shankar
2021-09-21 14:01   ` Patrick Donnelly [this message]
2021-08-25 17:27 ` [PATCH v2 0/2] ceph: add debugfs entries signifying new " Jeff Layton
2021-08-26 13:17   ` Venky Shankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+2bHPYMELh_d7UnDUOaeEjHiO-1TdeRMGTWxhYKAozOjrU1SA@mail.gmail.com \
    --to=pdonnell@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=jlayton@redhat.com \
    --cc=vshankar@redhat.com \
    --subject='Re: [PATCH v2 2/2] ceph: add debugfs entries for mount syntax support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).