ceph-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Satoru Takeuchi <satoru.takeuchi@gmail.com>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: [PATCH] ceph: print fsid with mon id and osd id
Date: Thu, 5 Aug 2021 21:43:59 +0900	[thread overview]
Message-ID: <CAMym5wvnH=dSd2n+jAKJbSVRVnpzw8e=P9=EePLRfwudj6t8wg@mail.gmail.com> (raw)
In-Reply-To: <CAOi1vP8Bbo9bNOOShB2DdjfOG7u0vVqJjUkz5YXb2CBm9JEqOA@mail.gmail.com>

Hi Ilya,

> While adding fsid would help with disambiguation of messages from libceph
> instances for different clusters, it wouldn't help in the case of multiple
> libceph instances for the same cluster (i.e. see noshare mapping option).

I didn't know the multi-libceph case. Thank you for letting me know.

> For a full disambiguation we need a (cluster fsid, client gid) pair.  For
> example, something like:
>
>   libceph (<fsid> <gid>): <message>
>
>   libceph (ef1ab157-688c-483b-a94d-0aeec9ca44e0 4181): osd10 down
>
> One concern is it might be too verbose to be included in every message,
> but OTOH it would make each message truly stand on its own.

I'd like to embed gid to messages since these messages are shown not too often.
I'll revise my patch later.

Thanks,
Satoru

      reply	other threads:[~2021-08-05 12:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  7:18 [PATCH] ceph: print fsid with mon id and osd id Satoru Takeuchi
2021-08-04  7:17 ` Ilya Dryomov
2021-08-05 12:43   ` Satoru Takeuchi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMym5wvnH=dSd2n+jAKJbSVRVnpzw8e=P9=EePLRfwudj6t8wg@mail.gmail.com' \
    --to=satoru.takeuchi@gmail.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).