Re: [ceph-client:testing 19/80] fs/ceph/super.c:1122:15: error: implicit declaration of function 'fscrypt_add_test_dummy_key'

[Ilya Dryomov <idryomov@gmail.com>]

On Tue, Mar 21, 2023 at 5:00 AM kernel test robot <lkp@intel.com> wrote:
>
> tree:   https://github.com/ceph/ceph-client.git testing
> head:   bc74c6176640bed8ff55211d4211658413f5c19c
> commit: 72326544b6f873e44659da920b51572bdf76b143 [19/80] ceph: implement -o test_dummy_encryption mount option
> config: nios2-allmodconfig (https://download.01.org/0day-ci/archive/20230321/202303211100.ExmaGnB0-lkp@intel.com/config)
> compiler: nios2-linux-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/ceph/ceph-client/commit/72326544b6f873e44659da920b51572bdf76b143
>         git remote add ceph-client https://github.com/ceph/ceph-client.git
>         git fetch --no-tags ceph-client testing
>         git checkout 72326544b6f873e44659da920b51572bdf76b143
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 olddefconfig
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=nios2 SHELL=/bin/bash fs/ceph/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
> | Link: https://lore.kernel.org/oe-kbuild-all/202303211100.ExmaGnB0-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
>    fs/ceph/super.c: In function 'ceph_apply_test_dummy_encryption':
> >> fs/ceph/super.c:1122:15: error: implicit declaration of function 'fscrypt_add_test_dummy_key' [-Werror=implicit-function-declaration]
>     1122 |         err = fscrypt_add_test_dummy_key(sb, &fsc->fsc_dummy_enc_policy);
>          |               ^~~~~~~~~~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
>
>
> vim +/fscrypt_add_test_dummy_key +1122 fs/ceph/super.c
>
>   1088
>   1089  #ifdef CONFIG_FS_ENCRYPTION
>   1090  static int ceph_apply_test_dummy_encryption(struct super_block *sb,
>   1091                                              struct fs_context *fc,
>   1092                                              struct ceph_mount_options *fsopt)
>   1093  {
>   1094          struct ceph_fs_client *fsc = sb->s_fs_info;
>   1095          int err;
>   1096
>   1097          if (!fscrypt_is_dummy_policy_set(&fsopt->dummy_enc_policy))
>   1098                  return 0;
>   1099
>   1100          /* No changing encryption context on remount. */
>   1101          if (fc->purpose == FS_CONTEXT_FOR_RECONFIGURE &&
>   1102              !fscrypt_is_dummy_policy_set(&fsc->fsc_dummy_enc_policy)) {
>   1103                  if (fscrypt_dummy_policies_equal(&fsopt->dummy_enc_policy,
>   1104                                                   &fsc->fsc_dummy_enc_policy))
>   1105                          return 0;
>   1106                  errorfc(fc, "Can't set test_dummy_encryption on remount");
>   1107                  return -EINVAL;
>   1108          }
>   1109
>   1110          /* Also make sure fsopt doesn't contain a conflicting value. */
>   1111          if (fscrypt_is_dummy_policy_set(&fsc->fsc_dummy_enc_policy)) {
>   1112                  if (fscrypt_dummy_policies_equal(&fsopt->dummy_enc_policy,
>   1113                                                   &fsc->fsc_dummy_enc_policy))
>   1114                          return 0;
>   1115                  errorfc(fc, "Conflicting test_dummy_encryption options");
>   1116                  return -EINVAL;
>   1117          }
>   1118
>   1119          fsc->fsc_dummy_enc_policy = fsopt->dummy_enc_policy;
>   1120          memset(&fsopt->dummy_enc_policy, 0, sizeof(fsopt->dummy_enc_policy));
>   1121
> > 1122          err = fscrypt_add_test_dummy_key(sb, &fsc->fsc_dummy_enc_policy);

Sorry, I missed that commit 097d7c1fcb8d ("fscrypt: clean up
fscrypt_add_test_dummy_key()") unexported this function when rebasing
because CONFIG_FS_ENCRYPTION wasn't on in that directory.

Thanks,

                Ilya