Re: [PATCH] ceph: flush cap release on session flush

From: Ilya Dryomov <idryomov@gmail.com>
To: Xiubo Li <xiubli@redhat.com>
Cc: Venky Shankar <vshankar@redhat.com>,
	ceph-devel@vger.kernel.org, jlayton@kernel.org,
	mchangir@redhat.com, lhenriques@suse.de, stable@kernel.org,
	Patrick Donnelly <pdonnell@redhat.com>
Subject: Re: [PATCH] ceph: flush cap release on session flush
Date: Tue, 7 Feb 2023 17:03:32 +0100	[thread overview]
Message-ID: <CAOi1vP9sPucujJrKxy6+-7nGh90VVGtWNrPsZsH5psVW-tcDNA@mail.gmail.com> (raw)
In-Reply-To: <f31e08f5-972b-f29c-926a-2586863965f5@redhat.com>

On Tue, Feb 7, 2023 at 6:19 AM Xiubo Li <xiubli@redhat.com> wrote:
>
>
> On 07/02/2023 13:16, Venky Shankar wrote:
> > On Tue, Feb 7, 2023 at 10:35 AM <xiubli@redhat.com> wrote:
> >> From: Xiubo Li <xiubli@redhat.com>
> >>
> >> MDS expects the completed cap release prior to responding to the
> >> session flush for cache drop.
> >>
> >> Cc: <stable@kernel.org>
> >> URL: http://tracker.ceph.com/issues/38009
> >> Cc: Patrick Donnelly <pdonnell@redhat.com>
> >> Signed-off-by: Xiubo Li <xiubli@redhat.com>
> >> ---
> >>   fs/ceph/mds_client.c | 6 ++++++
> >>   1 file changed, 6 insertions(+)
> >>
> >> diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
> >> index 3c9d3f609e7f..51366bd053de 100644
> >> --- a/fs/ceph/mds_client.c
> >> +++ b/fs/ceph/mds_client.c
> >> @@ -4039,6 +4039,12 @@ static void handle_session(struct ceph_mds_session *session,
> >>                  break;
> >>
> >>          case CEPH_SESSION_FLUSHMSG:
> >> +               /* flush cap release */
> >> +               spin_lock(&session->s_cap_lock);
> >> +               if (session->s_num_cap_releases)
> >> +                       ceph_flush_cap_releases(mdsc, session);
> >> +               spin_unlock(&session->s_cap_lock);
> >> +
> >>                  send_flushmsg_ack(mdsc, session, seq);
> >>                  break;
> > Ugh. kclient never flushed cap releases o_O
>
> Yeah, I think this was missed before.

Now queued up for 6.2-rc8.

Thanks,

                Ilya