From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30F83C433E0 for ; Wed, 24 Feb 2021 11:09:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB35164E6B for ; Wed, 24 Feb 2021 11:09:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235022AbhBXLJk (ORCPT ); Wed, 24 Feb 2021 06:09:40 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34994 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235026AbhBXLHh (ORCPT ); Wed, 24 Feb 2021 06:07:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1614164771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mCwc6nRDm9GGv20OtNC9Z78gm9Rbh/8za4AwSnHSa90=; b=G1mNrIu6y9yJcKohmCtQ7h6HAb+SBq35PqS558wRvAS5MoELKc4nNKU6cmn7pgasxWpk2Y dmOGNdqlQYAyLTPyf0z4AcukQB4dPyziSuPcm4MrtayJDCj1bgFOlZ8yhuSpNaOWznI4Yi nl1Gv1QXwrRg8qG2bsB+eYLC24bwyaY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-505-xGIY2WhzPf6hyRVOJ49uNw-1; Wed, 24 Feb 2021 06:06:07 -0500 X-MC-Unique: xGIY2WhzPf6hyRVOJ49uNw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E10071936B61; Wed, 24 Feb 2021 11:06:05 +0000 (UTC) Received: from [10.72.12.156] (ovpn-12-156.pek2.redhat.com [10.72.12.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B41110016F9; Wed, 24 Feb 2021 11:05:59 +0000 (UTC) Subject: Re: [PATCH v3 0/6] ceph: convert to netfs helper library To: Jeff Layton , ceph-devel@vger.kernel.org Cc: idryomov@gmail.com, dhowells@redhat.com, linux-cachefs@redhat.com, linux-fsdevel@vger.kernel.org, willy@infradead.org References: <20210223130629.249546-1-jlayton@kernel.org> From: Xiubo Li Message-ID: Date: Wed, 24 Feb 2021 19:05:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210223130629.249546-1-jlayton@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On 2021/2/23 21:06, Jeff Layton wrote: > This is the third posting of this patchset. The main differences between > this one and the last are some bugfixes, and cleanups: > > - rebase onto David's latest fscache-netfs-lib set > - unify the netfs_read_request_ops into one struct > - fix inline_data handling in write_begin > - remove the now-unneeded i_fscache_gen field from ceph_inode_info > - rename gfp_flags to gfp in releasepage > - pass appropriate was_async flag to netfs_subreq_terminated > > This set is currently sitting in the ceph-client/testing branch, so > it should get good testing coverage over the next few weeks via in > the teuthology lab. > > Jeff Layton (6): > ceph: disable old fscache readpage handling > ceph: rework PageFsCache handling > ceph: fix fscache invalidation > ceph: convert readpage to fscache read helper > ceph: plug write_begin into read helper > ceph: convert ceph_readpages to ceph_readahead > > fs/ceph/Kconfig | 1 + > fs/ceph/addr.c | 541 +++++++++++++++++++----------------------------- > fs/ceph/cache.c | 125 ----------- > fs/ceph/cache.h | 101 +++------ > fs/ceph/caps.c | 10 +- > fs/ceph/inode.c | 1 + > fs/ceph/super.h | 2 +- > 7 files changed, 242 insertions(+), 539 deletions(-) > This series LGTM. Reviewed-by: Xiubo Li