From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 058F0C433E6 for ; Tue, 9 Feb 2021 19:58:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AFD1964EC7 for ; Tue, 9 Feb 2021 19:58:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233435AbhBIT5O (ORCPT ); Tue, 9 Feb 2021 14:57:14 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27087 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233671AbhBITrq (ORCPT ); Tue, 9 Feb 2021 14:47:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612899956; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=07hMrz2JH7QjjSYxmQ6iVqH/nriv3v/7Q+e4rDzWnzs=; b=ZWhxl+yIXM3Z5wT5KCTZnFiR5RRe8oTkXb8ZvOuzP0PYT5R/QEcAimqDdcODJYrCNHkPe6 OGVHa6D8MXqC4+fV5mUKvEw8KeJz/g1vz7UMe+328/ZfGryTCA214HRphBV6tMD6xahxCP lMGhWYcZEtf+Sr+e1brkLIzsCVMSF8I= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-355-7t1UZZdcNIOgMO--PR4L2A-1; Tue, 09 Feb 2021 14:45:53 -0500 X-MC-Unique: 7t1UZZdcNIOgMO--PR4L2A-1 Received: by mail-qt1-f198.google.com with SMTP id o20so12916463qtx.22 for ; Tue, 09 Feb 2021 11:45:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=07hMrz2JH7QjjSYxmQ6iVqH/nriv3v/7Q+e4rDzWnzs=; b=iRx1BANCyelXvEDEUL1758PoSij0UhnTTbMmi1oc/qar4yXorIKFH09FQCcNAUAXlv cTt6SOWtofkohdyRD74i7Ggo9uybiX1H+DS9pdajX3yQxj2poJQjgKl4hkIWmd1prTxI JnDtP5eKbTEartzjJCQfF3pQnSeIjpnipj5rGCzhLHxxtJoiBLqhTessslCIrJE9MgfT bcmkJNcotHsWT/HHosTChSA7iTsc4HTefbWTc6GhsJCIPaFP36S76wOx/baeyH2S7I9U rK77biq3NMpxjwpJ7Or28LXj87EJsz7hTwxH/C5xqwLA138RhCjrdJXRcXWxZ7q6s/XT D9kA== X-Gm-Message-State: AOAM530bP6IOzE/EMhe3uUFt25ZeI0ab5xXCvpoaezVr3+BqDrwni9GG LalaJwu9w9Tq2IqOjBPPEreEHumCrxhO5/7Nuti5rnqpQ9ajAx+OCzNEQHb7tlIVOk7g6vh0V2u BvRmRQFFLLBc5ZvaNYXVg/Q== X-Received: by 2002:a37:4fcf:: with SMTP id d198mr23988261qkb.277.1612899953138; Tue, 09 Feb 2021 11:45:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJybD7SbuYQXGOXd3mMxVBLEZfaSpNELJGXVWAV5LvAAprhYnJ48OVnrJ8zBSJ4tAUenGug78w== X-Received: by 2002:a37:4fcf:: with SMTP id d198mr23988232qkb.277.1612899952938; Tue, 09 Feb 2021 11:45:52 -0800 (PST) Received: from tleilax.poochiereds.net (68-20-15-154.lightspeed.rlghnc.sbcglobal.net. [68.20.15.154]) by smtp.gmail.com with ESMTPSA id p16sm3234618qtq.24.2021.02.09.11.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Feb 2021 11:45:52 -0800 (PST) Message-ID: Subject: Re: [GIT PULL] fscache: I/O API modernisation and netfs helper library From: Jeff Layton To: Linus Torvalds , David Howells Cc: Matthew Wilcox , David Wysochanski , Anna Schumaker , Trond Myklebust , Steve French , Dominique Martinet , Alexander Viro , ceph-devel@vger.kernel.org, linux-afs@lists.infradead.org, linux-cachefs@redhat.com, CIFS , linux-fsdevel , "open list:NFS, SUNRPC, AND..." , v9fs-developer@lists.sourceforge.net, Linux Kernel Mailing List Date: Tue, 09 Feb 2021 14:45:51 -0500 In-Reply-To: References: <591237.1612886997@warthog.procyon.org.uk> Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.38.3 (3.38.3-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On Tue, 2021-02-09 at 11:06 -0800, Linus Torvalds wrote: > So I'm looking at this early, because I have more time now than I will > have during the merge window, and honestly, your pull requests have > been problematic in the past. > > The PG_fscache bit waiting functions are completely crazy. The comment > about "this will wake up others" is actively wrong, and the waiting > function looks insane, because you're mixing the two names for > "fscache" which makes the code look totally incomprehensible. Why > would we wait for PF_fscache, when PG_private_2 was set? Yes, I know > why, but the code looks entirely nonsensical. > > So just looking at the support infrastructure changes, I get a big "Hmm". > > But the thing that makes me go "No, I won't pull this", is that it has > all the same hallmark signs of trouble that I've complained about > before: I see absolutely zero sign of "this has more developers > involved". > > There's not a single ack from a VM person for the VM changes. There's > no sign that this isn't yet another "David Howells went off alone and > did something that absolutely nobody else cared about". > > See my problem? I need to be convinced that this makes sense outside > of your world, and it's not yet another thing that will cause problems > down the line because nobody else really ever used it or cared about > it until we hit a snag. > >                   Linus > I (and several other developers) have been working with David on this for the last year or so. Would it help if I gave this on the netfs lib work and the fscache patches? Reviewed-and-tested-by: Jeff Layton My testing has mainly been with ceph. My main interest is that this allows us to drop a fairly significant chunk of rather nasty code from fs/ceph. The netfs read helper infrastructure makes a _lot_ more sense for a networked filesystem, IMO. The legacy fscache code has some significant bugs too, and this gives it a path to making better use of more modern kernel features. It should also be set up so that filesystems can be converted piecemeal. I'd really like to see this go in. Cheers, Jeff