ceph-devel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiubo Li <xiubli@redhat.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: idryomov@gmail.com, pdonnell@redhat.com, ceph-devel@vger.kernel.org
Subject: Re: [PATCH v3] ceph: defer flushing the capsnap if the Fb is used
Date: Wed, 20 Jan 2021 08:56:34 +0800	[thread overview]
Message-ID: <d05c2108-079d-f9c4-7a65-2be42579ecbb@redhat.com> (raw)
In-Reply-To: <5a6fd5f3ab30fe04332bc4af4ecdeaca7fd501c0.camel@kernel.org>

On 2021/1/18 19:08, Jeff Layton wrote:
> On Mon, 2021-01-18 at 17:10 +0800, Xiubo Li wrote:
>> On 2021/1/13 5:48, Jeff Layton wrote:
>>> On Sun, 2021-01-10 at 10:01 +0800, xiubli@redhat.com wrote:
>>>> From: Xiubo Li <xiubli@redhat.com>
>>>>
>>>> If the Fb cap is used it means the current inode is flushing the
>>>> dirty data to OSD, just defer flushing the capsnap.
>>>>
>>>> URL: https://tracker.ceph.com/issues/48679
>>>> URL: https://tracker.ceph.com/issues/48640
>>>> Signed-off-by: Xiubo Li <xiubli@redhat.com>
>>>> ---
>>>>
>>>> V3:
>>>> - Add more comments about putting the inode ref
>>>> - A small change about the code style
>>>>
>>>> V2:
>>>> - Fix inode reference leak bug
>>>>
>>>>   fs/ceph/caps.c | 32 +++++++++++++++++++-------------
>>>>   fs/ceph/snap.c |  6 +++---
>>>>   2 files changed, 22 insertions(+), 16 deletions(-)
>>>>
>>> Hi Xiubo,
>>>
>>> This patch seems to cause hangs in some xfstests (generic/013, in
>>> particular). I'll take a closer look when I have a chance, but I'm
>>> dropping this for now.
>> Okay.
>>
>> BTW, what's your test commands to reproduce it ? I will take a look when
>> I am free these days or later.
>>
>> BRs
>>
> I set up xfstests to run on cephfs, and then just run:
>
>      $ sudo ./check generic/013
>
> It wouldn't reliably complete with this patch in place. Setting up
> xfstests is the "hard part". I'll plan to roll up a wiki page on how to
> do that soon (that's good info to have out there anyway).

Okay, sure.

Thanks.


> Cheers,



  reply	other threads:[~2021-01-20  0:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-10  2:01 [PATCH v3] ceph: defer flushing the capsnap if the Fb is used xiubli
2021-01-12 21:48 ` Jeff Layton
2021-01-18  9:10   ` Xiubo Li
2021-01-18 11:08     ` Jeff Layton
2021-01-20  0:56       ` Xiubo Li [this message]
2021-01-20 20:04         ` Jeff Layton
2021-01-21 14:28     ` Jeff Layton
2021-01-22 10:07       ` Xiubo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d05c2108-079d-f9c4-7a65-2be42579ecbb@redhat.com \
    --to=xiubli@redhat.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=idryomov@gmail.com \
    --cc=jlayton@kernel.org \
    --cc=pdonnell@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).