From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C513C433E0 for ; Tue, 2 Feb 2021 12:39:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5971164F4E for ; Tue, 2 Feb 2021 12:39:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231543AbhBBMim (ORCPT ); Tue, 2 Feb 2021 07:38:42 -0500 Received: from mail.kernel.org ([198.145.29.99]:48408 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229632AbhBBMij (ORCPT ); Tue, 2 Feb 2021 07:38:39 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8BEE464F45; Tue, 2 Feb 2021 12:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612269479; bh=je7dIPClMfEtrD5fgHTYPSeqcK3b36ynb6JnzcnLc1U=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=e0ewikM4GzYN/eYGmoXngOU7BX26Ij2Duy9cY5RBRz82KcYV4UfBwdJNtrfdo8kdG FE92ic6pljglF/t7+GvXGQauQ3103HjWQcaWFmCfk7dmw9W+mY7HLFpqZJiOWCSGcE 8Kr+97CNKjFzs1VmQl3bJOMhxdvihjioKQmoYMf1m2bfGHjMZrPR+UHMxUHBWhFuXW AtqVtCtlpqWXqnMM5XSWOaGCKtdjGTR/yyPS2S46fMrS+TQb2hrfkhZfVvD20Wp1rr BQba9rezRzxVV6Os0ohFe+xM+NUHWQuIT9pxtVAwbHSwqAmAe379WIzwSHO4liR+pW PdBMg4awhwS7w== Message-ID: Subject: Re: [PATCH] ceph: Fix an Oops in error handling From: Jeff Layton To: Dan Carpenter , David Howells Cc: Ilya Dryomov , ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Date: Tue, 02 Feb 2021 07:37:57 -0500 In-Reply-To: References: Content-Type: text/plain; charset="ISO-8859-15" User-Agent: Evolution 3.38.3 (3.38.3-1.fc33) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On Tue, 2021-02-02 at 08:47 +0300, Dan Carpenter wrote: > The "req" pointer is an error pointer and not NULL so this check needs > to be fixed. > > Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper") > Signed-off-by: Dan Carpenter > --- >  fs/ceph/addr.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c > index 5eec6f66fe52..fb0238a4d34f 100644 > --- a/fs/ceph/addr.c > +++ b/fs/ceph/addr.c > @@ -273,7 +273,7 @@ static void ceph_netfs_issue_op(struct netfs_read_subrequest *subreq) >   if (err) >   iput(inode); >  out: > - if (req) > + if (!IS_ERR_OR_NULL(req)) >   ceph_osdc_put_request(req); >   if (err) >   netfs_subreq_terminated(subreq, err); Good catch. David, could you take this into your fscache-next branch? Reviewed-by: Jeff Layton