From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A133C63798 for ; Fri, 20 Nov 2020 08:59:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B05AE22256 for ; Fri, 20 Nov 2020 08:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727340AbgKTI6o (ORCPT ); Fri, 20 Nov 2020 03:58:44 -0500 Received: from mx2.suse.de ([195.135.220.15]:48036 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727159AbgKTI6o (ORCPT ); Fri, 20 Nov 2020 03:58:44 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 5CAD1AC23; Fri, 20 Nov 2020 08:58:42 +0000 (UTC) Subject: Re: [PATCH 74/78] block: merge struct block_device and struct hd_struct To: Christoph Hellwig , Jens Axboe Cc: Justin Sanders , Josef Bacik , Ilya Dryomov , Jack Wang , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Konrad Rzeszutek Wilk , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Minchan Kim , Mike Snitzer , Song Liu , "Martin K. Petersen" , dm-devel@redhat.com, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org References: <20201116145809.410558-1-hch@lst.de> <20201116145809.410558-75-hch@lst.de> From: Hannes Reinecke Message-ID: Date: Fri, 20 Nov 2020 09:58:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <20201116145809.410558-75-hch@lst.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On 11/16/20 3:58 PM, Christoph Hellwig wrote: > Instead of having two structures that represent each block device with > different lift time rules merged them into a single one. This also > greatly simplifies the reference counting rules, as we can use the inode > reference count as the main reference count for the new struct > block_device, with the device model reference front ending it for device > model interaction. The percpu refcount in struct hd_struct is entirely > gone given that struct block_device must be opened and thus valid for > the duration of the I/O. > > Signed-off-by: Christoph Hellwig > --- > block/bio.c | 6 +- > block/blk-cgroup.c | 9 +- > block/blk-core.c | 85 +++++----- > block/blk-flush.c | 2 +- > block/blk-lib.c | 2 +- > block/blk-merge.c | 6 +- > block/blk-mq.c | 11 +- > block/blk-mq.h | 5 +- > block/blk.h | 38 ++--- > block/genhd.c | 242 +++++++++++------------------ > block/ioctl.c | 4 +- > block/partitions/core.c | 221 +++++++------------------- > drivers/block/drbd/drbd_receiver.c | 2 +- > drivers/block/drbd/drbd_worker.c | 2 +- > drivers/block/zram/zram_drv.c | 2 +- > drivers/md/bcache/request.c | 4 +- > drivers/md/dm.c | 8 +- > drivers/md/md.c | 4 +- > drivers/nvme/target/admin-cmd.c | 20 +-- > drivers/s390/block/dasd.c | 8 +- > fs/block_dev.c | 68 +++----- > fs/ext4/super.c | 18 +-- > fs/ext4/sysfs.c | 10 +- > fs/f2fs/checkpoint.c | 5 +- > fs/f2fs/f2fs.h | 2 +- > fs/f2fs/super.c | 6 +- > fs/f2fs/sysfs.c | 9 -- > include/linux/blk_types.h | 23 ++- > include/linux/blkdev.h | 13 +- > include/linux/genhd.h | 67 ++------ > include/linux/part_stat.h | 17 +- > init/do_mounts.c | 20 +-- > kernel/trace/blktrace.c | 54 ++----- > 33 files changed, 351 insertions(+), 642 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer