From: Hans de Goede <hdegoede@redhat.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org
Cc: krzysztof.hejmowski@intel.com, filip.kaczmarski@intel.com,
harshapriya.n@intel.com, ppapierkowski@habana.ai,
marcin.barlik@intel.com, zwisler@google.com,
pierre-louis.bossart@linux.intel.com, lgirdwood@gmail.com,
filip.proborszcz@intel.com, broonie@kernel.org,
amadeuszx.slawinski@linux.intel.com, michal.wasko@intel.com,
tiwai@suse.com, andriy.shevchenko@linux.intel.com,
cujomalainey@chromium.org, vamshi.krishna.gopal@intel.com
Subject: Re: [PATCH v2 00/13] ASoC: Intel: Remove obsolete solutions and components
Date: Mon, 12 Oct 2020 10:26:17 +0200 [thread overview]
Message-ID: <cf1fb47d-412f-48fd-4501-e63f1db32bc1@redhat.com> (raw)
In-Reply-To: <20201006064907.16277-1-cezary.rojewski@intel.com>
Hi,
On 10/6/20 8:48 AM, Cezary Rojewski wrote:
> Follow up to catpt series as mentioned in:
> [PATCH v10 00/14] ASoC: Intel: Catpt - Lynx and Wildcat point
> https://www.spinics.net/lists/alsa-devel/msg116440.html
>
> As catpt is a direct replacement to sound/soc/intel/haswell, it leaves a
> lot of code redudant. The second legacy solution - baytrail - is
> deprecated for a long time by sound/soc/intel/atom with SOF flavor
> available too.
>
> This series addresses the redudancy and removes obsolete code. Along
> with the legacy solutions, all orphaned components are removed too.
>
> As a consequence, further cleanups are unlocked: sound/soc/intel/skylake
> becomes the sole user of processing code found in
> sound/soc/intel/common. Those are not part of this series.
Since I've mostly worked with Pierre-Louis on this, I guess you may not
know this, but I have more or less single handedly have made sure that
audio works properly on Bay Trail and Cherry Trail devices during the
last few years. Can you please Cc me on future series which impact
Bay Trail / Cherry Trail support ?
FWIW (since that this is already merged) I'm fine with removing the
quite old Bay Trail support from common/sst-acpi.c, at least Fedora
has been using the medium-old (with SOF being the new thing)
CONFIG_SND_SST_IPC_ACPI support for Bay Trail audio support for
quite some time now.
This is not just about Bay Trail And Cherry Trail devices though,
this series also makes changes impacting Haswell and Broadwell devices.
The commit removing this support claims that at least for Haswell the
new sound/soc/intel/catpt replaces it, but I do not see that code in
5.9, so that means that in one cycle we are both introducing the
replacement and dropping the old code ? I'm not sure if that is such
a great idea, what is the fallback plan if testing does find significant
issues with the new catpt code ?
Anyways since AFAIK this series is already in next I guess we will
find out how this goes.
Regards,
Hans
next prev parent reply other threads:[~2020-10-12 8:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 6:48 [PATCH v2 00/13] ASoC: Intel: Remove obsolete solutions and components Cezary Rojewski
2020-10-06 6:48 ` [PATCH v2 01/13] ASoC: Intel: Remove haswell solution Cezary Rojewski
2020-10-06 6:48 ` [PATCH v2 02/13] ASoC: Intel: Remove max98090 support for baytrail solution Cezary Rojewski
2020-10-06 6:48 ` [PATCH v2 03/13] ASoC: Intel: Remove rt5640 " Cezary Rojewski
2020-10-06 6:48 ` [PATCH v2 04/13] ASoC: Intel: Remove " Cezary Rojewski
2020-10-06 6:48 ` [PATCH v2 05/13] ASoC: Intel: Remove SST ACPI component Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 06/13] ASoC: Intel: Remove SST firmware components Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 07/13] ASoC: Intel: Skylake: Unassign ram_read and read_write ops Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 08/13] ASoC: Intel: Remove unused DSP operations Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 09/13] ASoC: Intel: Remove unused DSP interface fields Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 10/13] ASoC: Intel: Remove SST-legacy specific constants Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 11/13] ASoC: Intel: Make atom components independent of sst-dsp Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 12/13] ASoC: Intel: Remove sst_pdata structure Cezary Rojewski
2020-10-06 6:49 ` [PATCH v2 13/13] ASoC: Intel: Remove sst_dsp_get_thread_context Cezary Rojewski
2020-10-06 12:22 ` [PATCH v2 00/13] ASoC: Intel: Remove obsolete solutions and components Liam Girdwood
2020-10-06 15:20 ` Pierre-Louis Bossart
2020-10-06 15:20 ` Mark Brown
2020-10-12 8:26 ` Hans de Goede [this message]
2020-10-12 9:09 ` Takashi Iwai
2020-10-12 11:36 ` Mark Brown
2020-10-12 11:53 ` Hans de Goede
2020-10-12 12:19 ` Rojewski, Cezary
2020-10-12 12:39 ` Mark Brown
2020-10-12 9:24 ` Rojewski, Cezary
2020-10-12 9:30 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf1fb47d-412f-48fd-4501-e63f1db32bc1@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=cujomalainey@chromium.org \
--cc=filip.kaczmarski@intel.com \
--cc=filip.proborszcz@intel.com \
--cc=harshapriya.n@intel.com \
--cc=krzysztof.hejmowski@intel.com \
--cc=lgirdwood@gmail.com \
--cc=marcin.barlik@intel.com \
--cc=michal.wasko@intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ppapierkowski@habana.ai \
--cc=tiwai@suse.com \
--cc=vamshi.krishna.gopal@intel.com \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.