chrome-platform.lists.linux.dev archive mirror
 help / color / mirror / Atom feed
* [PATCH] platform/chrome: cros_ec: Report EC panic as uevent
@ 2023-04-20 17:46 Rob Barnes
  2023-04-20 21:08 ` Prashant Malani
  0 siblings, 1 reply; 10+ messages in thread
From: Rob Barnes @ 2023-04-20 17:46 UTC (permalink / raw)
  To: chrome-platform; +Cc: dnojiri, tzungbi, Rob Barnes

Create a uevent when an EC panic is detected. This will allow udev rules
to trigger when a panic occurs. E.g. a udev rule could be added to
create an EC coredump. This approach allows more code to be moved out
of the kernel drivers.

Change-Id: I4fe7e4e603dcbf0ae6d4c4506f8978b0486abbbf
Signed-off-by: Rob Barnes <robbarnes@google.com>
---
 drivers/platform/chrome/cros_ec_lpc.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
index b399f7cbf17be..f2d5b00e6c3a0 100644
--- a/drivers/platform/chrome/cros_ec_lpc.c
+++ b/drivers/platform/chrome/cros_ec_lpc.c
@@ -16,6 +16,7 @@
 #include <linux/delay.h>
 #include <linux/io.h>
 #include <linux/interrupt.h>
+#include <linux/kobject.h>
 #include <linux/module.h>
 #include <linux/platform_data/cros_ec_commands.h>
 #include <linux/platform_data/cros_ec_proto.h>
@@ -313,6 +314,23 @@ static int cros_ec_lpc_readmem(struct cros_ec_device *ec, unsigned int offset,
 	return cnt;
 }
 
+/**
+ * cros_ec_lpc_panic_uevent() - Publish EC panic uevent
+ * @ec_dev: Device that panic'd
+ *
+ * This function will generate a uevent to notify userspace.
+ * Typically the system will be reset shortly after an EC panic occurs.
+ *
+ * Return: 0 on success or <0 on error.
+ */
+static int cros_ec_lpc_panic_uevent(struct cros_ec_device *ec_dev)
+{
+	struct device *dev = ec_dev->dev;
+	static char *env[] = { "ERROR=PANIC", NULL };
+
+	return kobject_uevent_env(&dev->kobj, KOBJ_CHANGE, env);
+}
+
 static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
 {
 	struct cros_ec_device *ec_dev = data;
@@ -324,6 +342,8 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
 	if (value == ACPI_NOTIFY_CROS_EC_PANIC) {
 		dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!");
 		blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev);
+		cros_ec_lpc_panic_uevent(ec_dev);
+
 		/* Begin orderly shutdown. Force shutdown after 1 second. */
 		hw_protection_shutdown("CrOS EC Panic", 1000);
 		/* Do not query for other events after a panic is reported */
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH] platform/chrome: cros_ec: Report EC panic as uevent
  2023-04-20 17:46 [PATCH] platform/chrome: cros_ec: Report EC panic as uevent Rob Barnes
@ 2023-04-20 21:08 ` Prashant Malani
  2023-04-24 16:44   ` Rob Barnes
  0 siblings, 1 reply; 10+ messages in thread
From: Prashant Malani @ 2023-04-20 21:08 UTC (permalink / raw)
  To: Rob Barnes; +Cc: chrome-platform, dnojiri, tzungbi

On Thu, Apr 20, 2023 at 10:46 AM Rob Barnes <robbarnes@google.com> wrote:
>
> Create a uevent when an EC panic is detected. This will allow udev rules
> to trigger when a panic occurs. E.g. a udev rule could be added to
> create an EC coredump. This approach allows more code to be moved out
> of the kernel drivers.

Can you elaborate? What code do you plan on moving out of the kernel drivers?
Is there a follow up patch which does this?

Also, do you have a link to the userspace code that generates the coredump?

>
> Change-Id: I4fe7e4e603dcbf0ae6d4c4506f8978b0486abbbf
Change-Id's are not accepted in upstream submissions.

> Signed-off-by: Rob Barnes <robbarnes@google.com>
> ---
>  drivers/platform/chrome/cros_ec_lpc.c | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
> index b399f7cbf17be..f2d5b00e6c3a0 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -16,6 +16,7 @@
>  #include <linux/delay.h>
>  #include <linux/io.h>
>  #include <linux/interrupt.h>
> +#include <linux/kobject.h>
>  #include <linux/module.h>
>  #include <linux/platform_data/cros_ec_commands.h>
>  #include <linux/platform_data/cros_ec_proto.h>
> @@ -313,6 +314,23 @@ static int cros_ec_lpc_readmem(struct cros_ec_device *ec, unsigned int offset,
>         return cnt;
>  }
>
> +/**
> + * cros_ec_lpc_panic_uevent() - Publish EC panic uevent
> + * @ec_dev: Device that panic'd
> + *
> + * This function will generate a uevent to notify userspace.
> + * Typically the system will be reset shortly after an EC panic occurs.
> + *
> + * Return: 0 on success or <0 on error.
> + */
> +static int cros_ec_lpc_panic_uevent(struct cros_ec_device *ec_dev)
> +{
> +       struct device *dev = ec_dev->dev;
> +       static char *env[] = { "ERROR=PANIC", NULL };
> +
> +       return kobject_uevent_env(&dev->kobj, KOBJ_CHANGE, env);
> +}

I think it's better to just inline this. I don't see any other user for this,
and  the return value is being ignored anyway.

> +
>  static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
>  {
>         struct cros_ec_device *ec_dev = data;
> @@ -324,6 +342,8 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
>         if (value == ACPI_NOTIFY_CROS_EC_PANIC) {
>                 dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!");
>                 blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev);
> +               cros_ec_lpc_panic_uevent(ec_dev);
> +
>                 /* Begin orderly shutdown. Force shutdown after 1 second. */
>                 hw_protection_shutdown("CrOS EC Panic", 1000);
>                 /* Do not query for other events after a panic is reported */
> --
> 2.39.2
>
>

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH] platform/chrome: cros_ec: Report EC panic as uevent
  2023-04-20 21:08 ` Prashant Malani
@ 2023-04-24 16:44   ` Rob Barnes
  2023-05-09 22:22     ` [PATCH v2] " Rob Barnes
  0 siblings, 1 reply; 10+ messages in thread
From: Rob Barnes @ 2023-04-24 16:44 UTC (permalink / raw)
  To: Prashant Malani; +Cc: chrome-platform, dnojiri, tzungbi

On Thu, Apr 20, 2023 at 3:08 PM Prashant Malani <pmalani@chromium.org> wrote:
>
> On Thu, Apr 20, 2023 at 10:46 AM Rob Barnes <robbarnes@google.com> wrote:
> >
> > Create a uevent when an EC panic is detected. This will allow udev rules
> > to trigger when a panic occurs. E.g. a udev rule could be added to
> > create an EC coredump. This approach allows more code to be moved out
> > of the kernel drivers.
>
> Can you elaborate? What code do you plan on moving out of the kernel drivers?
> Is there a follow up patch which does this?
>
More accurately, it's preventing the need for more code to be added to
the kernel drivers
to support new features, like EC coredump.

> Also, do you have a link to the userspace code that generates the coredump?
>
This CL adss a udev rule to trigger the crash collector on EC panic:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/4450501

This WIP CL adds the EC coredump utility:
https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/4421417

This WIP CL adds a udev rule to trigger EC coredump utility on ec panic:
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/4424209

The WIP CLs should be ready for review later this week.
> >
> > Change-Id: I4fe7e4e603dcbf0ae6d4c4506f8978b0486abbbf
> Change-Id's are not accepted in upstream submissions.
>
> > Signed-off-by: Rob Barnes <robbarnes@google.com>
> > ---
> >  drivers/platform/chrome/cros_ec_lpc.c | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> >
> > diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
> > index b399f7cbf17be..f2d5b00e6c3a0 100644
> > --- a/drivers/platform/chrome/cros_ec_lpc.c
> > +++ b/drivers/platform/chrome/cros_ec_lpc.c
> > @@ -16,6 +16,7 @@
> >  #include <linux/delay.h>
> >  #include <linux/io.h>
> >  #include <linux/interrupt.h>
> > +#include <linux/kobject.h>
> >  #include <linux/module.h>
> >  #include <linux/platform_data/cros_ec_commands.h>
> >  #include <linux/platform_data/cros_ec_proto.h>
> > @@ -313,6 +314,23 @@ static int cros_ec_lpc_readmem(struct cros_ec_device *ec, unsigned int offset,
> >         return cnt;
> >  }
> >
> > +/**
> > + * cros_ec_lpc_panic_uevent() - Publish EC panic uevent
> > + * @ec_dev: Device that panic'd
> > + *
> > + * This function will generate a uevent to notify userspace.
> > + * Typically the system will be reset shortly after an EC panic occurs.
> > + *
> > + * Return: 0 on success or <0 on error.
> > + */
> > +static int cros_ec_lpc_panic_uevent(struct cros_ec_device *ec_dev)
> > +{
> > +       struct device *dev = ec_dev->dev;
> > +       static char *env[] = { "ERROR=PANIC", NULL };
> > +
> > +       return kobject_uevent_env(&dev->kobj, KOBJ_CHANGE, env);
> > +}
>
> I think it's better to just inline this. I don't see any other user for this,
> and  the return value is being ignored anyway.
>
> > +
> >  static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
> >  {
> >         struct cros_ec_device *ec_dev = data;
> > @@ -324,6 +342,8 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
> >         if (value == ACPI_NOTIFY_CROS_EC_PANIC) {
> >                 dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!");
> >                 blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev);
> > +               cros_ec_lpc_panic_uevent(ec_dev);
> > +
> >                 /* Begin orderly shutdown. Force shutdown after 1 second. */
> >                 hw_protection_shutdown("CrOS EC Panic", 1000);
> >                 /* Do not query for other events after a panic is reported */
> > --
> > 2.39.2
> >
> >

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v2] platform/chrome: cros_ec: Report EC panic as uevent
  2023-04-24 16:44   ` Rob Barnes
@ 2023-05-09 22:22     ` Rob Barnes
  2023-05-09 22:59       ` Prashant Malani
  0 siblings, 1 reply; 10+ messages in thread
From: Rob Barnes @ 2023-05-09 22:22 UTC (permalink / raw)
  To: chrome-platform; +Cc: dnojiri, tzungbi, pmalani, Rob Barnes

Create a uevent when an EC panic is detected. This will allow udev rules
to trigger when a panic occurs. E.g. a udev rule could be added to
capture an EC coredump. This approach avoids the need to stuff all the
processing into the driver.

Signed-off-by: Rob Barnes <robbarnes@google.com>
---
Changlog since v1:
- Inline uevent call

 drivers/platform/chrome/cros_ec_lpc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
index b399f7cbf17be..fbce9898dc7e1 100644
--- a/drivers/platform/chrome/cros_ec_lpc.c
+++ b/drivers/platform/chrome/cros_ec_lpc.c
@@ -16,6 +16,7 @@
 #include <linux/delay.h>
 #include <linux/io.h>
 #include <linux/interrupt.h>
+#include <linux/kobject.h>
 #include <linux/module.h>
 #include <linux/platform_data/cros_ec_commands.h>
 #include <linux/platform_data/cros_ec_proto.h>
@@ -322,8 +323,11 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
 	ec_dev->last_event_time = cros_ec_get_time_ns();
 
 	if (value == ACPI_NOTIFY_CROS_EC_PANIC) {
+		static const char *env[] = { "ERROR=PANIC", NULL };
 		dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!");
 		blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev);
+		/* Publish uevent for userspace handlers */
+		kobject_uevent_env(&ec_dev->dev->kobj, KOBJ_CHANGE, (char **)env);
 		/* Begin orderly shutdown. Force shutdown after 1 second. */
 		hw_protection_shutdown("CrOS EC Panic", 1000);
 		/* Do not query for other events after a panic is reported */
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v2] platform/chrome: cros_ec: Report EC panic as uevent
  2023-05-09 22:22     ` [PATCH v2] " Rob Barnes
@ 2023-05-09 22:59       ` Prashant Malani
  2023-05-09 23:19         ` [PATCH v3] " Rob Barnes
  0 siblings, 1 reply; 10+ messages in thread
From: Prashant Malani @ 2023-05-09 22:59 UTC (permalink / raw)
  To: Rob Barnes; +Cc: chrome-platform, dnojiri, tzungbi

Hi Rob,

On Tue, May 9, 2023 at 3:22 PM Rob Barnes <robbarnes@google.com> wrote:
>
> Create a uevent when an EC panic is detected. This will allow udev rules
> to trigger when a panic occurs. E.g. a udev rule could be added to
> capture an EC coredump. This approach avoids the need to stuff all the
> processing into the driver.
>
> Signed-off-by: Rob Barnes <robbarnes@google.com>

I listed a couple of nits, but once those are fixed, please feel free to add:
Reviewed-by: Prashant Malani <pmalani@chromium.org>

> ---
> Changlog since v1:
> - Inline uevent call
>
>  drivers/platform/chrome/cros_ec_lpc.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
> index b399f7cbf17be..fbce9898dc7e1 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -16,6 +16,7 @@
>  #include <linux/delay.h>
>  #include <linux/io.h>
>  #include <linux/interrupt.h>
> +#include <linux/kobject.h>
>  #include <linux/module.h>
>  #include <linux/platform_data/cros_ec_commands.h>
>  #include <linux/platform_data/cros_ec_proto.h>
> @@ -322,8 +323,11 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
>         ec_dev->last_event_time = cros_ec_get_time_ns();
>
>         if (value == ACPI_NOTIFY_CROS_EC_PANIC) {
> +               static const char *env[] = { "ERROR=PANIC", NULL };
The convention in this file is to have variable declarations at the
beginning of the function block,
so please follow that here.

>                 dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!");
>                 blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev);
> +               /* Publish uevent for userspace handlers */
I don't think this comment is necessary. uevents are for use by
userspace (by definition).

Best regards,

-Prashant

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v3] platform/chrome: cros_ec: Report EC panic as uevent
  2023-05-09 22:59       ` Prashant Malani
@ 2023-05-09 23:19         ` Rob Barnes
  2023-05-09 23:25           ` Prashant Malani
  2023-05-09 23:26           ` [PATCH v4] " Rob Barnes
  0 siblings, 2 replies; 10+ messages in thread
From: Rob Barnes @ 2023-05-09 23:19 UTC (permalink / raw)
  To: chrome-platform; +Cc: dnojiri, tzungbi, pmalani, Rob Barnes

iCreate a uevent when an EC panic is detected. This will allow udev rules
to trigger when a panic occurs. E.g. a udev rule could be added to
capture an EC coredump. This approach avoids the need to stuff all the
processing into the driver.

Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Prashant Malani <pmalani@chromium.org>

---
Changlog since v2:
 - Move variable declaration to top of function

Changlog since v1:
 - Inline uevent call

 drivers/platform/chrome/cros_ec_lpc.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
index b399f7cbf17be..c6920df1e95dd 100644
--- a/drivers/platform/chrome/cros_ec_lpc.c
+++ b/drivers/platform/chrome/cros_ec_lpc.c
@@ -16,6 +16,7 @@
 #include <linux/delay.h>
 #include <linux/io.h>
 #include <linux/interrupt.h>
+#include <linux/kobject.h>
 #include <linux/module.h>
 #include <linux/platform_data/cros_ec_commands.h>
 #include <linux/platform_data/cros_ec_proto.h>
@@ -315,6 +316,7 @@ static int cros_ec_lpc_readmem(struct cros_ec_device *ec, unsigned int offset,
 
 static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
 {
+	static const char *env[] = { "ERROR=PANIC", NULL };
 	struct cros_ec_device *ec_dev = data;
 	bool ec_has_more_events;
 	int ret;
@@ -324,6 +326,7 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
 	if (value == ACPI_NOTIFY_CROS_EC_PANIC) {
 		dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!");
 		blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev);
+		kobject_uevent_env(&ec_dev->dev->kobj, KOBJ_CHANGE, (char **)env);
 		/* Begin orderly shutdown. Force shutdown after 1 second. */
 		hw_protection_shutdown("CrOS EC Panic", 1000);
 		/* Do not query for other events after a panic is reported */
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v3] platform/chrome: cros_ec: Report EC panic as uevent
  2023-05-09 23:19         ` [PATCH v3] " Rob Barnes
@ 2023-05-09 23:25           ` Prashant Malani
  2023-05-09 23:26           ` [PATCH v4] " Rob Barnes
  1 sibling, 0 replies; 10+ messages in thread
From: Prashant Malani @ 2023-05-09 23:25 UTC (permalink / raw)
  To: Rob Barnes; +Cc: chrome-platform, dnojiri, tzungbi

On Tue, May 9, 2023 at 4:19 PM Rob Barnes <robbarnes@google.com> wrote:
>
> iCreate a uevent when an EC panic is detected. This will allow udev rules

Looks like a typo slipped through :/

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH v4] platform/chrome: cros_ec: Report EC panic as uevent
  2023-05-09 23:19         ` [PATCH v3] " Rob Barnes
  2023-05-09 23:25           ` Prashant Malani
@ 2023-05-09 23:26           ` Rob Barnes
  2023-05-15  5:20             ` patchwork-bot+chrome-platform
  2023-05-19  2:00             ` patchwork-bot+chrome-platform
  1 sibling, 2 replies; 10+ messages in thread
From: Rob Barnes @ 2023-05-09 23:26 UTC (permalink / raw)
  To: chrome-platform; +Cc: dnojiri, tzungbi, pmalani, Rob Barnes

Create a uevent when an EC panic is detected. This will allow udev rules
to trigger when a panic occurs. For example, a udev rule could be added to
capture an EC coredump. This approach avoids the need to stuff all the
processing into the driver.

Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Prashant Malani <pmalani@chromium.org>

---
Changelog since v3:
- Fix typos in commit message

Changelog since v2:
- Move variable declaration to top of function

Changelog since v1:
- Inline uevent call

drivers/platform/chrome/cros_ec_lpc.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
index b399f7cbf17be..c6920df1e95dd 100644
--- a/drivers/platform/chrome/cros_ec_lpc.c
+++ b/drivers/platform/chrome/cros_ec_lpc.c
@@ -16,6 +16,7 @@
 #include <linux/delay.h>
 #include <linux/io.h>
 #include <linux/interrupt.h>
+#include <linux/kobject.h>
 #include <linux/module.h>
 #include <linux/platform_data/cros_ec_commands.h>
 #include <linux/platform_data/cros_ec_proto.h>
@@ -315,6 +316,7 @@ static int cros_ec_lpc_readmem(struct cros_ec_device *ec, unsigned int offset,
 
 static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
 {
+	static const char *env[] = { "ERROR=PANIC", NULL };
 	struct cros_ec_device *ec_dev = data;
 	bool ec_has_more_events;
 	int ret;
@@ -324,6 +326,7 @@ static void cros_ec_lpc_acpi_notify(acpi_handle device, u32 value, void *data)
 	if (value == ACPI_NOTIFY_CROS_EC_PANIC) {
 		dev_emerg(ec_dev->dev, "CrOS EC Panic Reported. Shutdown is imminent!");
 		blocking_notifier_call_chain(&ec_dev->panic_notifier, 0, ec_dev);
+		kobject_uevent_env(&ec_dev->dev->kobj, KOBJ_CHANGE, (char **)env);
 		/* Begin orderly shutdown. Force shutdown after 1 second. */
 		hw_protection_shutdown("CrOS EC Panic", 1000);
 		/* Do not query for other events after a panic is reported */
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] platform/chrome: cros_ec: Report EC panic as uevent
  2023-05-09 23:26           ` [PATCH v4] " Rob Barnes
@ 2023-05-15  5:20             ` patchwork-bot+chrome-platform
  2023-05-19  2:00             ` patchwork-bot+chrome-platform
  1 sibling, 0 replies; 10+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-05-15  5:20 UTC (permalink / raw)
  To: Rob Barnes; +Cc: chrome-platform, dnojiri, tzungbi, pmalani

Hello:

This patch was applied to chrome-platform/linux.git (for-kernelci)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Tue,  9 May 2023 23:26:24 +0000 you wrote:
> Create a uevent when an EC panic is detected. This will allow udev rules
> to trigger when a panic occurs. For example, a udev rule could be added to
> capture an EC coredump. This approach avoids the need to stuff all the
> processing into the driver.
> 
> Signed-off-by: Rob Barnes <robbarnes@google.com>
> Reviewed-by: Prashant Malani <pmalani@chromium.org>
> 
> [...]

Here is the summary with links:
  - [v4] platform/chrome: cros_ec: Report EC panic as uevent
    https://git.kernel.org/chrome-platform/c/2cbf475a04b2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH v4] platform/chrome: cros_ec: Report EC panic as uevent
  2023-05-09 23:26           ` [PATCH v4] " Rob Barnes
  2023-05-15  5:20             ` patchwork-bot+chrome-platform
@ 2023-05-19  2:00             ` patchwork-bot+chrome-platform
  1 sibling, 0 replies; 10+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-05-19  2:00 UTC (permalink / raw)
  To: Rob Barnes; +Cc: chrome-platform, dnojiri, tzungbi, pmalani

Hello:

This patch was applied to chrome-platform/linux.git (for-next)
by Tzung-Bi Shih <tzungbi@kernel.org>:

On Tue,  9 May 2023 23:26:24 +0000 you wrote:
> Create a uevent when an EC panic is detected. This will allow udev rules
> to trigger when a panic occurs. For example, a udev rule could be added to
> capture an EC coredump. This approach avoids the need to stuff all the
> processing into the driver.
> 
> Signed-off-by: Rob Barnes <robbarnes@google.com>
> Reviewed-by: Prashant Malani <pmalani@chromium.org>
> 
> [...]

Here is the summary with links:
  - [v4] platform/chrome: cros_ec: Report EC panic as uevent
    https://git.kernel.org/chrome-platform/c/2cbf475a04b2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2023-05-19  2:00 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-20 17:46 [PATCH] platform/chrome: cros_ec: Report EC panic as uevent Rob Barnes
2023-04-20 21:08 ` Prashant Malani
2023-04-24 16:44   ` Rob Barnes
2023-05-09 22:22     ` [PATCH v2] " Rob Barnes
2023-05-09 22:59       ` Prashant Malani
2023-05-09 23:19         ` [PATCH v3] " Rob Barnes
2023-05-09 23:25           ` Prashant Malani
2023-05-09 23:26           ` [PATCH v4] " Rob Barnes
2023-05-15  5:20             ` patchwork-bot+chrome-platform
2023-05-19  2:00             ` patchwork-bot+chrome-platform

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).