From: Tim Van Patten <timvp@google.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: rrangel@chromium.org, robbarnes@google.com,
Tim Van Patten <timvp@google.com>,
Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev
Subject: [PATCH v2] platform/chrome: cros_ec: Send host event for prepare/complete
Date: Wed, 6 Jul 2022 20:51:39 -0600 [thread overview]
Message-ID: <20220706205136.v2.1.Ic7a7c81f880ab31533652e0928aa6e687bb268b5@changeid> (raw)
Update cros_ec_lpc_pm_ops to call cros_ec_lpc_suspend() during PM
.prepare() and cros_ec_lpc_resume() during .complete. This allows the
EC to log entry/exit of AP's suspend/resume more accurately.
Signed-off-by: Tim Van Patten <timvp@google.com>
---
Changes in v2:
- Include cros_ec_resume() return value in dev_info() output.
- Guard setting .prepare/.complete with #ifdef CONFIG_PM_SLEEP.
drivers/platform/chrome/cros_ec_lpc.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
index 7677ab3c0ead9..ce49fbc4ed2e1 100644
--- a/drivers/platform/chrome/cros_ec_lpc.c
+++ b/drivers/platform/chrome/cros_ec_lpc.c
@@ -534,19 +534,27 @@ static int cros_ec_lpc_suspend(struct device *dev)
{
struct cros_ec_device *ec_dev = dev_get_drvdata(dev);
+ dev_info(dev, "Prepare EC suspend\n");
+
return cros_ec_suspend(ec_dev);
}
-static int cros_ec_lpc_resume(struct device *dev)
+static void cros_ec_lpc_resume(struct device *dev)
{
struct cros_ec_device *ec_dev = dev_get_drvdata(dev);
+ int ret;
+
+ ret = cros_ec_resume(ec_dev);
- return cros_ec_resume(ec_dev);
+ dev_info(dev, "EC resume completed: ret = %d\n", ret);
}
#endif
static const struct dev_pm_ops cros_ec_lpc_pm_ops = {
- SET_LATE_SYSTEM_SLEEP_PM_OPS(cros_ec_lpc_suspend, cros_ec_lpc_resume)
+#ifdef CONFIG_PM_SLEEP
+ .prepare = cros_ec_lpc_suspend,
+ .complete = cros_ec_lpc_resume
+#endif
};
static struct platform_driver cros_ec_lpc_driver = {
--
2.37.0.rc0.161.g10f37bed90-goog
next reply other threads:[~2022-07-07 2:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 2:51 Tim Van Patten [this message]
2022-07-13 2:58 ` [PATCH v2] platform/chrome: cros_ec: Send host event for prepare/complete Tzung-Bi Shih
[not found] ` <CANkg5eyehcECGeDHBEsxR=iOoyMwzkcpvX+oRxy7PJPYLD=VuQ@mail.gmail.com>
2022-07-14 2:22 ` Tzung-Bi Shih
2022-07-14 18:19 ` Tim Van Patten
2022-07-14 18:34 ` Prashant Malani
2022-07-14 20:55 ` Tim Van Patten
2022-07-14 21:51 ` Prashant Malani
2022-07-14 22:17 ` Tim Van Patten
2022-07-14 23:33 ` Prashant Malani
2022-08-01 23:33 ` Tim Van Patten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220706205136.v2.1.Ic7a7c81f880ab31533652e0928aa6e687bb268b5@changeid \
--to=timvp@google.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robbarnes@google.com \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).