From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Benson Leung <bleung@chromium.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Vladimir Zapolskiy <vz@mleia.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Heiko Stuebner <heiko@sntech.de>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
Paul Walmsley <paul.walmsley@sifive.com>,
Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>,
Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Sean Anderson <sean.anderson@seco.com>,
Michal Simek <michal.simek@xilinx.com>
Cc: kernel@pengutronix.de, linux-pwm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
linux-rpi-kernel@lists.infradead.org,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
linux-mediatek@lists.infradead.org,
linux-rockchip@lists.infradead.org,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-samsung-soc@vger.kernel.org,
linux-riscv@lists.infradead.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org
Subject: [PATCH 00/30] pwm: Convert to platform remove callback returning void
Date: Fri, 3 Mar 2023 19:54:15 +0100 [thread overview]
Message-ID: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> (raw)
Hello,
this patch series adapts the platform drivers below drivers/pwm to use
the .remove_new() callback. Compared to the traditional .remove()
callback .remove_new() returns no value. This is a good thing because
the driver core doesn't (and cannot) cope for errors during remove. The
only effect of a non-zero return value in .remove() is that the driver
core emits a warning. The device is removed anyhow and an early return
from .remove() usually yields a resource leak.
By changing the remove callback to return void driver authors cannot
reasonably assume any more that there is some kind of cleanup later.
All drivers touched here returned zero unconditionally in their remove
callback, so they could all be converted trivially to .remove_new().
Note that this series depends on commit 5c5a7680e67b ("platform: Provide
a remove callback that returns no value") that is already in Linus' tree
but not yet included in a tagged version.
Best regards
Uwe
Uwe Kleine-König (30):
pwm: atmel-hlcdc: Convert to platform remove callback returning void
pwm: atmel-tcb: Convert to platform remove callback returning void
pwm: atmel: Convert to platform remove callback returning void
pwm: bcm-iproc: Convert to platform remove callback returning void
pwm: bcm2835: Convert to platform remove callback returning void
pwm: berlin: Convert to platform remove callback returning void
pwm: brcmstb: Convert to platform remove callback returning void
pwm: clk: Convert to platform remove callback returning void
pwm: cros-ec: Convert to platform remove callback returning void
pwm: hibvt: Convert to platform remove callback returning void
pwm: img: Convert to platform remove callback returning void
pwm: imx-tpm: Convert to platform remove callback returning void
pwm: lpc18xx-sct: Convert to platform remove callback returning void
pwm: lpss-platform: Convert to platform remove callback returning void
pwm: mtk-disp: Convert to platform remove callback returning void
pwm: omap-dmtimer: Convert to platform remove callback returning void
pwm: rcar: Convert to platform remove callback returning void
pwm: rockchip: Convert to platform remove callback returning void
pwm: samsung: Convert to platform remove callback returning void
pwm: sifive: Convert to platform remove callback returning void
pwm: spear: Convert to platform remove callback returning void
pwm: sprd: Convert to platform remove callback returning void
pwm: sti: Convert to platform remove callback returning void
pwm: stm32: Convert to platform remove callback returning void
pwm: sun4i: Convert to platform remove callback returning void
pwm: tegra: Convert to platform remove callback returning void
pwm: tiecap: Convert to platform remove callback returning void
pwm: tiehrpwm: Convert to platform remove callback returning void
pwm: vt8500: Convert to platform remove callback returning void
pwm: xilinx: Convert to platform remove callback returning void
drivers/pwm/pwm-atmel-hlcdc.c | 6 ++----
drivers/pwm/pwm-atmel-tcb.c | 6 ++----
drivers/pwm/pwm-atmel.c | 6 ++----
drivers/pwm/pwm-bcm-iproc.c | 6 ++----
drivers/pwm/pwm-bcm2835.c | 6 ++----
drivers/pwm/pwm-berlin.c | 6 ++----
drivers/pwm/pwm-brcmstb.c | 6 ++----
drivers/pwm/pwm-clk.c | 6 ++----
drivers/pwm/pwm-cros-ec.c | 6 ++----
drivers/pwm/pwm-hibvt.c | 6 ++----
drivers/pwm/pwm-img.c | 6 ++----
drivers/pwm/pwm-imx-tpm.c | 6 ++----
drivers/pwm/pwm-lpc18xx-sct.c | 6 ++----
drivers/pwm/pwm-lpss-platform.c | 5 ++---
drivers/pwm/pwm-mtk-disp.c | 6 ++----
drivers/pwm/pwm-omap-dmtimer.c | 6 ++----
drivers/pwm/pwm-rcar.c | 6 ++----
drivers/pwm/pwm-rockchip.c | 6 ++----
drivers/pwm/pwm-samsung.c | 6 ++----
drivers/pwm/pwm-sifive.c | 6 ++----
drivers/pwm/pwm-spear.c | 6 ++----
drivers/pwm/pwm-sprd.c | 6 ++----
drivers/pwm/pwm-sti.c | 6 ++----
drivers/pwm/pwm-stm32.c | 6 ++----
drivers/pwm/pwm-sun4i.c | 6 ++----
drivers/pwm/pwm-tegra.c | 6 ++----
drivers/pwm/pwm-tiecap.c | 6 ++----
drivers/pwm/pwm-tiehrpwm.c | 6 ++----
drivers/pwm/pwm-vt8500.c | 6 ++----
drivers/pwm/pwm-xilinx.c | 5 ++---
30 files changed, 60 insertions(+), 118 deletions(-)
base-commit: 2eb29d59ddf02e39774abfb60b2030b0b7e27c1f
--
2.39.1
next reply other threads:[~2023-03-03 18:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 18:54 Uwe Kleine-König [this message]
2023-03-03 18:54 ` [PATCH 09/30] pwm: cros-ec: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-03 19:14 ` Guenter Roeck
2023-05-08 3:45 ` [PATCH 00/30] pwm: " patchwork-bot+chrome-platform
2023-05-08 3:56 ` patchwork-bot+chrome-platform
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303185445.2112695-1-u.kleine-koenig@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alexandre.belloni@bootlin.com \
--cc=alexandre.torgue@foss.st.com \
--cc=alim.akhtar@samsung.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=claudiu.beznea@microchip.com \
--cc=f.fainelli@gmail.com \
--cc=fabrice.gasnier@foss.st.com \
--cc=festevam@gmail.com \
--cc=groeck@chromium.org \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-tegra@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=michal.simek@xilinx.com \
--cc=nicolas.ferre@microchip.com \
--cc=orsonzhai@gmail.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=samuel@sholland.org \
--cc=sbranden@broadcom.com \
--cc=sean.anderson@seco.com \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vz@mleia.com \
--cc=wens@csie.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).