From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [85.220.165.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EAD2D1848 for ; Mon, 17 Apr 2023 06:02:17 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1poHwH-0002G1-KI; Mon, 17 Apr 2023 08:02:09 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1poHwE-00Bnsb-Cs; Mon, 17 Apr 2023 08:02:06 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1poHwD-00Dolu-4U; Mon, 17 Apr 2023 08:02:05 +0200 Date: Mon, 17 Apr 2023 08:02:03 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Mauro Carvalho Chehab Cc: linux-aspeed@lists.ozlabs.org, Alim Akhtar , Hans Verkuil , Benson Leung , Ajye Huang , Rory Liu , Scott Chao , Neil Armstrong , Kevin Hilman , Marek Szyprowski , Ettore Chimenti , Alain Volmat , Maxime Coquelin , Alexandre Torgue , Sean Young , Sakari Ailus , Ricardo Ribalda , Laurent Pinchart , Yang Yingliang , Thierry Reding , Jonathan Hunter , Antti Palosaari , Michael Tretter , Ming Qian , Zhou Peng , Eddie James , Joel Stanley , Eugen Hristev , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Maxime Ripard , Philipp Zabel , Bin Liu , Matthias Brugger , Minghsiu Tsai , Houlong Wei , Andrew-CT Chen , Moudy Ho , Qiheng Lin , Tiffany Lin , Yunfei Dong , Dmitry Osipenko , Xavier Roumegue , Mirela Rabulea , Shawn Guo , Sascha Hauer , Rui Miguel Silva , Robert Foss , Todor Tomov , Andy Gross , Bjorn Andersson , Stanimir Varbanov , Vikash Garodia , Niklas =?utf-8?Q?S=C3=B6derlund?= , Fabrizio Castro , Kieran Bingham , Mikhail Ulyanov , Jacopo Mondi , Lad Prabhakar , Nathan Chancellor , Yang Li , Dan Carpenter , Jacob Chen , Ezequiel Garcia , Heiko Stuebner , Dafna Hirschfeld , Krzysztof Kozlowski , Colin Ian King , Sylwester Nawrocki , Sylwester Nawrocki , =?utf-8?Q?=C5=81ukasz?= Stelmach , Andrzej Pietrasiewicz , Jacek Anaszewski , Andrzej Hajda , Fabien Dessenne , Patrice Chotard , Hugues Fruchet , Jean-Christophe Trotin , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Yong Deng , Paul Kocialkowski , Christophe JAILLET , "Lad, Prabhakar" , Benoit Parrot , Hyun Kwon , Michal Simek , ye xingchen , Eduardo Valentin , Sean Wang , "Daniel W. S. Almeida" , Shuah Khan , Daniel Almeida , Hans Verkuil , Guenter Roeck , Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, Jerome Brunet , chrome-platform@lists.linux.dev, linux-samsung-soc@vger.kernel.org, Konrad Dybcio , openbmc@lists.ozlabs.org, Kieran Bingham , linux-rockchip@lists.infradead.org, NXP Linux Team , linux-sunxi@lists.linux.dev, linux-media@vger.kernel.org, Martin Blumenstingl , linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-tegra@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, AngeloGioacchino Del Regno , Andrew Jeffery , linux-renesas-soc@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 000/117] media: Convert to platform remove callback returning void Message-ID: <20230417060203.le3izz56wt73si6k@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ogmoi7vlr4vxdkq5" Content-Disposition: inline In-Reply-To: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: chrome-platform@lists.linux.dev --ogmoi7vlr4vxdkq5 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Mauro On Sun, Mar 26, 2023 at 04:30:25PM +0200, Uwe Kleine-K=F6nig wrote: > Hello, >=20 > this series adapts the platform drivers below drivers/pci to use the copy&paste failure here: s/pci/media/ of course. > .remove_new() callback. Compared to the traditional .remove() callback > .remove_new() returns no value. This is a good thing because the driver c= ore > doesn't (and cannot) cope for errors during remove. The only effect of a > non-zero return value in .remove() is that the driver core emits a warnin= g. The > device is removed anyhow and an early return from .remove() usually yield= s a > resource leak. >=20 > By changing the remove callback to return void driver authors cannot > reasonably assume any more that there is some kind of cleanup later. >=20 > Only three drivers needed some preparation first to make sure they > return 0 unconditionally in their remove callback. Then all drivers > could be trivially converted without side effects to .remove_new(). >=20 > The changes to the individual drivers are all orthogonal. If I need to > resend some patches because of some review feedback, I'd like to only > send the patches that actually needed changes, so please pick up the > remaining patches that don't need changing to reduce the amount of mail. I didn't hear anything back about application of this series. Is there a blocker somewhere? Apart from the three preparatory patches that are a precondition to the conversion of the respective drivers, the patches are all pairwise orthogonal. So from my POV the best would be to apply all patches that still apply (which might be all), I will care for the fallout later then. Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --ogmoi7vlr4vxdkq5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmQ84NoACgkQj4D7WH0S /k65OwgAkM/14eqkcxTg0/453d2uwhPt/jiDru0C14NvpnN4AFU0sa+yzp1GfYRO WfxjudHvw/OXq+eolRu8PrqJIpLHvQhOyjblYLXPqTB8RvdJSXI2Q1ZJjozYjCNJ WeBerHqAXGOnxd+2kbfCs2VZWYgmJpj1VCXeRYekMB7Kv1tmfXNXetaHIH7Rypw1 +Si1nhZN4Sk68bdXU+RaQc6UP5/E0VohPVWnSB1tsTQVL4sogBkjfDl4tueHEZxj 959kirh12hfcFcqtz1mQ1u7V1dIc136PR+Kg/2b+GNaFbe/Zdsno5HbnbQl+NwL/ GWFmd+GksqXkwA3k1tkqVdOFEPO4cQ== =K38Q -----END PGP SIGNATURE----- --ogmoi7vlr4vxdkq5--