From: Krzysztof Kozlowski <krzk@kernel.org>
To: Doug Anderson <dianders@chromium.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Stephen Boyd <swboyd@chromium.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
patches@lists.linux.dev, chrome-platform@lists.linux.dev,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Benson Leung <bleung@chromium.org>,
Guenter Roeck <groeck@chromium.org>,
Hsin-Yi Wang <hsinyi@chromium.org>,
"Joseph S. Barrera III" <joebar@chromium.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: google,cros-ec-keyb: Introduce switches only compatible
Date: Tue, 3 May 2022 17:54:30 +0200 [thread overview]
Message-ID: <cd1da207-1f15-f3f1-7190-56b983e75024@kernel.org> (raw)
In-Reply-To: <CAD=FV=UEBi9dctmhaAi1z+c+Sj5gtcRrc3FRW294T55dTiAidQ@mail.gmail.com>
On 03/05/2022 17:46, Doug Anderson wrote:
> Hi,
>
> On Tue, May 3, 2022 at 8:42 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 03/05/2022 06:22, Stephen Boyd wrote:
>>> If the ChromeOS board is a detachable, this cros-ec-keyb device won't
>>> have a matrix keyboard but it may have some button switches, e.g. volume
>>> buttons and power buttons. The driver still registers a keyboard though
>>> and that leads to userspace confusion around where the keyboard is.
>>
>> (...)
>>
>>>
>>> +if:
>>> + properties:
>>> + compatible:
>>> + contains:
>>> + const: google,cros-ec-keyb
>>> +then:
>>> + allOf:
>>> + - $ref: "/schemas/input/matrix-keymap.yaml#"
>>> + required:
>>> + - keypad,num-rows
>>> + - keypad,num-columns
>>> + - linux,keymap
>>
>> else:
>> properties:
>> function-row-phsymap: false
>> google,needs-ghost-filter: false
>>
>> Because these are not valid for the non-matrix-keyboard case, right?
>
> Isn't that implicit because this file has `unevaluatedProperties: false` ?
But they are evaluated here, aren't they?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-05-03 15:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 4:22 [PATCH v3 0/2] Input: cros-ec-keyb: Better matrixless support Stephen Boyd
2022-05-03 4:22 ` [PATCH v3 1/2] dt-bindings: google,cros-ec-keyb: Introduce switches only compatible Stephen Boyd
2022-05-03 15:09 ` Doug Anderson
2022-05-03 19:40 ` Stephen Boyd
2022-05-03 15:42 ` Krzysztof Kozlowski
2022-05-03 15:46 ` Doug Anderson
2022-05-03 15:54 ` Krzysztof Kozlowski [this message]
2022-05-03 16:14 ` Doug Anderson
2022-05-03 18:45 ` Krzysztof Kozlowski
2022-05-03 19:00 ` Stephen Boyd
2022-05-03 19:02 ` Krzysztof Kozlowski
2022-05-03 4:22 ` [PATCH v3 2/2] Input: cros-ec-keyb - skip keyboard registration w/o cros-ec-keyb compatible Stephen Boyd
2022-05-03 15:09 ` Doug Anderson
2022-05-03 19:43 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd1da207-1f15-f3f1-7190-56b983e75024@kernel.org \
--to=krzk@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=groeck@chromium.org \
--cc=hsinyi@chromium.org \
--cc=joebar@chromium.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).