From: "Pavel Machek" <pavel@denx.de>
To: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Cc: cip-dev@lists.cip-project.org,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Pavel Machek <pavel@denx.de>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [cip-dev] [PATCH 4.19.y-cip] dt-bindings: pci: rcar-pci-ep: Document missing interrupts property
Date: Mon, 4 Jan 2021 13:22:37 +0100 [thread overview]
Message-ID: <20210104122237.GA19121@duo.ucw.cz> (raw)
In-Reply-To: <20210104095848.7111-1-prabhakar.mahadev-lad.rj@bp.renesas.com>
[-- Attachment #1.1: Type: text/plain, Size: 2005 bytes --]
Hi!
> From: Geert Uytterhoeven <geert+renesas@glider.be>
>
> commit f3c6c120614cfb02827ee7bbe6c4240847cc5f12 upstream.
>
> The R-Car PCIe controller does not use interrupts when configured
> for endpoint mode, hence the bindings do not document the interrupts
> property. However, all DTS files provide interrupts properties, and
> thus fail to validate.
>
> Fix this by documenting the interrupts property.
Looks good to me. I can apply it to 4.19-cip if there are no other
comments.
Best regards,
Pavel
> --- a/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> @@ -32,6 +32,10 @@ properties:
> - const: memory2
> - const: memory3
>
> + interrupts:
> + minItems: 3
> + maxItems: 3
> +
> power-domains:
> maxItems: 1
>
> @@ -53,6 +57,7 @@ required:
> - compatible
> - reg
> - reg-names
> + - interrupts
> - resets
> - power-domains
> - clocks
> @@ -62,6 +67,7 @@ required:
> examples:
> - |
> #include <dt-bindings/clock/r8a774c0-cpg-mssr.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/r8a774c0-sysc.h>
>
> pcie0_ep: pcie-ep@fe000000 {
> @@ -73,6 +79,9 @@ examples:
> <0x30000000 0x8000000>,
> <0x38000000 0x8000000>;
> reg-names = "apb-base", "memory0", "memory1", "memory2", "memory3";
> + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
> resets = <&cpg 319>;
> power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
> clocks = <&cpg CPG_MOD 319>;
> --
> 2.17.1
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5993): https://lists.cip-project.org/g/cip-dev/message/5993
Mute This Topic: https://lists.cip-project.org/mt/79420973/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2021-01-04 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 9:58 [cip-dev] [PATCH 4.19.y-cip] dt-bindings: pci: rcar-pci-ep: Document missing interrupts property Lad Prabhakar
2021-01-04 12:22 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104122237.GA19121@duo.ucw.cz \
--to=pavel@denx.de \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).