Re: [cip-dev] [PATCH 4.19.y-cip] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC

From: "Pavel Machek" <pavel@denx.de>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Pavel Machek <pavel@denx.de>,
	"cip-dev@lists.cip-project.org" <cip-dev@lists.cip-project.org>,
	Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [cip-dev] [PATCH 4.19.y-cip] drm: rcar-du: Fix crash when using LVDS1 clock for CRTC
Date: Tue, 13 Apr 2021 13:21:58 +0200	[thread overview]
Message-ID: <20210413112158.GA13447@duo.ucw.cz> (raw)
In-Reply-To: <OS0PR01MB592230BE36B888893653B0D7864F9@OS0PR01MB5922.jpnprd01.prod.outlook.com>

[-- Attachment #1.1: Type: text/plain, Size: 1355 bytes --]

Hi!

> > > On D3 and E3 platforms, the LVDS encoder includes a PLL that can
> > > generate a clock for the corresponding CRTC, used even when the CRTC
> > > output to a non-LVDS port. This mechanism is supported by the driver,
> > > but the implementation is broken in dual-link LVDS mode. In that case,
> > > the LVDS1 drm_encoder is skipped, which causes a crash when trying to
> > > access its bridge later on.
> > >
> > > Fix this by storing bridge pointers internally instead of retrieving
> > > them from the encoder. The rcar_du_device encoders field isn't used
> > > anymore and can be dropped.
> > 
> > The patch looks okay to me. I'll test it and can apply it if it works
> > okay.
> > 
> > But I don't believe it is in our 5.10, so I'd like it to be submitted for
> > 5.10, too.

Applied and pushed out.

> > Or just tell me it is okay and I'll apply it there, too.
> 
> Please apply  to 5.10-cip as well, since it is present in 5.10 stable.

Aha, ok, that changs things. (I checked our trees but not stable).

In such case, nothing needs to be done at the moment, and it is easier
to wait till we merge that through the stable tree.

Best regards,
								Pavel

-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 428 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6368): https://lists.cip-project.org/g/cip-dev/message/6368
Mute This Topic: https://lists.cip-project.org/mt/82032629/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/4520388/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-