cip-dev.lists.cip-project.org archive mirror
 help / color / mirror / Atom feed
From: Gylstorff Quirin <quirin.gylstorff@siemens.com>
To: Jan Kiszka <jan.kiszka@web.de>,
	cip-dev@lists.cip-project.org, dinesh.kumar@toshiba-tsip.com
Subject: Re: [cip-dev][isar-cip-core][PATCH 2/2] kas/opt/efibootguard: Move setting of IMAGE_TYPE
Date: Wed, 29 Sep 2021 09:53:22 +0200	[thread overview]
Message-ID: <495fd44a-3d4c-e83a-0389-7d8516962000@siemens.com> (raw)
Message-ID: <20210929075322.fW54FTVR-9jCF_EWyMEeZNPx971g1va1relfH4IGp-0@z> (raw)
In-Reply-To: <15ad275a-a9f4-9e8e-149d-e09c17a196c4@web.de>



On 9/29/21 12:09 AM, Jan Kiszka wrote:
> On 28.09.21 20:49, Quirin Gylstorff wrote:
>> From: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>>
>> This seperates the image type from the boot loader.
>>
>> Signed-off-by: Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> ---
>>   kas/opt/efibootguard.yml |  1 -
>>   kas/opt/wic-img.yml      | 19 +++++++++++++++++++
>>   2 files changed, 19 insertions(+), 1 deletion(-)
>>   create mode 100644 kas/opt/wic-img.yml
>>
>> diff --git a/kas/opt/efibootguard.yml b/kas/opt/efibootguard.yml
>> index 705a76d..4e8be69 100644
>> --- a/kas/opt/efibootguard.yml
>> +++ b/kas/opt/efibootguard.yml
>> @@ -23,6 +23,5 @@ local_conf_header:
>>     efibootguard-wic: |
>>       WDOG_TIMEOUT ?= "60"
>>       WICVARS += "WDOG_TIMEOUT"
>> -    IMAGE_TYPE ?= "wic-img"
>>       WKS_FILE ?= "${MACHINE}-${SWUPDATE_BOOTLOADER}.wks"
>>
>> diff --git a/kas/opt/wic-img.yml b/kas/opt/wic-img.yml
>> new file mode 100644
>> index 0000000..2b02b42
>> --- /dev/null
>> +++ b/kas/opt/wic-img.yml
>> @@ -0,0 +1,19 @@
>> +#
>> +# CIP Core, generic profile
>> +#
>> +# Copyright (c) Siemens AG, 2021
>> +#
>> +# Authors:
>> +#  Quirin Gylstorff <quirin.gylstorff@siemens.com>
>> +#
>> +# SPDX-License-Identifier: MIT
>> +#
>> +# This kas file set the IMAGE_TYPE to wic-img
>> +# The device specific WKS_FILE needs to be set seperately.
>> +
>> +header:
>> +  version: 10
>> +
>> +local_conf_header:
>> +  image-type: |
>> +    IMAGE_TYPE = "wic-img"
>>
> 
> What's the purpose of this file? When should a user specify this option?
> I think we already have too many option files and rather need to reduce
> them than adding more.

My idea was to split the selection of efibootguard from the usage of 
wic-img so that we can generate other image formats together with 
efibootguard - in hindsight this is not necessary -  you can skip this 
patch as patch 1 of this set solves the issue alone.


Quirin
> 
> Jan
> 
> PS: Something is currently off with archiving on lore.kernel.org.
> Messages from this thread but also others appear twice there:
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fcip-dev%2F20210928184946.GHmZQFBkA_wEzR1iQiB_04frBV52DnaYGHOSYtAdjok%40z%2FT%2F%23t&amp;data=04%7C01%7C6549bcd2-981c-4c06-8e1b-b5c6cc3441b4%40ad011.siemens.com%7Cc59cf4afa01c4ef24ff208d982ccb240%7C38ae3bcd95794fd4addab42e1495d55a%7C1%7C0%7C637684637933939193%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=kNC4hyC3dM8p%2BUVHMpaGjs7O%2BmC76P4UKCXcIHMStO8%3D&amp;reserved=0
> 



  reply	other threads:[~2021-09-29  7:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-28 18:49 [cip-dev][isar-cip-core][PATCH 0/2] Fix for issue gitlab #14 Quirin Gylstorff
2021-09-28 18:49 ` Q. Gylstorff
2021-09-28 18:49 ` [cip-dev][isar-cip-core][PATCH 1/2] kas/opt/swupdate: Change assignment of IMAGE_TYPE and WKS_FILE Q. Gylstorff
2021-09-28 18:49   ` Quirin Gylstorff
2021-10-04  9:28     ` Jan Kiszka
2021-10-04  9:28       ` Jan Kiszka
2021-10-04 10:37       ` Jan Kiszka
2021-10-04 10:37         ` Jan Kiszka
2021-10-04 12:46         ` Gylstorff Quirin
2021-10-04 12:46           ` Quirin Gylstorff
2021-10-04 13:27         ` [PATCH v2] " Q. Gylstorff
2021-10-04 13:27           ` [cip-dev] " Quirin Gylstorff
2021-10-04 13:44           ` Jan Kiszka
2021-10-04 13:44             ` [cip-dev] " Jan Kiszka
2021-09-28 18:49 ` [cip-dev][isar-cip-core][PATCH 2/2] kas/opt/efibootguard: Move setting of IMAGE_TYPE Q. Gylstorff
2021-09-28 18:49   ` Quirin Gylstorff
2021-09-28 22:09     ` Jan Kiszka
2021-09-29  7:53       ` Quirin Gylstorff [this message]
2021-09-29  7:53         ` Gylstorff Quirin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=495fd44a-3d4c-e83a-0389-7d8516962000@siemens.com \
    --to=quirin.gylstorff@siemens.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=dinesh.kumar@toshiba-tsip.com \
    --cc=jan.kiszka@web.de \
    --subject='Re: [cip-dev][isar-cip-core][PATCH 2/2] kas/opt/efibootguard: Move setting of IMAGE_TYPE' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).