CIP-dev Archive on lore.kernel.org
 help / color / Atom feed
From: "Chen-Yu Tsai (Moxa)" <wens@csie.org>
To: Pavel Machek <pavel@denx.de>
Cc: "Nobuhiro Iwamatsu" <nobuhiro1.iwamatsu@toshiba.co.jp>,
	cip-dev@lists.cip-project.org,
	"Johnson CH Chen (陳昭勳)" <JohnsonCH.Chen@moxa.com>
Subject: Re: [cip-dev] [PATCH RESEND 4.4.y-cip 03/15] PM / OPP: Add {opp-microvolt|opp-microamp}-<name> binding
Date: Thu, 4 Jun 2020 17:03:01 +0800
Message-ID: <CAGb2v67JzgA3KkpkEirTLNs2yTaZho3rBvHSJepBUCTL0KaCxw@mail.gmail.com> (raw)
In-Reply-To: <20200604084601.GA18541@duo.ucw.cz>


[-- Attachment #1: Type: text/plain, Size: 3174 bytes --]

On Thu, Jun 4, 2020 at 4:46 PM Pavel Machek <pavel@denx.de> wrote:
>
> Hi!
>
> > From: Viresh Kumar <viresh.kumar@linaro.org>
> >
> > commit ffdb8cc7a27c89175e541e68e2a73f1f63ab8c6b upstream.
> >
> > Depending on the version of hardware or its properties, which are only
> > known at runtime, various properties of the OPP can change. For example,
> > an OPP with frequency 1.2 GHz, may have different voltage/current
> > requirements based on the version of the hardware it is running on.
> >
> > In order to not replicate the same OPP tables for varying values of all
> > such fields, this commit introduces the concept of opp-property-<name>.
> > The <name> can be chosen by the platform at runtime, and OPPs will be
> > initialized depending on that name string. Currently support is extended
> > for the following properties:
> > - opp-microvolt-<name>
> > - opp-microamp-<name>
>
> That's really quite "interesting" design. I wondered if devicetree
> people are okay with that.
>
> > If the name string isn't provided by the platform, or if it is provided
> > but doesn't match the properties present in the OPP node, we will fall
> > back to the original properties without the -<name> string, if they are
> > available.
> >
> > Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Signed-off-by: Chen-Yu Tsai (Moxa) <wens@csie.org>
>
> But, interestingly, their review tag is missing...?
>
> As this is mainline, I don't think we need to do anything here. I
> wonder how this kind of "wildcard" property names will play with new
> yml format or automatic device tree checks.

The new bindings format can take regex for node names and property
names, so that itself shouldn't be an issue. The name itself is
likely hardware specific so there's not much the automatic checker
can do either.

ChenYu


> Best regards,
>                                                                 Pavel
>
> > +++ b/Documentation/devicetree/bindings/opp/opp.txt
> > @@ -100,6 +100,14 @@ Optional properties:
> >    Entries for multiple regulators must be present in the same order as
> >    regulators are specified in device's DT node.
> >
> > +- opp-microvolt-<name>: Named opp-microvolt property. This is exactly similar to
> > +  the above opp-microvolt property, but allows multiple voltage ranges to be
> > +  provided for the same OPP. At runtime, the platform can pick a <name> and
> > +  matching opp-microvolt-<name> property will be enabled for all OPPs. If the
> > +  platform doesn't pick a specific <name> or the <name> doesn't match with any
> > +  opp-microvolt-<name> properties, then opp-microvolt property shall be used, if
> > +  present.
> > +
> >  - opp-microamp: The maximum current drawn by the device in microamperes
> >    considering system specific parameters (such as transients, process, aging,
> >    maximum operating temperature range etc.) as necessary. This may be used to
>
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[-- Attachment #2: Type: text/plain, Size: 419 bytes --]

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.

View/Reply Online (#4699): https://lists.cip-project.org/g/cip-dev/message/4699
Mute This Topic: https://lists.cip-project.org/mt/74665629/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy  [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

  reply index

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04  4:17 [cip-dev] [PATCH RESEND 4.4.y-cip 00/15] PM / OPP v2 & cpufreq backports part 1 Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 01/15] PM / OPP: Add debugfs support Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 02/15] PM / OPP: Add "opp-supported-hw" binding Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 03/15] PM / OPP: Add {opp-microvolt|opp-microamp}-<name> binding Chen-Yu Tsai (Moxa)
2020-06-04  8:46   ` Pavel Machek
2020-06-04  9:03     ` Chen-Yu Tsai (Moxa) [this message]
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 04/15] PM / OPP: Remove 'operating-points-names' binding Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 05/15] PM / OPP: Rename OPP nodes as opp@<opp-hz> Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 06/15] PM / OPP: Add missing doc comments Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 07/15] PM / OPP: Parse 'opp-supported-hw' binding Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 08/15] PM / OPP: Parse 'opp-<prop>-<name>' bindings Chen-Yu Tsai (Moxa)
2020-06-04  8:56   ` Pavel Machek
2020-06-04  9:03     ` Pavel Machek
2020-06-04  9:21       ` Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 09/15] PM / OPP: Fix parsing of opp-microvolt and opp-microamp properties Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 10/15] PM / OPP: Set cpu_dev->id in cpumask first Chen-Yu Tsai (Moxa)
2020-06-04  6:42   ` Nobuhiro Iwamatsu
2020-06-04  6:54     ` Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 11/15] PM / OPP: Use snprintf() instead of sprintf() Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 12/15] devicetree: bindings: Add optional dynamic-power-coefficient property Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 13/15] cpufreq-dt: Supply power coefficient when registering cooling devices Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 14/15] cpufreq-dt: fix handling regulator_get_voltage() result Chen-Yu Tsai (Moxa)
2020-06-04  4:17 ` [cip-dev] [PATCH RESEND 4.4.y-cip 15/15] cpufreq: cpufreq-dt: avoid uninitialized variable warnings: Chen-Yu Tsai (Moxa)
2020-06-04  6:55 ` [cip-dev] [PATCH RESEND 4.4.y-cip 00/15] PM / OPP v2 & cpufreq backports part 1 Nobuhiro Iwamatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGb2v67JzgA3KkpkEirTLNs2yTaZho3rBvHSJepBUCTL0KaCxw@mail.gmail.com \
    --to=wens@csie.org \
    --cc=JohnsonCH.Chen@moxa.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=nobuhiro1.iwamatsu@toshiba.co.jp \
    --cc=pavel@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

CIP-dev Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cip-dev/0 cip-dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cip-dev cip-dev/ https://lore.kernel.org/cip-dev \
		cip-dev@lists.cip-project.org
	public-inbox-index cip-dev

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.cip-project.lists.cip-dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git