[cip-dev] Xiling MPSOC -- was Re: CIP IRC weekly meeting today

From: masashi.kudo@cybertrust.co.jp (masashi.kudo at cybertrust.co.jp)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] Xiling MPSOC -- was Re: CIP IRC weekly meeting today
Date: Tue, 1 Oct 2019 12:41:25 +0000	[thread overview]
Message-ID: <OSBPR01MB24230274FED8FF03C87AB513A09D0@OSBPR01MB2423.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20191001091920.GA2353@amd>

Pavel-san,

Thanks very much for your quick review and suggestions for the next steps!
Those are very helpful for us, and should be the basis of the general guideline to contribute such code.
Anyway, I will wait for the official approval from the kernel team to move things forward.

SZ-san,

Please let me know if there is anything else I should prepare.

Best regards,
--
M. Kudo

-----Original Message-----
From: Pavel Machek <pavel@denx.de> 
Sent: Tuesday, October 1, 2019 6:19 PM
To: Pavel Machek <pavel@denx.de>
Cc: ??????CTJ? <masashi.kudo@cybertrust.co.jp>; SZ.Lin at moxa.com; cip-dev at lists.cip-project.org
Subject: Re: Xiling MPSOC -- was Re: [cip-dev] CIP IRC weekly meeting today

Hi!

> > The current work which contains all CIP kernel files is compiled into a tar ball, and I uploaded the ball under the following repository.
> > https://github.com/masashi910/tmp-cip-xilinx-mpsoc/
> 
> Thanks, let me take a look.
> 
> For the record, way to get the files is
...
> I diffed that against v4.19.56; which unfortunately produced unclean 
> diff as it now also includes the -cip changes. I quickly reviewed and 
> hand-edited the diff.
> 
> I notice this includes staging drivers. 
> 
> +obj-$(CONFIG_XILINX_APF)       += apf/
> +obj-$(CONFIG_XILINX_FCLK)      += fclk/
> 
> I believe you should get those reviewed and moved outside of staging 
> before attempting to backport them.
> 
> Otherwise I don't see anything too scary.

>From my point of view, I don't see anything that would prevent merge to -cip. Steps to take would be:

a) Identify minimum usable subset of the patches. That would likely be "whatever is neccessary to get some kind of output on serial console", probably clock, pinctrl, serial, dts.

b) Verify that support is already in mainline, submit neccessary patches if not.

c) Add this point it may be useful to start running tests of mainline on your LAVA board.

d) Probably send a list of patches that will be needed for initial boot.

e) Start submitting patches for review & merge.

Thanks and best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany