From: "Lad Prabhakar" <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: Pavel Machek <pavel@denx.de>
Cc: "cip-dev@lists.cip-project.org" <cip-dev@lists.cip-project.org>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>,
Biju Das <biju.das.jz@bp.renesas.com>
Subject: Re: [cip-dev] [PATCH v2 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's
Date: Wed, 25 Nov 2020 08:49:32 +0000 [thread overview]
Message-ID: <OSBPR01MB504836177875007ABDF2C00BAAFA0@OSBPR01MB5048.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <20201124194918.GB4916@amd>
[-- Attachment #1: Type: text/plain, Size: 2467 bytes --]
Hi Pavel,
> -----Original Message-----
> From: Pavel Machek <pavel@denx.de>
> Sent: 24 November 2020 19:49
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>; Biju Das <biju.das.jz@bp.renesas.com>
> Subject: Re: [PATCH v2 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's
>
> Hi!
>
> > This patch series adds SPI driver for the Renesas RPC-IF.
> > Alongside relevant changes for spi-mem have been also
> > backported. This enables accessing SPI flash chip connected
> > to RPC-IF on RZ/G2x boards.
> >
> > We currently only aim to backport just the driver hence there
> > are no changes to dts/i files. The driver has been tested on
> > RZ/G2{EM} with all the required dts/i changes [1].
>
> Okay, that was quick.
>
> What is your plan, merge dts changes soon? Or is the driver useful
> even without the dts changes?
>
We only plan to upstream/backport driver, pinctrl and clock atm (consumers needing this feature will have to manually enable the DTS)
> > Changes for v2:
> > * Patches {1, 3, 4}/7 unchanged
> > * Patch 2/7
> > * Fixed reference leak for OF node in rpcif_probe()
> > * Fixed overwriting return value in error path of rpcif_manual_xfer()
> > * Replaced C++ style comment with C style
> > * Replaced tab with a space between struct and struct name
> > * Fixed a typo in commit message (s/absract/abstract)
> > * Patch 5/7
> > * Fixed reference leak in spi_mem_access_start for PM
> > * Patch 6/7
> > * Return early in spi_mem_dirmap_dirmap_{read/write}
> > * Patch 7/7
> > * Replaced C++ style comment with C style
> > * Used __maybe_unused for rpcif_spi_{suspend,resume} and dropped
> > CONFIG_PM_SLEEP ifdef checks
> > * Elaborated the description for SPI_RPCIF config
> > * Dropped the label err_put_ctlr from rpc_spi_probe()
>
> Thanks for the changes; they are probably good (I have yet to take
> close look), but I wonder if we should wait until they hit next or
> mainline? If upstream maintainer disagrees, we would get divergence...
>
Agreed when the fixes hit linux-next I shall post a v3.
Cheers,
Prabhakar
> Best regards,
> Pavel
> --
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: Type: text/plain, Size: 420 bytes --]
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5872): https://lists.cip-project.org/g/cip-dev/message/5872
Mute This Topic: https://lists.cip-project.org/mt/78482875/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2020-11-25 8:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 17:59 [cip-dev] [PATCH v2 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's Lad Prabhakar
2020-11-24 17:59 ` [cip-dev] [PATCH v2 4.19.y-cip 1/7] dt-bindings: memory: document Renesas RPC-IF bindings Lad Prabhakar
2020-11-24 17:59 ` [cip-dev] [PATCH v2 4.19.y-cip 2/7] memory: add Renesas RPC-IF driver Lad Prabhakar
2020-11-24 17:59 ` [cip-dev] [PATCH v2 4.19.y-cip 3/7] spi: spi-mem: Add SPI_MEM_NO_DATA to the spi_mem_data_dir enum Lad Prabhakar
2020-11-24 17:59 ` [cip-dev] [PATCH v2 4.19.y-cip 4/7] spi: spi-mem: export spi_mem_default_supports_op() Lad Prabhakar
2020-11-24 17:59 ` [cip-dev] [PATCH v2 4.19.y-cip 5/7] spi: spi-mem: Split spi_mem_exec_op() code Lad Prabhakar
2020-11-24 17:59 ` [cip-dev] [PATCH v2 4.19.y-cip 6/7] spi: spi-mem: Add a new API to support direct mapping Lad Prabhakar
2020-11-24 17:59 ` [cip-dev] [PATCH v2 4.19.y-cip 7/7] spi: add Renesas RPC-IF driver Lad Prabhakar
2020-11-24 19:49 ` [cip-dev] [PATCH v2 4.19.y-cip 0/7] Add RPC-IF driver for RZ/G2x SoC's Pavel Machek
2020-11-25 6:48 ` Nobuhiro Iwamatsu
2020-11-25 8:53 ` Lad Prabhakar
2020-11-25 8:49 ` Lad Prabhakar [this message]
[not found] ` <164AB40B65E6E3DF.27508@lists.cip-project.org>
2020-12-03 10:28 ` Lad Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OSBPR01MB504836177875007ABDF2C00BAAFA0@OSBPR01MB5048.jpnprd01.prod.outlook.com \
--to=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=cip-dev@lists.cip-project.org \
--cc=nobuhiro1.iwamatsu@toshiba.co.jp \
--cc=pavel@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).