Hi Pavel, Thank you for the review. > -----Original Message----- > From: Pavel Machek > Sent: 23 November 2020 19:39 > To: Prabhakar Mahadev Lad > Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu ; Pavel Machek > ; Biju Das > Subject: Re: [PATCH 4.19.y-cip 2/7] memory: add Renesas RPC-IF driver > > Hi! > > > From: Sergei Shtylyov > > > +int rpcif_manual_xfer(struct rpcif *rpc); > > +ssize_t rpcif_dirmap_read(struct rpcif *rpc, u64 offs, size_t len, void *buf); > > + > > +#endif // __RENESAS_RPC_IF_H > > Oh and I'd use normal C comment here. > Agreed not sure why checkpatch failed to catch this for upstream. Cheers, Prabhakar > Best regards, > Pavel > -- > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany