Hi Pavel,

Thank you for the review.

> -----Original Message-----
> From: Pavel Machek <pavel@denx.de>
> Sent: 03 September 2020 18:55
> To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; Biju Das
> <biju.das.jz@bp.renesas.com>
> Subject: Re: [PATCH 4.4.y-cip] gpio: rcar: use gpiochip data pointer
>
> Hi!
>
> > This makes the driver use the data pointer added to the gpio_chip
> > to store a pointer to the state container instead of relying on
> > container_of().
>
> Okay, so this is a cleanup that makes sense for mainline.
>
> > [PL: Fixes 6e52cced1aa58 ("gpio: rcar: Implement  gpiochip.set_multiple()")]
>
> Does it fix set_multiple? ... seems so.
>
> Fixing set_multiple is possible with this oneliner, right?
>
> > @@ -541,7 +532,7 @@ static int gpio_rcar_probe(struct platform_device *pdev)
> >  irq_chip->irq_release_resources = gpio_rcar_irq_release_resources;
> >  irq_chip->flags= IRQCHIP_SET_TYPE_MASKED | IRQCHIP_MASK_ON_SUSPEND;
> >
> > -ret = gpiochip_add(gpio_chip);
> > +ret = gpiochip_add_data(gpio_chip, p);
> >  if (ret) {
> >  dev_err(dev, "failed to add GPIO controller\n");
> >  goto err0;
>
> The patch is okay and now I understand why you want it. It would have
> been nice if changelog told me directly.
>
My bad.

> Can set_multiple use container_of() too? We get less differences
> between 4.4 and 4.4-cip that way, and it is still one-liner.
>
It could use gpio_to_priv(), but since there was an commit upstream already I just pulled it in.

Let me know if you if you are OK with the patch or I shall post a one-liner.

Cheers,
Prabhakar


Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647