Hi Nobuhiro, Thank you for the review. > -----Original Message----- > From: nobuhiro1.iwamatsu@toshiba.co.jp > Sent: 04 November 2020 02:25 > To: Prabhakar Mahadev Lad ; cip-dev@lists.cip-project.org; pavel@denx.de > Cc: Biju Das > Subject: RE: [PATCH 4.19.y-cip 17/17] arm64: dts: renesas: r8a774e1: Add audio support > > Hi, > > > -----Original Message----- > > From: Lad Prabhakar [mailto:prabhakar.mahadev-lad.rj@bp.renesas.com] > > Sent: Wednesday, November 4, 2020 2:34 AM > > To: cip-dev@lists.cip-project.org; iwamatsu nobuhiro(岩松 信洋 □ＳＷＣ◯ＡＣＴ) > > ; Pavel Machek > > Cc: Biju Das > > Subject: [PATCH 4.19.y-cip 17/17] arm64: dts: renesas: r8a774e1: Add audio support > > > > commit 8183a7938cfec0569d77755af5ce5ff5589f3540 upstream. > > > > Add sound support for the RZ/G2H SoC (a.k.a. R8A774E1). > > > > Signed-off-by: Lad Prabhakar > > Reviewed-by: Marian-Cristian Rotariu > > Link: https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.kernel.org%2Fr%2F1594919915-5225-16-git-send-email- > prabhakar.mahadev-lad.rj%40bp.renesas.com&data=04%7C01%7Cprabhakar.mahadev- > lad.rj%40bp.renesas.com%7C349a7c0b44a24c71d5ce08d88068dd5f%7C53d82571da1947e49cb4625a166a4a2a%7C0%7C0%7C637400535 > 165761476%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000& > sdata=Kh6RbUFAryKsjio9NKDXhYxtr6Kw6oGW1ZDOKmbBi%2Bs%3D&reserved=0 > > Signed-off-by: Geert Uytterhoeven > > [PL: Manually applied the changes to dtsi] > > Signed-off-by: Lad Prabhakar > > --- > > arch/arm64/boot/dts/renesas/r8a774e1.dtsi | 478 +++++++++++++++++++++- > > 1 file changed, 475 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi > > index 271045556aa0..9af3ddbe5454 100644 > > --- a/arch/arm64/boot/dts/renesas/r8a774e1.dtsi > > +++ b/arch/arm64/boot/dts/renesas/r8a774e1.dtsi > > @@ -1435,6 +1435,19 @@ > > }; > > > > rcar_sound: sound@ec500000 { > > + /* > > + * #sound-dai-cells is required > > + * > > + * Single DAI : #sound-dai-cells = <0>; <&rcar_sound>; > > + * Multi DAI : #sound-dai-cells = <1>; <&rcar_sound N>; > > + */ > > + /* > > + * #clock-cells is required for audio_clkout0/1/2/3 > > + * > > + * clkout : #clock-cells = <0>; <&rcar_sound>; > > + * clkout0/1/2/3: #clock-cells = <1>; <&rcar_sound N>; > > + */ > > + compatible = "renesas,rcar_sound-r8a774e1", "renesas,rcar_sound-gen3"; > > reg = <0 0xec500000 0 0x1000>, /* SCU */ > > <0 0xec5a0000 0 0x100>, /* ADG */ > > <0 0xec540000 0 0x1000>, /* SSIU */ > > @@ -1442,17 +1455,476 @@ > > <0 0xec760000 0 0x200>; /* Audio DMAC peri peri*/ > > reg-names = "scu", "adg", "ssiu", "ssi", "audmapp"; > > > > - status = "disabled"; > > + clocks = <&cpg CPG_MOD 1005>, > > + <&cpg CPG_MOD 1006>, <&cpg CPG_MOD 1007>, > > + <&cpg CPG_MOD 1008>, <&cpg CPG_MOD 1009>, > > + <&cpg CPG_MOD 1010>, <&cpg CPG_MOD 1011>, > > + <&cpg CPG_MOD 1012>, <&cpg CPG_MOD 1013>, > > + <&cpg CPG_MOD 1014>, <&cpg CPG_MOD 1015>, > > + <&cpg CPG_MOD 1022>, <&cpg CPG_MOD 1023>, > > + <&cpg CPG_MOD 1024>, <&cpg CPG_MOD 1025>, > > + <&cpg CPG_MOD 1026>, <&cpg CPG_MOD 1027>, > > + <&cpg CPG_MOD 1028>, <&cpg CPG_MOD 1029>, > > + <&cpg CPG_MOD 1030>, <&cpg CPG_MOD 1031>, > > + <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, > > + <&cpg CPG_MOD 1020>, <&cpg CPG_MOD 1021>, > > + <&cpg CPG_MOD 1019>, <&cpg CPG_MOD 1018>, > > + <&audio_clk_a>, <&audio_clk_b>, > > > There is no definition for audio_clk_b. > The clock will be overwritten by hihope-rev4.dtsi, but I think it needs to be define like audio_clk_a. > Agreed, I have posted a fix upstream [1] will re-send the patches once it hits -rc. [1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20201104105508.21197-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Cheers, Prabhakar