cip-dev.lists.cip-project.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Kiszka" <jan.kiszka@siemens.com>
To: cip-dev@lists.cip-project.org,
	Henning Schild <henning.schild@siemens.com>
Subject: Re: [cip-dev] [isar-cip-core] [PATCH] classes: make swu image file variable absolute like the others
Date: Wed, 13 Jan 2021 11:45:42 +0100	[thread overview]
Message-ID: <f76be6f7-fca8-8514-bfe2-789fde69ab2b@siemens.com> (raw)
In-Reply-To: <20210111124104.31067-1-henning.schild@siemens.com>

[-- Attachment #1: Type: text/plain, Size: 1796 bytes --]

On 11.01.21 13:41, Henning Schild wrote:
> From: Henning Schild <henning.schild@siemens.com>
> 
> All the other variables for images already contain the deploydir
> in their absolute names. Only the one for swupdate was relative.
> 
> Found this in another layer where we have a task copying deploy
> files to a deploy location with bitbake.
> 
> Signed-off-by: Henning Schild <henning.schild@siemens.com>
> ---
>  classes/swupdate-img.bbclass | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/classes/swupdate-img.bbclass b/classes/swupdate-img.bbclass
> index a21d6ec..09e92cc 100644
> --- a/classes/swupdate-img.bbclass
> +++ b/classes/swupdate-img.bbclass
> @@ -9,7 +9,7 @@
>  #
>  # SPDX-License-Identifier: MIT
>  
> -SWU_IMAGE_FILE ?= "${PN}-${DISTRO}-${MACHINE}.swu"
> +SWU_IMAGE_FILE ?= "${DEPLOY_DIR_IMAGE}/${PN}-${DISTRO}-${MACHINE}.swu"
>  SWU_DESCRIPTION_FILE ?= "sw-description"
>  SWU_ADDITIONAL_FILES ?= ""
>  SWU_SIGNED ?= ""
> @@ -21,7 +21,7 @@ IMAGER_INSTALL += "${@'openssl' if bb.utils.to_boolean(d.getVar('SWU_SIGNED')) e
>  do_swupdate_image[stamp-extra-info] = "${DISTRO}-${MACHINE}"
>  do_swupdate_image[cleandirs] += "${WORKDIR}/swu"
>  do_swupdate_image() {
> -    rm -f '${DEPLOY_DIR_IMAGE}/${SWU_IMAGE_FILE}'
> +    rm -f '${SWU_IMAGE_FILE}'
>      cp '${WORKDIR}/${SWU_DESCRIPTION_FILE}' '${WORKDIR}/swu/${SWU_DESCRIPTION_FILE}'
>  
>      # Create symlinks for files used in the update image
> @@ -68,7 +68,7 @@ do_swupdate_image() {
>              echo "$file".'${SWU_SIGNATURE_EXT}'
>          fi
>      done | cpio -ovL -H crc \
> -        > '${DEPLOY_DIR_IMAGE}/${SWU_IMAGE_FILE}'
> +        > '${SWU_IMAGE_FILE}'
>      cd -
>  }
>  
> 

Thanks, applied.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

[-- Attachment #2: Type: text/plain, Size: 420 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#6062): https://lists.cip-project.org/g/cip-dev/message/6062
Mute This Topic: https://lists.cip-project.org/mt/79594351/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-


      reply	other threads:[~2021-01-13 10:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11 12:41 [cip-dev] [isar-cip-core] [PATCH] classes: make swu image file variable absolute like the others Henning Schild
2021-01-13 10:45 ` Jan Kiszka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f76be6f7-fca8-8514-bfe2-789fde69ab2b@siemens.com \
    --to=jan.kiszka@siemens.com \
    --cc=cip-dev@lists.cip-project.org \
    --cc=henning.schild@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).