Re: [isar-cip-core][PATCH 02/11] Rename initrd with the gz suffix

[Jan Kiszka <jan.kiszka@siemens.com>]

On 15.11.21 17:17, Alice Ferrazzi wrote:
> Generated initrd are actually gz compressed and KernelCI need
> the initrd image filename to contain the gz suffix for work.
> 
> Signed-off-by: Alice Ferrazzi <alice.ferrazzi@miraclelinux.com>
> ---
>  scripts/deploy-kernelci.py | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/deploy-kernelci.py b/scripts/deploy-kernelci.py
> index 931504c..c2341a6 100755
> --- a/scripts/deploy-kernelci.py
> +++ b/scripts/deploy-kernelci.py
> @@ -18,6 +18,10 @@ extension=sys.argv[3]
>  
>  rootfs_filename="cip-core-image-"+extension+"-cip-core-"+release+"-"+target+".tar.gz"
>  initrd_filename="cip-core-image-"+extension+"-cip-core-"+release+"-"+target+"-initrd.img"
> +
> +# initrd is actually gz compressed
> +initrd_gz_filename="cip-core-image-"+extension+"-cip-core-"+release+"-"+target+"-initrd.img.gz"
> +
>  input_dir="build/tmp/deploy/images/"+target
>  upload_path="/images/rootfs/cip/"+cdate+"/"+target+"/"
>  rootfs=input_dir+"/"+rootfs_filename
> @@ -44,5 +48,5 @@ if os.path.exists(rootfs) and os.path.exists(initrd):
>      print("uploading rootfs to KernelCI")
>      upload_file(api, token, upload_path, rootfs, rootfs_filename)
>      print("uploading initrd to KernelCI")
> -    upload_file(api, token, upload_path, initrd, initrd_filename)
> +    upload_file(api, token, upload_path, initrd, initrd_gz_filename)
>      print("uploaded to: https://storage.staging.kernelci.org"+upload_path)
> 

Why not fold that into patch 1 directly? Fixing new files right after
introducing them is not an optimal pattern.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux