cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Max <msuraev@sysmocom.de>
To: cocci@systeme.lip6.fr
Subject: [Cocci] struct replacement
Date: Wed, 12 Dec 2018 19:39:29 +0100	[thread overview]
Message-ID: <0c0bf80c-56bd-6560-12b8-97a4b1b89963@sysmocom.de> (raw)

Hi.

I have been trying to use spatch to update c struct but haven't found a 
way to do so yet.

For example, we have

struct old_thing {

uint8_t a;

uint16_t b[5];

};

which I'd like to replace with

struct new_thing {

uint8_t x1;

uint32_t x2;

uint8_t x3[11];

};

So pretty much replace every function parameter:

f1(... struct old_thing *t...) => f1(... struct new_thing *t...)

Replace the field access and variable definitions:

...

struct old_thing t1; => struct new_thing t1;

struct old_thing *t2; => struct new_thing *t2;

...

t1.a => t1.x1

t2->b => t2->x3

...

The thing which escapes me is how to make coccinelle treat it like a type?

Do I need to use @@typedef struct old_thing@@? Do I use it as 
@@identifier old_stuff@@ or @@identifier struct old_stuff@@?

Doesn't seem to work for me.

Any links to .spatch examples playing around with structs would be 
greatly appreciated.

-- 
- Max Suraev <msuraev@sysmocom.de>       http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Directors: Harald Welte

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

             reply	other threads:[~2018-12-12 22:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 18:39 Max [this message]
2018-12-13  6:24 ` [Cocci] struct replacement Julia Lawall
2018-12-13 16:43   ` Max
2018-12-13 20:01     ` Julia Lawall
     [not found]       ` <c8041b90-d4e9-a9a6-603d-7f5498fe081c@users.sourceforge.net>
2018-12-15 13:49         ` Julia Lawall
2018-12-18 16:15       ` Max
2018-12-18 16:19         ` Julia Lawall
2018-12-18 16:44           ` Max
2018-12-18 16:54             ` Julia Lawall
2018-12-18 17:12               ` Max
2018-12-18 17:18                 ` Julia Lawall
2018-12-18 18:13                   ` Max

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c0bf80c-56bd-6560-12b8-97a4b1b89963@sysmocom.de \
    --to=msuraev@sysmocom.de \
    --cc=cocci@systeme.lip6.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).