From: Markus Elfring <Markus.Elfring@web.de>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: cocci@systeme.lip6.fr
Subject: Re: [Cocci] Detecting false positive sparse with Coccinelle
Date: Mon, 29 Apr 2019 16:42:10 +0200 [thread overview]
Message-ID: <0c9fd263-74d0-908d-9c84-b4ce702d1601@web.de> (raw)
In-Reply-To: <20190429060512.GA16251@osadl.at>
> … - the problem though is that I'm unable
> to insert the (__force __be16) cast in the patch rule as
> coccinelle is refusing hose lines. …
It seems that I can not help directly with this concern. But a few other
implementation details in your approach caught also my development attention
once more.
1. A disjunction is used for the SmPL rule “acheck”.
I find that duplicated SmPL code can be avoided there.
How do you think about to specify the desired function names
by a corresponding SmPL constraint or a nested disjunction?
2. The addition of a cast can be specified in a more succinct way
for the SmPL rule “afix”.
3. The specification “@script:python depends on patch@” might result in
undesirable data output.
Would you like to select an other output channel than
for the generated diff?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-04-29 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 6:05 [Cocci] detecting false positive sparse with coccinelle Nicholas Mc Guire
2019-04-29 14:42 ` Markus Elfring [this message]
2019-04-29 16:26 ` Julia Lawall
2019-04-30 3:26 ` Nicholas Mc Guire
2019-04-30 10:56 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c9fd263-74d0-908d-9c84-b4ce702d1601@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=der.herr@hofr.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).