[Cocci] Matching more than one declaration?

[Cocci] Matching more than one declaration?

[Michael Stefaniuc]

Hello,

it seems that more than one declaration cannot be matched in one rule:

@@
identifier i, f;
@@
- int i;
- int f;

That won't match

void foo(void)
{
    int i;
    float f;
}


Is there a way to do that?
In my specific case I need to replace 3 declarations with a single
declarer. I can use 3 separate rules but the first rule will produce
false positives if the other two declarations aren't there.


thanks
bye
      michael
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] Matching more than one declaration?

[Julia Lawall]

On Thu, 2 May 2019, Michael Stefaniuc wrote:

> Hello,
>
> it seems that more than one declaration cannot be matched in one rule:
>
> @@
> identifier i, f;
> @@
> - int i;
> - int f;
>
> That won't match
>
> void foo(void)
> {
>     int i;
>     float f;

The semantic patch has int int and the code has int float.  If the code
has int int, it matches fine.

julia

> }
>
>
> Is there a way to do that?
> In my specific case I need to replace 3 declarations with a single
> declarer. I can use 3 separate rules but the first rule will produce
> false positives if the other two declarations aren't there.
>
>
> thanks
> bye
>       michael
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] Matching more than one declaration?

[Michael Stefaniuc]

[-- Attachment #1: Type: text/plain, Size: 613 bytes --]

On 2019-05-03 09:17, Julia Lawall wrote:
> On Thu, 2 May 2019, Michael Stefaniuc wrote:
> 
>> Hello,
>> 
>> it seems that more than one declaration cannot be matched in one rule:
>> 
>> @@
>> identifier i, f;
>> @@
>> - int i;
>> - int f;
>> 
>> That won't match
>> 
>> void foo(void)
>> {
>>     int i;
>>     float f;
> 
> The semantic patch has int int and the code has int float.  If the code
> has int int, it matches fine.
Duh... I messed it up while simplifying my test case :/

It does work but only in function scope and not in global scope.
I've attached the fixed test case.

thanks
bye
       michael

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: declare.c --]
[-- Type: text/x-c; name=declare.c, Size: 60 bytes --]

int i;
float f;

void foo(void)
{
    int i;
    float f;
}

[-- Attachment #3: declare.cocci --]
[-- Type: text/plain, Size: 43 bytes --]

@@
identifier i, f;
@@
- int i;
- float f;

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #4: declare.diff --]
[-- Type: text/x-diff; name=declare.diff, Size: 133 bytes --]

--- declare.c
+++ /tmp/cocci-output-5279-c2f13d-declare.c
@@ -3,6 +3,4 @@ float f;
 
 void foo(void)
 {
-    int i;
-    float f;
 }

[-- Attachment #5: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] Matching more than one declaration?

[Julia Lawall]

On Fri, 3 May 2019, Michael Stefaniuc wrote:

> On 2019-05-03 09:17, Julia Lawall wrote:
> > On Thu, 2 May 2019, Michael Stefaniuc wrote:
> >
> > > Hello,
> > >
> > > it seems that more than one declaration cannot be matched in one rule:
> > >
> > > @@
> > > identifier i, f;
> > > @@
> > > - int i;
> > > - int f;
> > >
> > > That won't match
> > >
> > > void foo(void)
> > > {
> > >     int i;
> > >     float f;
> >
> > The semantic patch has int int and the code has int float.  If the code
> > has int int, it matches fine.
> Duh... I messed it up while simplifying my test case :/
>
> It does work but only in function scope and not in global scope.
> I've attached the fixed test case.

No, it won't work in global scope.  You can only match one top-level thing
at a time, and each declaration is a top-level thing.  Youcan make a
series of rules that depend on the previous ones, and only make the change
if all are matched.

julia

>
> thanks
> bye
>       michael
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

Re: [Cocci] Matching more than one declaration?

[Michael Stefaniuc]

On 5/3/19 10:39 PM, Julia Lawall wrote:
> 
> 
> On Fri, 3 May 2019, Michael Stefaniuc wrote:
> 
>> On 2019-05-03 09:17, Julia Lawall wrote:
>>> On Thu, 2 May 2019, Michael Stefaniuc wrote:
>>>
>>>> Hello,
>>>>
>>>> it seems that more than one declaration cannot be matched in one rule:
>>>>
>>>> @@
>>>> identifier i, f;
>>>> @@
>>>> - int i;
>>>> - int f;
>>>>
>>>> That won't match
>>>>
>>>> void foo(void)
>>>> {
>>>>     int i;
>>>>     float f;
>>>
>>> The semantic patch has int int and the code has int float.  If the code
>>> has int int, it matches fine.
>> Duh... I messed it up while simplifying my test case :/
>>
>> It does work but only in function scope and not in global scope.
>> I've attached the fixed test case.
> 
> No, it won't work in global scope.  You can only match one top-level thing
> at a time, and each declaration is a top-level thing.  Youcan make a
> series of rules that depend on the previous ones, and only make the change
> if all are matched.
Ok, thanks. That's what I did as a workaround.

bye
	michael

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci