From: Maxime Ripard <maxime.ripard@bootlin.com>
To: cocci@systeme.lip6.fr
Subject: [Cocci] Substitution of function call to structure parameter
Date: Tue, 12 Mar 2019 09:31:43 +0100 [thread overview]
Message-ID: <20190312083143.sko2syivudpawqk7@flea> (raw)
[-- Attachment #1.1: Type: text/plain, Size: 1913 bytes --]
Hi,
I'm trying to do an API rework of DRM, and that rewrite involves
patching a number of drivers to use a structure field instead of a
funtion call.
There's a bunch of cases that need to be covered, and I can't get all
of them to work.
So far, my current script is, with the current shortcomings as comment
below each rule.
@@
identifier fn;
identifier dev, cmd;
@@
fn (struct drm_device *dev,
...,
struct drm_mode_fb_cmd2 *cmd,
...)
{
+ const struct drm_format_info *info = drm_get_format_info(dev, cmd);
...
- drm_format_num_planes(cmd->pixel_format)
+ info->num_planes
...
}
// This on works on most cases, ie:
// https://elixir.bootlin.com/linux/v5.0/source/drivers/gpu/drm/armada/armada_fb.c#L87
// However, for some reason unknown to me, it doesn't match:
// https://elixir.bootlin.com/linux/v5.0/source/drivers/gpu/drm/tegra/fb.c#L129
@@
identifier fb;
@@
...
struct drm_framebuffer *fb;
...
- drm_format_num_planes(fb->format->format)
+ fb->format->num_planes
// This one seems to work properly
@@
expression arg;
identifier fb;
@@
...
struct drm_framebuffer *fb;
...
- drm_format_num_planes(arg)
+ fb->format->num_planes
// This one seems to work in some cases, such as
// https://elixir.bootlin.com/linux/v5.0/source/drivers/gpu/drm/vc4/vc4_plane.c#L490
// But it also matches in cases where fb hasn't been properly assigned before, such as:
// https://elixir.bootlin.com/linux/v5.0/source/drivers/gpu/drm/tegra/fb.c#L142
@@
identifier info;
@@
...
struct drm_format_info *info;
...
- drm_format_num_planes(info->format)
+ info->num_planes
// This one seems to work too
I'm pretty new to coccinelle, so I'm not quite sure how to fix these
errors properly, even though that looks pretty simple.
Thanks!
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next reply other threads:[~2019-03-12 8:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-12 8:31 Maxime Ripard [this message]
2019-03-12 9:03 ` [Cocci] Substitution of function call to structure parameter Julia Lawall
2019-03-12 11:01 ` Maxime Ripard
2019-03-12 11:20 ` Julia Lawall
2019-03-12 13:48 ` Maxime Ripard
2019-03-12 13:54 ` Julia Lawall
2019-03-12 13:52 ` Maxime Ripard
2019-03-12 13:58 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190312083143.sko2syivudpawqk7@flea \
--to=maxime.ripard@bootlin.com \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).