From: Sasha Levin <sashal@kernel.org>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: michal.lkml@markovi.net, nicolas.palix@imag.fr,
linux-kernel@vger.kernel.org, cocci@systeme.lip6.fr,
Markus.Elfring@web.de, Pavel Machek <pavel@ucw.cz>,
wen.yang99@zte.com.cn
Subject: Re: [Cocci] Coccinelle: semantic patch for missing of_node_put
Date: Mon, 20 May 2019 13:20:41 -0400 [thread overview]
Message-ID: <20190520172041.GH11972@sasha-vm> (raw)
In-Reply-To: <alpine.DEB.2.21.1905201152040.2543@hadrien>
On Mon, May 20, 2019 at 11:52:37AM +0200, Julia Lawall wrote:
>
>
>On Mon, 20 May 2019, Pavel Machek wrote:
>
>> Hi!
>>
>> > A semantic patch has no access to comments. The only thing I can see to
>> > do is to use python to interact with some external tools. For example,
>> > you could write some code to collect the comments in a file and the lines
>> > on which they occur, and then get the comment that most closely precedes
>> > the start of the function.
>>
>> How dangerous is missing of_node_put? AFAICT it will only result into
>> very small, one-time memory leak, right?
>>
>> Could we make sure these patches are _not_ going to stable? Leaking
>> few bytes once per boot is not really a serious bug.
>
>Sasha,
>
>Probably patches that add only of_node_put should not be auto selected for
>stable.
I can filter them out, but those are fixes, right? Why are we concerned
about them making it into -stable?
--
Thanks,
Sasha
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-05-24 6:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201905171432571474636@zte.com.cn>
2019-05-17 8:10 ` [Cocci] Coccinelle: semantic patch for missing of_node_put Markus Elfring
[not found] ` <alpine.DEB.2.20.1905170912590.4014@hadrien>
2019-05-17 8:22 ` Markus Elfring
[not found] ` <20190520093303.GA9320@atrey.karlin.mff.cuni.cz>
2019-05-20 9:52 ` Julia Lawall
2019-05-20 17:20 ` Sasha Levin [this message]
2019-05-20 19:53 ` Julia Lawall
2019-05-20 20:11 ` Markus Elfring
2019-05-18 14:43 ` Markus Elfring
2019-06-04 5:08 ` Markus Elfring
2019-06-04 5:50 ` wen.yang99
2019-06-04 6:36 ` Markus Elfring
2019-06-04 8:55 ` wen.yang99
2019-06-04 9:08 ` Markus Elfring
2019-06-04 11:28 ` Markus Elfring
2019-06-05 18:23 ` [Cocci] Coccinelle: Searching for “when done” in function comments Markus Elfring
2019-05-09 1:47 [Cocci] [PATCH] coccinelle: semantic patch for missing of_node_put wen.yang99
2019-05-09 8:10 ` [Cocci] Coccinelle: " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520172041.GH11972@sasha-vm \
--to=sashal@kernel.org \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=pavel@ucw.cz \
--cc=wen.yang99@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).