cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Matthias Maennich <maennich@google.com>
Cc: kstewart@linuxfoundation.org, linux-m68k@vger.kernel.org,
	oneukum@suse.com,
	Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
	usb-storage@lists.one-eyed-alien.net,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	hpa@zytor.com, joel@joelfernandes.org, sam@ravnborg.org,
	cocci@systeme.lip6.fr, linux-arch@vger.kernel.org,
	linux-scsi@vger.kernel.org, x86@kernel.org,
	lucas.de.marchi@gmail.com, mingo@redhat.com,
	geert@linux-m68k.org, stern@rowland.harvard.edu,
	kernel-team@android.com, sspatil@google.com, arnd@arndb.de,
	linux-kbuild@vger.kernel.org, jeyu@kernel.org,
	Nicolas Palix <nicolas.palix@imag.fr>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	tglx@linutronix.de, maco@android.com, michal.lkml@markovi.net,
	linux-usb@vger.kernel.org, sboyd@codeaurora.org,
	linux-kernel@vger.kernel.org, maco@google.com,
	pombredanne@nexb.com, "David S. Miller" <davem@davemloft.net>,
	linux-modules@vger.kernel.org
Subject: Re: [Cocci] [PATCH v2 08/10] scripts: Coccinelle script for namespace dependencies.
Date: Tue, 13 Aug 2019 14:44:32 +0200	[thread overview]
Message-ID: <20190813124432.GA12475@kroah.com> (raw)
In-Reply-To: <20190813121733.52480-9-maennich@google.com>

On Tue, Aug 13, 2019 at 01:17:05PM +0100, Matthias Maennich wrote:
> A script that uses the '<module>.ns_deps' file generated by modpost to
> automatically add the required symbol namespace dependencies to each
> module.
> 
> Usage:
> 1) Move some symbols to a namespace with EXPORT_SYMBOL_NS() or define
>    DEFAULT_SYMBOL_NAMESPACE
> 2) Run 'make' (or 'make modules') and get warnings about modules not
>    importing that namespace.
> 3) Run 'make nsdeps' to automatically add required import statements
>    to said modules.
> 
> This makes it easer for subsystem maintainers to introduce and maintain
> symbol namespaces into their codebase.
> 
> Co-developed-by: Martijn Coenen <maco@android.com>
> Signed-off-by: Martijn Coenen <maco@android.com>
> Signed-off-by: Matthias Maennich <maennich@google.com>
> ---

I really can't express just how cool this patch is.  I was amazed when I
first saw it in action a long time ago, and still am.

Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply	other threads:[~2019-08-14  8:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180716122125.175792-1-maco@android.com>
2019-08-13 12:16 ` [Cocci] [PATCH v2 0/10] Symbol namespaces - RFC Matthias Maennich
2019-08-13 12:17   ` [Cocci] [PATCH v2 08/10] scripts: Coccinelle script for namespace dependencies Matthias Maennich
2019-08-13 12:31     ` Julia Lawall
2019-08-13 12:44     ` Greg KH [this message]
2019-08-14  6:36     ` Himanshu Jha
2019-08-14  8:03       ` Matthias Maennich
2019-08-14 12:00     ` [Cocci] [v2 " Markus Elfring
2019-08-14 12:20       ` Matthias Maennich
     [not found]   ` <20190821114955.12788-1-maennich@google.com>
     [not found]     ` <20190821114955.12788-9-maennich@google.com>
2019-08-29 12:13       ` [Cocci] [PATCH v3 08/11] " Jessica Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190813124432.GA12475@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=arnd@arndb.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=hpa@zytor.com \
    --cc=jeyu@kernel.org \
    --cc=joel@joelfernandes.org \
    --cc=kernel-team@android.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=linux-modules@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lucas.de.marchi@gmail.com \
    --cc=maco@android.com \
    --cc=maco@google.com \
    --cc=maennich@google.com \
    --cc=mchehab+samsung@kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=mingo@redhat.com \
    --cc=nicolas.ferre@microchip.com \
    --cc=nicolas.palix@imag.fr \
    --cc=oneukum@suse.com \
    --cc=pombredanne@nexb.com \
    --cc=sam@ravnborg.org \
    --cc=sboyd@codeaurora.org \
    --cc=sspatil@google.com \
    --cc=stern@rowland.harvard.edu \
    --cc=tglx@linutronix.de \
    --cc=usb-storage@lists.one-eyed-alien.net \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).