Coccinelle archive on lore.kernel.org
 help / color / Atom feed
* [Cocci] const in parameter lists
@ 2019-09-12 11:13 Christoph Böhmwalder
  2019-09-12 11:31 ` Julia Lawall
  0 siblings, 1 reply; 9+ messages in thread
From: Christoph Böhmwalder @ 2019-09-12 11:13 UTC (permalink / raw)
  To: Coccinelle

Hi,

I'm having trouble removing const arguments from a function. I think this issue
is best explained in code:

$ cat repro.c
f(int x,
  const unsigned a,
  const char *y)
{
}

$ cat repro.cocci
@@
identifier a;
@@
f(...
- , unsigned a
+ , unsigned b
,...)
{
...
}

$ spatch --sp-file repro.cocci --very-quiet repro.c
--- repro.c
+++ /tmp/cocci-output-17454-200d33-repro.c
@@ -1,5 +1,5 @@
-f(int x,
-  const unsigned a,
+f(int x
+  const, unsigned b,
   const char *y)
 {
 }


When I try to remove some parameter(s) in the middle (in my real use case
I'm trying to remove 2) the 'const' ends up in weird places.

Obviously I've tried (with and without disable optional_qualifier):

    f(...
    - , const unsigned a
    + , const unsigned b
    ,...)

but that gives:

    minus: parse error:
      File "repro.cocci", line 5, column 19, charpos = 45
      around = 'a',
      whole content = - , const unsigned a

How can I tell coccinelle that I want a const here?

Thanks,
--
Christoph Böhmwalder
LINBIT | Keeping the Digital World Running
DRBD HA —  Disaster Recovery — Software defined Storage
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-12 11:13 [Cocci] const in parameter lists Christoph Böhmwalder
2019-09-12 11:31 ` Julia Lawall
2019-09-12 12:34   ` Christoph Böhmwalder
2019-09-12 12:50     ` Julia Lawall
2019-09-12 14:33     ` Markus Elfring
2019-09-12 14:49       ` Julia Lawall
2019-09-12 14:56         ` Markus Elfring
2019-09-14 20:00     ` Julia Lawall
2019-09-15 11:38       ` Markus Elfring

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr cocci@archiver.kernel.org
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox