Coccinelle archive on lore.kernel.org
 help / color / Atom feed
From: Matthias Maennich <maennich@google.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: michal.lkml@markovi.net, gregkh@linuxfoundation.org,
	nicolas.palix@imag.fr, linux-kernel@vger.kernel.org,
	Markus.Elfring@web.de, jeyu@kernel.org, cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH] scripts: add_namespace: Fix coccicheck failed
Date: Sun, 6 Oct 2019 12:09:43 +0100
Message-ID: <20191006110943.GA172281@google.com> (raw)
In-Reply-To: <20191006044456.57608-1-yuehaibing@huawei.com>

Hi YueHaibing!

On Sun, Oct 06, 2019 at 12:44:56PM +0800, YueHaibing wrote:
>Now all scripts in scripts/coccinelle to be automatically called
>by coccicheck. However new adding add_namespace.cocci does not
>support report mode, which make coccicheck failed.
>This add "virtual report" to  make the coccicheck go ahead smoothly.
>
>Fixes: eb8305aecb95 ("scripts: Coccinelle script for namespace dependencies.")
>Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Thanks for fixing this!

Acked-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias

>---
> scripts/coccinelle/misc/add_namespace.cocci | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/scripts/coccinelle/misc/add_namespace.cocci b/scripts/coccinelle/misc/add_namespace.cocci
>index c832bb6445a8..99e93a6c2e24 100644
>--- a/scripts/coccinelle/misc/add_namespace.cocci
>+++ b/scripts/coccinelle/misc/add_namespace.cocci
>@@ -6,6 +6,8 @@
> /// add a missing namespace tag to a module source file.
> ///
>
>+virtual report
>+
> @has_ns_import@
> declarer name MODULE_IMPORT_NS;
> identifier virtual.ns;
>-- 
>2.20.1
>
>
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  parent reply index

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-28  9:42 [Cocci] [RFC PATCH] scripts: " YueHaibing
2019-09-28 12:43 ` Julia Lawall
2019-09-29  2:04   ` Yuehaibing
2019-09-29 16:32     ` Julia Lawall
2019-09-29 18:00       ` Markus Elfring
2019-09-29 18:05         ` Julia Lawall
2019-09-29 18:18           ` [Cocci] [RFC] " Markus Elfring
2019-09-30  2:32       ` [Cocci] [RFC PATCH] " Yuehaibing
2019-10-01 12:57         ` Matthias Maennich
2019-10-01 15:33           ` [Cocci] [RFC] " Markus Elfring
2019-10-01 13:01         ` [Cocci] [RFC PATCH] " Julia Lawall
2019-10-03 11:57           ` Masahiro Yamada
2019-10-03 12:22             ` Julia Lawall
2019-10-04  2:32               ` Masahiro Yamada
2019-10-05 11:17                 ` [Cocci] [RFC] " Markus Elfring
2019-10-05 12:26                   ` Julia Lawall
2019-10-05 17:49                     ` Markus Elfring
2019-10-05 17:49                     ` Markus Elfring
2019-10-06  5:21                     ` Markus Elfring
2019-10-06  5:28                       ` Julia Lawall
2019-10-06  5:34                         ` Markus Elfring
2019-10-06  7:30                           ` Greg Kroah-Hartman
2019-10-06  4:23                 ` [Cocci] [RFC PATCH] " Yuehaibing
2019-10-06  4:44                 ` [Cocci] [PATCH] scripts: add_namespace: " YueHaibing
2019-10-06  6:40                   ` Markus Elfring
2019-10-06  6:44                     ` Julia Lawall
2019-10-06  7:00                       ` [Cocci] " Markus Elfring
2019-10-06 11:09                   ` Matthias Maennich [this message]
2019-10-07 13:15                   ` [Cocci] [PATCH] " Jessica Yu
2019-10-03 16:30             ` [Cocci] [RFC] scripts: " Markus Elfring
2019-10-03 16:30             ` Markus Elfring
2019-10-03 19:35               ` Julia Lawall
2019-10-04  8:23                 ` Markus Elfring
2019-09-29  8:20 ` [Cocci] [RFC PATCH] " Markus Elfring
2019-09-29 13:12 ` Markus Elfring
2019-09-29 16:40   ` Julia Lawall
2019-10-02  7:09     ` [Cocci] [PATCH 0/2] Coccinelle: Extend directory hierarchy Markus Elfring
2019-10-02  7:10       ` [Cocci] [PATCH 1/2] Coccinelle: Move the SmPL script “add_namespace.cocci” into a new directory Markus Elfring
2019-10-02  7:12       ` [Cocci] [PATCH 2/2] Coccinelle: Move coccicheck directories into a new subdirectory Markus Elfring

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191006110943.GA172281@google.com \
    --to=maennich@google.com \
    --cc=Markus.Elfring@web.de \
    --cc=cocci@systeme.lip6.fr \
    --cc=gregkh@linuxfoundation.org \
    --cc=jeyu@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/cocci/0 cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ https://lore.kernel.org/cocci \
		cocci@systeme.lip6.fr cocci@archiver.kernel.org
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/fr.lip6.systeme.cocci


AGPL code for this site: git clone https://public-inbox.org/ public-inbox