cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: <zhong.shiqi@zte.com.cn>
To: <Markus.Elfring@web.de>
Cc: wang.yi59@zte.com.cn, michal.lkml@markovi.net,
	nicolas.palix@imag.fr, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn,
	cheng.shengyu@zte.com.cn, cocci@systeme.lip6.fr
Subject: Re: [Cocci] [PATCH v2] coccicheck: support $COCCI being defined as adirectory
Date: Thu, 24 Oct 2019 16:03:21 +0800 (CST)	[thread overview]
Message-ID: <201910241603217396927@zte.com.cn> (raw)
In-Reply-To: <5762844f-2c39-2106-21fa-65e8297d4235@web.de>


[-- Attachment #1.1: Type: text/plain, Size: 938 bytes --]

> I find that the commit message should still be considerably improved.
> How do you think about to use the subject “[PATCH] coccicheck:
> Support search for SmPL scripts within selected directory hierarchy”?

I would like to use subject as you said.
But it seems a little bit long, does it matter?

> > Put a modification in scripts/coccicheck which supports users in
> > configuring COCCI parameter as a directory to traverse files in
> > directory whose next level directory contains rule files with Suffix of cocci.

> * Please avoid a typo in this change description.

I am pleasure to rewrite this change description.

> * Would you like to integrate a wording approach like the following?

I'd like to. Thanks.

> A search can be performed for SmPL scripts within a directory hierarchy.
> Start a corresponding file determination if the environment variable “COCCI”
> contains an acceptable path.

Best Regards,
zhong.shiqi

[-- Attachment #2: Type: text/plain, Size: 136 bytes --]

_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

  reply	other threads:[~2019-10-24  8:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  6:04 [Cocci] [PATCH v2] coccicheck:support $COCCI being defined as a directory zhongshiqi
2019-10-24  6:19 ` Julia Lawall
2019-10-24  7:55   ` [Cocci] [PATCH v2] coccicheck: support " Markus Elfring
2019-10-24  7:58     ` Julia Lawall
2019-10-24  9:11       ` [Cocci] [v2] " Markus Elfring
2019-10-24  8:02   ` [Cocci] [PATCH v2] coccicheck:support $COCCI being defined as adirectory zhong.shiqi
2019-10-24  7:06 ` [Cocci] [PATCH v2] coccicheck: support $COCCI being defined as a directory Markus Elfring
2019-10-24  8:03   ` zhong.shiqi [this message]
2019-10-24  9:23     ` [Cocci] [v2] coccicheck: support $COCCI being defined as adirectory Markus Elfring
2019-10-24  9:58       ` zhong.shiqi
2019-10-24 10:52         ` [Cocci] [v2] coccicheck: support $COCCI being defined as a directory Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201910241603217396927@zte.com.cn \
    --to=zhong.shiqi@zte.com.cn \
    --cc=Markus.Elfring@web.de \
    --cc=cheng.shengyu@zte.com.cn \
    --cc=cocci@systeme.lip6.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.lkml@markovi.net \
    --cc=nicolas.palix@imag.fr \
    --cc=wang.yi59@zte.com.cn \
    --cc=xue.zhihong@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).