Coccinelle archive on
 help / color / Atom feed
From: Matthias Maennich <>
To: Shuah Khan <>
Cc: Greg Kroah-Hartman <>,
	YueHaibing <>,,,,,
Subject: Re: [Cocci] [PATCH] scripts: add dummy report mode to add_namespace.cocci
Date: Mon, 22 Jun 2020 10:03:45 +0200
Message-ID: <> (raw)
In-Reply-To: <>

On Thu, Jun 04, 2020 at 02:39:18PM -0600, Shuah Khan wrote:
>On 6/4/20 1:31 PM, Julia Lawall wrote:
>>On Thu, 4 Jun 2020, Matthias Maennich wrote:
>>>When running `make coccicheck` in report mode using the
>>>add_namespace.cocci file, it will fail for files that contain
>>>MODULE_LICENSE. Those match the replacement precondition, but spatch
>>>errors out as virtual.ns is not set.
>>>In order to fix that, add the virtual rule nsdeps and only do search and
>>>replace if that rule has been explicitly requested.
>>>In order to make spatch happy in report mode, we also need a dummy rule,
>>>as otherwise it errors out with "No rules apply". Using a script:python
>>>rule appears unrelated and odd, but this is the shortest I could come up
>>>Adjust scripts/nsdeps accordingly to set the nsdeps rule when run trough
>>>`make nsdeps`.
>>>Suggested-by: Julia Lawall <>
>>>Fixes: c7c4e29fb5a4 ("scripts: add_namespace: Fix coccicheck failed")
>>>Cc: YueHaibing <>
>>>Signed-off-by: Matthias Maennich <>
>>Acked-by: Julia Lawall <>
>>Shuah reported the problem to me, so you could add
>>Reported-by: Shuah Khan <>
>Very cool. No errors with this patch. Thanks for fixing it

I am happy I could fix that and thanks for confirming. I assume your
Tested-by could be added?

Is somebody willing to take this patch through their tree?


>-- Shuah
Cocci mailing list

  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-04 16:41 Matthias Maennich
2020-06-04 19:31 ` Julia Lawall
2020-06-04 20:39   ` Shuah Khan
2020-06-22  8:03     ` Matthias Maennich [this message]
2020-06-22  8:59       ` Julia Lawall
2020-06-22 14:46       ` Shuah Khan
2020-06-22 15:06         ` Greg Kroah-Hartman
2020-06-22 16:14           ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Coccinelle archive on

Archives are clonable:
	git clone --mirror cocci/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 cocci cocci/ \
	public-inbox-index cocci

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone