From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34769C433DB for ; Fri, 19 Feb 2021 09:07:05 +0000 (UTC) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3863E64EB1 for ; Fri, 19 Feb 2021 09:07:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3863E64EB1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=cocci-bounces@systeme.lip6.fr Received: from systeme.lip6.fr (systeme.lip6.fr [132.227.104.7]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 11J96o8F024829; Fri, 19 Feb 2021 10:06:50 +0100 (CET) Received: from systeme.lip6.fr (systeme.lip6.fr [127.0.0.1]) by systeme.lip6.fr (Postfix) with ESMTP id 8851777C0; Fri, 19 Feb 2021 10:06:50 +0100 (CET) Received: from isis.lip6.fr (isis.lip6.fr [132.227.60.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by systeme.lip6.fr (Postfix) with ESMTPS id 6BE093E64 for ; Fri, 19 Feb 2021 10:06:49 +0100 (CET) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) by isis.lip6.fr (8.15.2/8.15.2) with ESMTP id 11J96m3F029580 for ; Fri, 19 Feb 2021 10:06:49 +0100 (CET) Received: by mail-lj1-f181.google.com with SMTP id g1so10455170ljj.13 for ; Fri, 19 Feb 2021 01:06:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4SYuc31NBuKizkQQlJfdfOc2gXxQ85QiVTeukEPxaJo=; b=ormQc0j8An0btSeUa0iFYkyR8gdU6HzUKanQATaVi52X63IqbTTnIxn3xlINcal/56 7PTvO2eVjtgBIw8v3YPk3V+FmLL/mv03uTEc7KWQk3v8leLmXese0jcdK+0On5eOnvMn fubn8WYdy9hiDoWSTX/N8HEqdSclIpeJMJoBmKXxNI3j1mbF5FEqzcjv0q0bl6sg/25D 0CXASuCvNhXMWAMER4N+SLdwAgOM6d9baFuoh7nhejROn1j84NqgMhFFabrwJhTKzMTX N72ThaX9jsdLyZBOqqTBMP/vFx1ojbBmhiCvImXypPNqYVdxvPG7HSUd+MIZGWztx05u SjDw== X-Gm-Message-State: AOAM532TU1PaRBPbExBW8LO1g8Ra50hvOax8IMD0+eayTZDtDpYVvI9x Y1uPzCRjuaIMUzoNmFLgsN8= X-Google-Smtp-Source: ABdhPJyIr4pTFDSmke4G+1GbuqxxKbKpF9BGX1DDqXlPLYXDGwLdp2OQf47rvm9/PnFToJGmQhhu9A== X-Received: by 2002:a19:ae02:: with SMTP id f2mr4955335lfc.129.1613725608666; Fri, 19 Feb 2021 01:06:48 -0800 (PST) Received: from localhost.localdomain (broadband-188-32-236-56.ip.moscow.rt.ru. [188.32.236.56]) by smtp.googlemail.com with ESMTPSA id a10sm304097lfd.135.2021.02.19.01.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Feb 2021 01:06:48 -0800 (PST) From: Denis Efremov To: Julia Lawall Date: Fri, 19 Feb 2021 12:06:55 +0300 Message-Id: <20210219090655.8985-1-efremov@linux.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210216160326.1341741-1-efremov@linux.com> References: <20210216160326.1341741-1-efremov@linux.com> MIME-Version: 1.0 X-Greylist: Sender IP whitelisted, Sender e-mail whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Fri, 19 Feb 2021 10:06:50 +0100 (CET) X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-4.4.3 (isis.lip6.fr [132.227.60.2]); Fri, 19 Feb 2021 10:06:49 +0100 (CET) X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 X-Scanned-By: MIMEDefang 2.78 on 132.227.60.2 Cc: cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org Subject: [Cocci] [PATCH v2 RESEND] coccinelle: misc: add minmax script X-BeenThere: cocci@systeme.lip6.fr X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: cocci-bounces@systeme.lip6.fr Errors-To: cocci-bounces@systeme.lip6.fr Check for opencoded min(), max() implementations. Signed-off-by: Denis Efremov --- Changes in v2: - <... ...> instead of ... when any - org mode reports fixed - patch rule to drop excessive () scripts/coccinelle/misc/minmax.cocci | 224 +++++++++++++++++++++++++++ 1 file changed, 224 insertions(+) create mode 100644 scripts/coccinelle/misc/minmax.cocci diff --git a/scripts/coccinelle/misc/minmax.cocci b/scripts/coccinelle/misc/minmax.cocci new file mode 100644 index 000000000000..61d6b61fd82c --- /dev/null +++ b/scripts/coccinelle/misc/minmax.cocci @@ -0,0 +1,224 @@ +// SPDX-License-Identifier: GPL-2.0-only +/// +/// Check for opencoded min(), max() implementations. +/// Generated patches sometimes require adding a cast to fix compile warning. +/// Warnings/patches scope intentionally limited to a function body. +/// +// Confidence: Medium +// Copyright: (C) 2021 Denis Efremov ISPRAS +// Options: --no-includes --include-headers +// +// Keywords: min, max +// + + +virtual report +virtual org +virtual context +virtual patch + +@rmax depends on !patch@ +identifier func; +expression x, y; +binary operator cmp = {>, >=}; +position p; +@@ + +func(...) +{ + <... +* x cmp@p y ? x : y + ...> +} + +@rmaxif depends on !patch@ +identifier func; +expression x, y; +expression max_val; +binary operator cmp = {>, >=}; +position p; +@@ + +func(...) +{ + <... +* if (x cmp@p y) { +* max_val = x; +* } else { +* max_val = y; +* } + ...> +} + +@rmin depends on !patch@ +identifier func; +expression x, y; +binary operator cmp = {<, <=}; +position p; +@@ + +func(...) +{ + <... +* x cmp@p y ? x : y + ...> +} + +@rminif depends on !patch@ +identifier func; +expression x, y; +expression min_val; +binary operator cmp = {<, <=}; +position p; +@@ + +func(...) +{ + <... +* if (x cmp@p y) { +* min_val = x; +* } else { +* min_val = y; +* } + ...> +} + +@pmax depends on patch@ +identifier func; +expression x, y; +binary operator cmp = {>=, >}; +position p; +@@ + +func@p(...) +{ + <... +- x cmp y ? x : y ++ max(x, y) + ...> +} + +@pmaxif depends on patch@ +identifier func; +expression x, y; +expression max_val; +binary operator cmp = {>=, >}; +position p; +@@ + +func@p(...) +{ + <... +- if (x cmp y) { +- max_val = x; +- } else { +- max_val = y; +- } ++ max_val = max(x, y); + ...> +} + +@pmin depends on patch@ +identifier func; +expression x, y; +binary operator cmp = {<=, <}; +position p; +@@ + +func@p(...) +{ + <... +- x cmp y ? x : y ++ min(x, y) + ...> +} + +@pminif depends on patch@ +identifier func; +expression x, y; +expression min_val; +binary operator cmp = {<=, <}; +position p; +@@ + +func@p(...) +{ + <... +- if (x cmp y) { +- min_val = x; +- } else { +- min_val = y; +- } ++ min_val = min(x, y); + ...> +} + +@depends on (pmax || pmaxif || pmin || pminif)@ +identifier func; +expression x, y; +position p; +// FIXME: Coccinelle consumes all available ram and +// and timeouts on every file. +// position p = { pmin.p, pminif.p, pmax.p, pmaxif.p }; +@@ + +func@p(...) +{ + <... +( +- (min((x), (y))) ++ min(x, y) +| +- (max((x), (y))) ++ max(x, y) +) + ...> +} + +@script:python depends on report@ +p << rmax.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for max()") + +@script:python depends on org@ +p << rmax.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for max()") + +@script:python depends on report@ +p << rmaxif.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for max()") + +@script:python depends on org@ +p << rmaxif.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for max()") + +@script:python depends on report@ +p << rmin.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for min()") + +@script:python depends on org@ +p << rmin.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for min()") + +@script:python depends on report@ +p << rminif.p; +@@ + +coccilib.report.print_report(p[0], "WARNING opportunity for min()") + +@script:python depends on org@ +p << rminif.p; +@@ + +coccilib.org.print_todo(p[0], "WARNING opportunity for min()") -- 2.26.2 _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci