cocci.inria.fr archive mirror
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Julia Lawall <julia.lawall@inria.fr>, Coccinelle <cocci@systeme.lip6.fr>
Cc: Christophe Jaillet <christophe.jaillet@wanadoo.fr>
Subject: Re: [Cocci] Checking an application of the SmPL construct “<+... … ...+>”
Date: Thu, 7 May 2020 18:33:20 +0200	[thread overview]
Message-ID: <3243f0a6-52ec-d7a9-8056-d2f692842503@web.de> (raw)
In-Reply-To: <alpine.DEB.2.21.2005071818390.2505@hadrien>

>> @display@
>> @@
>> (dev_err
>> |dev_info
>> )       (
>> *        <+... get_device(...) ...+>
>>         )
>>
>>
>> Is such a test result worth for further software development considerations?
>
> No.
>
> <+... ...+> as an expression matches a single expression.

How does this information fit to the description from the software documentation?
https://github.com/coccinelle/coccinelle/blob/7cf2c23e64066d5249a64a316cc5347831f7a63f/docs/manual/cocci_syntax.tex#L783

“…, and another (<+... ...+>) indicates that the pattern in between
the ellipses must be matched at least once, on some control-flow path.
…”


> The function has multiple arguments.

Function-like macro calls should be found here.
https://elixir.bootlin.com/linux/v5.7-rc4/source/include/linux/dev_printk.h#L93

How should expression lists be handled for such an use case?

Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci

      reply	other threads:[~2020-05-07 16:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 16:00 [Cocci] Checking an application of the SmPL construct “<+... … ...+>” Markus Elfring
2020-05-07 16:19 ` Julia Lawall
2020-05-07 16:33   ` Markus Elfring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3243f0a6-52ec-d7a9-8056-d2f692842503@web.de \
    --to=markus.elfring@web.de \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=cocci@systeme.lip6.fr \
    --cc=julia.lawall@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).